mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Himangi Saraogi <himangi774@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-doc@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.de>,
	patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
	Eric Miao <eric.y.miao@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Philipp Zabel <philipp.zabel@gmail.com>,
	Paul Parsons <lost.distance@yahoo.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH 4/5] ASoC: pxa: e800_wm9712: Introduce the use of devm_gpio_request_array
Date: Sun, 6 Jul 2014 23:21:41 +0530	[thread overview]
Message-ID: <e0d09d7f466535ce9cacc2fcd9986927dfd830c7.1404665589.git.himangi774@gmail.com> (raw)
In-Reply-To: <cover.1404665589.git.himangi774@gmail.com>

This patch moves the resources allocated using gpio_request_array to the
managed interface and removes the calls to gpio_free_array in the probe
and remove functions.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
 sound/soc/pxa/e800_wm9712.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/sound/soc/pxa/e800_wm9712.c b/sound/soc/pxa/e800_wm9712.c
index 24c2078..dbc3670 100644
--- a/sound/soc/pxa/e800_wm9712.c
+++ b/sound/soc/pxa/e800_wm9712.c
@@ -112,19 +112,17 @@ static int e800_probe(struct platform_device *pdev)
 	struct snd_soc_card *card = &e800;
 	int ret;
 
-	ret = gpio_request_array(e800_audio_gpios,
-				 ARRAY_SIZE(e800_audio_gpios));
+	ret = devm_gpio_request_array(&pdev->dev, e800_audio_gpios,
+				      ARRAY_SIZE(e800_audio_gpios));
 	if (ret)
 		return ret;
 
 	card->dev = &pdev->dev;
 
 	ret = snd_soc_register_card(card);
-	if (ret) {
+	if (ret)
 		dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n",
 			ret);
-		gpio_free_array(e800_audio_gpios, ARRAY_SIZE(e800_audio_gpios));
-	}
 	return ret;
 }
 
@@ -132,7 +130,6 @@ static int e800_remove(struct platform_device *pdev)
 {
 	struct snd_soc_card *card = platform_get_drvdata(pdev);
 
-	gpio_free_array(e800_audio_gpios, ARRAY_SIZE(e800_audio_gpios));
 	snd_soc_unregister_card(card);
 	return 0;
 }
-- 
1.9.1


  parent reply	other threads:[~2014-07-06 17:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-06 17:46 [PATCH 0/5] Introduce a managed function for gpio_request_array Himangi Saraogi
2014-07-06 17:47 ` [PATCH 1/5] gpiolib: devres: Introduce the function devm_request_gpio_array Himangi Saraogi
2014-07-09 11:18   ` Rob Jones
2014-07-09 11:52     ` Julia Lawall
2014-07-09 12:48       ` Rob Jones
2014-07-10  9:21     ` Linus Walleij
2014-07-10 11:01       ` Rob Jones
2014-07-11  0:35         ` Javier Martinez Canillas
2014-07-11 10:03           ` Rob Jones
2014-07-11 10:07             ` Javier Martinez Canillas
2014-08-14 15:17               ` Rob Jones
2014-07-06 17:48 ` [PATCH 2/5] ASoC: wm1250-ev1: Use devm_gpio_request_array Himangi Saraogi
2014-07-06 17:49 ` [PATCH 3/5] ASoC: pxa: " Himangi Saraogi
2014-07-06 17:51 ` Himangi Saraogi [this message]
2014-07-06 17:52 ` [PATCH 5/5] ASoC: pxa/hx4700: Introduce the use of devm_gpio_request_array Himangi Saraogi
2014-07-09 10:14 ` [PATCH 0/5] Introduce a managed function for gpio_request_array Linus Walleij
2014-07-09 12:10   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0d09d7f466535ce9cacc2fcd9986927dfd830c7.1404665589.git.himangi774@gmail.com \
    --to=himangi774@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=eric.y.miao@gmail.com \
    --cc=gnurou@gmail.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=lost.distance@yahoo.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=perex@perex.cz \
    --cc=philipp.zabel@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®