From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C514C56202 for ; Thu, 29 Oct 2020 22:32:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36AE22076B for ; Thu, 29 Oct 2020 22:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604010777; bh=ac7XsagJj8w/JNBhxQ+52kYQS1qe6gjgqnz+5QcEA7g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=xSouQtztDp+89ENMqCFeRa5I4Ee4F3vxcNyhJw+o8db3kw74GBjQUhigXub2Xu/iT Kwfsn3c2tgyuqLCvk8qNHyoTA/kXpaaXTs4RxWluyKReme/bXMI5+58Ut79qD1jMoj iITp2JfJ7+qg2B6Y/td8tCwVjAwVBVBB0T/WCjP8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726083AbgJ2Wc4 (ORCPT ); Thu, 29 Oct 2020 18:32:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbgJ2Wcq (ORCPT ); Thu, 29 Oct 2020 18:32:46 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDD4AC0613CF for ; Thu, 29 Oct 2020 15:32:46 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id s7so5423655iol.12 for ; Thu, 29 Oct 2020 15:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6XztGCZRt5A0usmhyuoZs86DEqCkXEdFp8vHyXCDEWQ=; b=D0LRm+pzmZq/nQ+lBZVuYJGnQT2nlMbokQbXZAwwpc43BFjWt3Xn39+EuCVcyq5QEC rHkCzHxWYgU1ocQ7QB5FRxq9OuPkCiRIjukO/slUMeNRzgshi01eqrQNiS/FbTMldBoa KV9qPjIMKZjF3gQvcgylWRhhkr0QGgUT1qVxw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6XztGCZRt5A0usmhyuoZs86DEqCkXEdFp8vHyXCDEWQ=; b=Rj8nu2+ELoH7XgVnlW46xLVYIDpSX+WUGPGo0FJAO5pTGXd3NXYdbKviaq551dhJG2 jEqieQMlgLM/uC2q0v5LCI+vSluSXC5DDdhq1Pi2nfocX4s3G7BEnh8so/It+Ab6QshU varAX7Mj/yuLwNr4hGZbCs8KXVemWjrB9wEN27J8d38NLyNk7rX9jTObssxyZnSre6su GUzas2MQQhJ5aL8wNw1mrgTDhgD9tNYb+/2GGR58uCxxmhyDRSaltBwYWyFswGy+j2YC dbGDjJIw/OEC5OUjeQoVCYUapJG5eGjvcpgdZOMpwBy0+XG3dhq9MJmuNSkfN5QOrnp5 fKfg== X-Gm-Message-State: AOAM531bxUmMMlIvl2PGhBUNduYJi4E8kozGnNkzAEj0Luj4TH3WbqBQ 9waYoe5lo1OqGap8WQIHhm0BEg== X-Google-Smtp-Source: ABdhPJxKschXmJbQdhcb24ydYYi8j/PZKEMmao+aUIGVI6GDyNm3EDrWX1XdPNtwzO+TkDu56va6Yw== X-Received: by 2002:a5e:c248:: with SMTP id w8mr5393217iop.132.1604010765616; Thu, 29 Oct 2020 15:32:45 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id l4sm3062134ioj.41.2020.10.29.15.32.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 15:32:44 -0700 (PDT) Subject: Re: [PATCH 1/4] tools/power/cpupower: Read energy_perf_bias from sysfs To: Borislav Petkov Cc: X86 ML , Thomas Renninger , Shuah Khan , Len Brown , linux-pm@vger.kernel.org, LKML , Shuah Khan References: <20201015144603.27933-1-bp@alien8.de> <20201015144603.27933-2-bp@alien8.de> <7806e3c0-f435-18a0-c50d-eee3f1f7fccf@linuxfoundation.org> <20201016083754.GB8483@zn.tnic> <20201029215929.GF31903@zn.tnic> From: Shuah Khan Message-ID: Date: Thu, 29 Oct 2020 16:32:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201029215929.GF31903@zn.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29/20 3:59 PM, Borislav Petkov wrote: > On Thu, Oct 29, 2020 at 03:38:43PM -0600, Shuah Khan wrote: >> All of the other ones should be changed as such. Why add more? > > Because a patch should do one thing and one thing only. So a separate > patch which converts them all in one go should come ontop. But if you > insist for the ones I'm adding to have error handling, I can do that, of > course. > A separate patch is fine. if (numwritten < 1) { + perror("write failed"); Please add filename to the error message. Thanks. Since this depends on other changes, it can go through tip once this error message change is made. thanks, -- Shuah