From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C2AE3C276D for ; Wed, 22 Apr 2026 10:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776852580; cv=none; b=GJPJgeQflNnd84rm3TriroK9ERjvCR4lakirFv9xGEg0E3vF82uy9hUGdedMVAJT0xoHOl3r1SSW+cxaUobR36k42f32ar0enN58hf9H5/f1vgdyML6k4KHaTkK5voaqGPOY6IJ4Tw4dwoJjihBAk7bj5UW2RlYDeq21NciZ4Es= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776852580; c=relaxed/simple; bh=aSHRNBc30UbrHywNUN2ejbFNA17rHTFw7ydibc9FC7c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sApfeieFNEUH3ot6FKLMQNYEAPM3+pBo/OfbPhj/dCOHotZSofWhdTULOrpQprSaX6eE7KisEuZXk1Yo3mv0d6vxaF8IoS8pgLJRmZq+nrvGAvPB+WDY0lTlvv+SuSYdjQO57Mk9PjbWPPVtP6pQwLjCLikf2rlV0hYX+y6rMjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ehF1sogR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UvUZyrQO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ehF1sogR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UvUZyrQO" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M96Ekj664100 for ; Wed, 22 Apr 2026 10:09:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= E/w7YRWP9KM67Fs0cZqKRhWZnFRHSMbKTOmClIpjy28=; b=ehF1sogRoX9iSCPH ASjVtLJ9JnOWxepGlFL+4T793fLysehTcjRNv4xekjGZnoI0i/M+AGjuqiRx5WVp yuT4EE8BxLLgj2qg0QKvn6lGVNTNcm1kiKxkWwI4Q0NMTlFjg5tYrwiou5Xeyj6p qUinNMMM2BAfqztkl4oz3LGq3AFeP11DpUe4Q8////n7trD4WsoiBn8UKMbkBD6I jJwm1qF+Tpj4e6liBVI3JD5BVT1Lz4pO8j7rgrc0VzqetI+98WAlPx8KwRcObFMH HX2VTwCFaX3d+QCsrvCSc1L7tSRXXQ1XrfJTp13/AuCgyU1/mYlu1oE6CrnEnEBS Oh264w== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpudgr8uq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 10:09:37 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8aca5b32b89so16443116d6.1 for ; Wed, 22 Apr 2026 03:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776852576; x=1777457376; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E/w7YRWP9KM67Fs0cZqKRhWZnFRHSMbKTOmClIpjy28=; b=UvUZyrQO2fDt6rZTcPAEKIl0FmbZZzxDXq+WVJw6YI7iOlph30SIXpLiit22y3wKlv SnivxptQHPHjHxOu9xBAjT2RVoZ8OoY3RTg8Uo7LI64aB1Fi1Pt4j6/8kxvhTFGE948m xhJLWgH9vxTo8yXtwk94b7B74vt8/2yu92tMmwnFN9kz6pK+Uya52E3kRWb0Ltzc4d8X r792+MjTNx4RNOHhr2EqFSPN1pt+S/wi2AmahOb7+24swdJCV1LAzmreW3wH3Tb0bM96 pC4NVSh5hrjEwNZywoXiRkNVeTO/Me9AgFSmfH21bMIL2e4l/1meCYUURLAUKvYaq/mK OSDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776852576; x=1777457376; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E/w7YRWP9KM67Fs0cZqKRhWZnFRHSMbKTOmClIpjy28=; b=IZEk5DuUJTigwvRBhMJAjqRhkxQqjrkcIau8Z5tvZfjZJ5qvtNgJZ3XDmyk/BOsH6y Dgd0XcQf7wcWFWfmUNcT7TtOQlwMvU6VbUfr4fT7OB1Pv7IxD6muWExvFEZvtnuVwEa/ LjkEmWchzuqNt6tx21KCh/8hHU+WttWeiNHms4pvWzNbahBLUWQstP9KRnif9dJM4fnu FhHC0fkuKTSLl4UCkasmRs2T48jxJEZvU8Kkl2qkl1/Z3tAoh/bWouKpGE97FALy14If ZmCpCZf8ELWnyTNlSfQ44tZy0fc+TNfJqmrp251Kl3Xjl+gTIM5TCS+/fJthMoCLjfE4 kd7w== X-Forwarded-Encrypted: i=1; AFNElJ+CZpZ9LsN4vP47eQXeG3TJeeu4BW+0+RjVk1zinZPQlM2h+FgHGvUVB4JhY4n7zNM3fOAHfY52KYAKE9E=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4ZJ4aIrnz0CQnIqy1mdzs4AK3WkZJKIlMc5iFoVtRCo8LFr2q qNx/Ca4FgIPyl7QC0r+FGR2qOH/pZLcFgJwDkZ9fRbjJrG7V8junrzgtBg4Pdg9s5LaKNLijWUw FQbVnQUruvPHFXt43aco2XC4m55mniILmZSIU+LMn5qX+hnfbHluMkB1VjGzL0VaPtzhwGsa67R g= X-Gm-Gg: AeBDieuRMX7PB1eu53mnkldVduxufAyDyBX/j7Rh8WFjWILoiIsuNQaqQoMtCGFQ0Bl DN9rLqXFKKCR0eXbO1G3M0t5OtZgqjn8Y/dGbTngDLNbe0qotZvOOmKuDFdHYW4XmYftf6IleFp eAjiOH0KZBzjXvTtmzy8EKaPVn8v0JFJR1GqEVZ4KEYG3VWorhVoXwXhD6HtNepa/xRslJEoIAl 5lz+plsi+vahIA96GkfXjvP4Cy+XJJVwJdmMOU8stQnqZa1bM84AlL3tDoyUPhXL23gxMgannqP jTbbBf4qzTw1dSPn85UBvYRPShG5RG+h0bdt1kTTzD2iJDrguCZq2ttT3xFmQp+7mVcUBq4pDEB xWCCUN6TpxwQL0bgzT21zqwsurzlOMqKoS1tIwGj65LTUk75WnKrurK1gc1ScpbnKtiwjz30bpj OFDFvofMX1gBIs9w== X-Received: by 2002:a05:620a:29c3:b0:8cd:86a2:340c with SMTP id af79cd13be357-8e78f059175mr1855210985a.1.1776852576154; Wed, 22 Apr 2026 03:09:36 -0700 (PDT) X-Received: by 2002:a05:620a:29c3:b0:8cd:86a2:340c with SMTP id af79cd13be357-8e78f059175mr1855208085a.1.1776852575722; Wed, 22 Apr 2026 03:09:35 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-672c47fe8a0sm3182799a12.5.2026.04.22.03.09.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 03:09:34 -0700 (PDT) Message-ID: Date: Wed, 22 Apr 2026 12:09:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes To: Abel Vesa Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260331-eliza-adsp-usb-v1-0-d8a251be20c3@oss.qualcomm.com> <20260331-eliza-adsp-usb-v1-1-d8a251be20c3@oss.qualcomm.com> <69d644bd-d64e-4ef4-b0ca-b47103e84764@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: ZjT_k2vakemSyZSnO6Hmhh_BNGOloU2Y X-Authority-Analysis: v=2.4 cv=c5ibhx9l c=1 sm=1 tr=0 ts=69e89e61 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=bmElyp3J9_oKZ3-6flcA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: ZjT_k2vakemSyZSnO6Hmhh_BNGOloU2Y X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDA5NiBTYWx0ZWRfXzbRGRIcE+53a fdxvZuSvLt8MUvLVhIZIUaDz6fJLhNjnxe+5KPcenBMzAA7/T3zhM4MOqYXuPYxHGNXHQmr9LED AD5XcuEYkjqgfwHDjpd0d20smrtyQZmVPYiex44K/OItk4GTUgsNh3U5xCpPckaOni1DlVIETsj NY0JtgG5JOyIU1V4NxmBB9jeBMCeP7bbCBqMvvH+4OgdzW70+EoVq6A8aV/LUn+NK5DYr74LwD/ 0pNnAsNVKGiPHh69HPysycbmsc+IEGeIqojNfARAM9MzSv3dhg1375TaqUcWcggyvtDiKIkAZep fMT/5SuUj6dJgJE29neFuvV4mlVOEjWcI1GjKN8E05+v+0eI471zYTEKl8E9NRj/Kg+iaPd3pxk FC7YkUfcgPpPDJ6Ji4GvTXLdjk/5YbEO6tSWEkd5xJUzJal6du4hAzl8e4P6CUXcPwHcKg+qfmh SwuhMIjjpe4YDcpNwWQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 phishscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220096 On 4/22/26 11:41 AM, Abel Vesa wrote: > On 26-03-31 15:37:08, Konrad Dybcio wrote: >> On 3/31/26 12:37 PM, Abel Vesa wrote: >>> Describe the ADSP remoteproc node along with its dependencies, including >>> the IPCC mailbox, AOSS QMP and SMP2P links used for communication. >>> >>> The Eliza SoC features a USB 3.1 Gen 2 controller connected to a QMP >>> combo PHY and an SNPS eUSB2 PHY. Describe them. >>> >>> Signed-off-by: Abel Vesa >>> --- >> >> [...] >> >>> + usb_hsphy: phy@88e3000 { >>> + compatible = "qcom,eliza-snps-eusb2-phy", >>> + "qcom,sm8550-snps-eusb2-phy"; >>> + reg = <0x0 0x088e3000 0x0 0x154>; >>> + #phy-cells = <0>; >>> + >>> + clocks = <&rpmhcc RPMH_CXO_CLK>; >> >> This is TCSR_USB2_CLKREF_EN > > Good point. Will fix. > >> >> >>> + usb: usb@a600000 { >>> + compatible = "qcom,eliza-dwc3", "qcom,snps-dwc3"; >> >> Does the device suspend and resume successfully? > > Well, tested with pm_test devices and it does suspend and resume > successfully, but there is this: > > [ 54.584126] dwc3-qcom a600000.usb: port-1 HS-PHY not in L2 > > But if I'm not mistaken, this is valid accross all SNPS eUSB2 PHYs, on > all platforms that have them. Well it's not fatal, but ideally this wouldn't be there. Maybe you're missing some DWC quirk in the list, although it seems pretty long already. Perhaps Wesley would know more. Konrad