From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C59FF3C26EF for ; Thu, 8 Jan 2026 09:39:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767865183; cv=none; b=ag+qXHzTUsEebJ4PTlIrxsqWzdINyolrVvO3SVeSt5zr+tcy/WPG7rCjn5O1erVISnubhsS9B+f3FBkj6kTwsyFqduwCiJd3/5tADXvLLSmk28k5+il02wBKm7mkxlRwse3Fby3OMSLTBD3d3TB4VJdBH1M7Kr8KMY822ZBb/5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767865183; c=relaxed/simple; bh=5DWhx4+gs7oxvT3W74E2Qaw4KUyxw/PlnMnBi6Q820Y=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=RQ5o8eSQ0qgHJl6kbMtDt108phmPeFCHw+lEBg6H1aFnrN/973gGD19APz18gjMwC83c1PE06yM6G9PzUt/TzoVblj/6RweDdoKlwhhueRR7iWJ9/fbC5jGNKVc/AWZfPkDV40JDM1mXkn7t1FYhrea63FknLZ2/8xlqsmj3qBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vdmUO-0002rS-PH; Thu, 08 Jan 2026 10:39:32 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vdmUO-009eh9-0O; Thu, 08 Jan 2026 10:39:32 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1vdmUO-000000003dv-0FMp; Thu, 08 Jan 2026 10:39:32 +0100 Message-ID: Subject: Re: [PATCH 07/15] reset: use lock guards in reset core From: Philipp Zabel To: Bartosz Golaszewski , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org Date: Thu, 08 Jan 2026 10:39:31 +0100 In-Reply-To: <20260105-reset-core-refactor-v1-7-ac443103498d@oss.qualcomm.com> References: <20260105-reset-core-refactor-v1-0-ac443103498d@oss.qualcomm.com> <20260105-reset-core-refactor-v1-7-ac443103498d@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Mo, 2026-01-05 at 15:15 +0100, Bartosz Golaszewski wrote: > Simplify the locking code in reset core by using lock guard from > linux/cleanup.h. >=20 > Signed-off-by: Bartosz Golaszewski > --- > drivers/reset/core.c | 51 +++++++++++++++++++++++-----------------------= ----- > 1 file changed, 23 insertions(+), 28 deletions(-) >=20 > diff --git a/drivers/reset/core.c b/drivers/reset/core.c > index 39bedf990223212998fa8ed4cda517529f94ee23..ffb811cbc6460b48dd833d356= 0d6538eea2fd5c0 100644 > --- a/drivers/reset/core.c > +++ b/drivers/reset/core.c > @@ -1069,22 +1064,23 @@ __of_reset_control_get(struct device_node *node, = const char *id, int index, > } > } > =20 > - mutex_lock(&reset_list_mutex); > + guard(mutex)(&reset_list_mutex); > + This breaks the __reset_add_reset_gpio_device() error path, which jumps to the of_put: label without reset_list_mutex locked. See [1], where I made the same mistake: [1] https://lore.kernel.org/all/20240928222702.GX3550746@ZenIV/ regards Philipp