From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751885AbcFWRkn (ORCPT ); Thu, 23 Jun 2016 13:40:43 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:15388 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751660AbcFWRkm (ORCPT ); Thu, 23 Jun 2016 13:40:42 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 23 Jun 2016 10:39:53 -0700 Subject: Re: [RESEND PATCH] thermal: helpers: Check return value of get_temp To: Zhang Rui , Eduardo Valentin References: <1465232019-12441-1-git-send-email-rklein@nvidia.com> CC: , From: Rhyland Klein Message-ID: Date: Thu, 23 Jun 2016 13:40:39 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1465232019-12441-1-git-send-email-rklein@nvidia.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/6/2016 12:53 PM, Rhyland Klein wrote: > Check the return value of get_temp, which can fail. If it does, then > unlock and return the error code. > > Signed-off-by: Rhyland Klein > --- > drivers/thermal/thermal_helpers.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/thermal/thermal_helpers.c b/drivers/thermal/thermal_helpers.c > index 5e1c160944c9..dc260749f8d6 100644 > --- a/drivers/thermal/thermal_helpers.c > +++ b/drivers/thermal/thermal_helpers.c > @@ -90,6 +90,10 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp) > mutex_lock(&tz->lock); > > ret = tz->ops->get_temp(tz, temp); > + if (!ret) { > + mutex_unlock(&tz->lock); > + goto exit; > + } > > if (IS_ENABLED(CONFIG_THERMAL_EMULATION) && tz->emul_temperature) { > for (count = 0; count < tz->trips; count++) { > I haven't seen any comments on this. Has anyone had a chance to take a look at it yet? -rhyland -- nvpublic