From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958BFC6FA83 for ; Tue, 27 Sep 2022 07:51:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231156AbiI0Hva (ORCPT ); Tue, 27 Sep 2022 03:51:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbiI0Hv1 (ORCPT ); Tue, 27 Sep 2022 03:51:27 -0400 Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 424E82713 for ; Tue, 27 Sep 2022 00:51:26 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id AC59758055B; Tue, 27 Sep 2022 03:51:25 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Tue, 27 Sep 2022 03:51:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1664265085; x=1664268685; bh=hhJBZFDAuM e9MRrygXN+gN6m3AyhwBPuDzBCskbFGDo=; b=gYEDmTELzHrP5CPkBsK38Zi6Hl A60S9uIgc4ezMYC31OkJr5/3pioXY761DKLEsYCTR81WPFm/JDUxtlySs08ltxJO I66N0tiGbk65ABUelzf9rt0klttNHv4QFbS8K+qVGolLA4/J+LxD6mugr61FY7+E en2yY7Gu9HMbF1rRaBHxD8uMP6HGkotSSNmWe+iFx0x1dSGmrEOJagRh0onDxigp xiYscY9tx6gmMFWXC+CNOIdSyR2wU+TDq4kxgiqvEpuzX6mUaRSnrt7c+Qcg0ItD GM8+lyCabaeyNdu1RoHzcTwyu9mcl3HIDDwjsd3aiMHu8UmTpTsNBDqxLrUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664265085; x=1664268685; bh=hhJBZFDAuMe9MRrygXN+gN6m3Ayh wBPuDzBCskbFGDo=; b=DST+9PV+3Kllyz+iJXk3P56OSqIUffN4Tga7IelqAtli dUTjmP88+Qew4tRMLrEdIZyd5XUXBBLZeTHFwNGNuyaGUZyRCCEtC2rMLt48HxqH pTnGbe/weDW3sK1KvVBp+x9FMiFqSVUiK96judw6cPk4LG622AmFfNreb2VyeKNk ELWSMAxxAZsXNYJn5n6rx4F+lgViskYxg3cG1YbAcSG3VjnIb0Y/oevLWJ1VoqOw D/VYZFRLmFWAxo/OsLfc4YX5F+NNdBOF6QalsfylTPPtmRmStUWZHJx/Pc48Yjv9 +kvQbus6xAIWLmogQAhGylTP22PoLO2ScO+exOTakg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegfedguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6003AB60086; Tue, 27 Sep 2022 03:51:25 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-968-g04df58079d-fm-20220921.001-g04df5807 Mime-Version: 1.0 Message-Id: In-Reply-To: <20220927045514.2762299-1-chenhuacai@loongson.cn> References: <20220927045514.2762299-1-chenhuacai@loongson.cn> Date: Tue, 27 Sep 2022 09:51:04 +0200 From: "Arnd Bergmann" To: "Huacai Chen" , "Thomas Gleixner" , "Marc Zyngier" Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, "Xuefeng Li" , "Huacai Chen" , "Jiaxun Yang" Subject: Re: [PATCH] irqchip: Make irqchip_init() usable on pure ACPI systems Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 27, 2022, at 6:55 AM, Huacai Chen wrote: > @@ -28,7 +28,9 @@ extern struct of_device_id __irqchip_of_table[]; > > void __init irqchip_init(void) > { > +#ifdef CONFIG_OF_IRQ > of_irq_init(__irqchip_of_table); > +#endif > acpi_probe_device_table(irqchip); > } I think that #ifdef should be in the include/linux/of_irq.h header, with an empty inline function in the #else path. Arnd