From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF985C433F5 for ; Mon, 20 Sep 2021 14:13:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A624C610CE for ; Mon, 20 Sep 2021 14:13:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235391AbhITOPS (ORCPT ); Mon, 20 Sep 2021 10:15:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230079AbhITOPP (ORCPT ); Mon, 20 Sep 2021 10:15:15 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E276C061574 for ; Mon, 20 Sep 2021 07:13:48 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id t8so30142112wrq.4 for ; Mon, 20 Sep 2021 07:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RyPWjhJavEnLnTk/ZY3T6RoRIu5tJ7dnIodg5ab5Fq4=; b=qNvpjxSFc0CBA2nCwDbOEj2STtOakHiTbmD5/1YeUVj5/KhzNGMnuWrVuNluM3TD/z nXQ1Q9sLPyDfBhVxArZz91nPyzPRipRi7Kz+EPxHsgPNWbcuiSH+T+A9otbFXOwJiIrI 4GVk3z8EKT5n6OeD++CL2fgGvh7xqiznzL7+0ol36Bw+z6LORkKljVSBi0F4KyJET0XQ wmjSndgD5OwBvYn3ki+fT6BhSM1CUGV9BTPbVTTAeSwxvYAN+jkRvpBzwqOl32DC74tZ bmqruWy3UnTRw4PDm+KNYy61R3HLGk3U9svJ7o49Spg5G7Qn9b+rO2JpAPKGMXH0pSc3 SiFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=RyPWjhJavEnLnTk/ZY3T6RoRIu5tJ7dnIodg5ab5Fq4=; b=bs/qM6VCufvOvK0VEXPVUrFBqdS/ZLrqTzJth1f71jQjz0fEhkY1hbj+RVJHgZCGw8 zEE546BUr5dQdZnUUbvvx+zVfO1RowhfpI4dlC0eN4G/72eTJ1qdLa4RYuobRt0HLta5 dZYPBn1Saiezo4MeoTzoq3Nf19eyyNN7qqN5rGPMJKgI8BuA3kXUsgbOGCI62jRW4r8H GutnhurEMAJ3wR+U3riUOdhntXuIsthkehavhn6UuC2KPuZ1sxR5hXwLT6nOGFzN707Z N+9yUFVPzN7HAE6v8BC0JHPwMYRsOha65Yw4+6+u2h/aoxpE0zi1DT3XRzPnECQIXCpy GIMg== X-Gm-Message-State: AOAM532G1i9Bzn9c0j7I3lVcvg7Fu+47PF32zEpP5sfIboWxIRBvNWB4 Liy1v0XYQ0iWA5MrChoYe612/gShDxOc8T4D X-Google-Smtp-Source: ABdhPJzFeo46lPTEjbj9FZ3QIUjAD+AZBNGfuSidO6eXOl7f14VVi1qHfHc6ZobjaAEZL2G4Zu/H1Q== X-Received: by 2002:a1c:403:: with SMTP id 3mr24866812wme.161.1632147227143; Mon, 20 Sep 2021 07:13:47 -0700 (PDT) Received: from ?IPv6:2001:861:44c0:66c0:aa8a:ef22:59c5:1bf3? ([2001:861:44c0:66c0:aa8a:ef22:59c5:1bf3]) by smtp.gmail.com with ESMTPSA id n68sm20021573wmn.13.2021.09.20.07.13.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 07:13:46 -0700 (PDT) Subject: Re: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module To: Tony Lindgren Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Gowtham Tammana , Jyri Sarha References: <20210920125306.12347-1-narmstrong@baylibre.com> <20210920125306.12347-2-narmstrong@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: Date: Mon, 20 Sep 2021 16:13:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/09/2021 15:37, Tony Lindgren wrote: > Hi, > > * Neil Armstrong [210920 12:53]: >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -965,6 +965,26 @@ hdmi: encoder@0 { >> }; >> }; >> >> + target-module@59000000 { >> + compatible = "ti,sysc-omap4", "ti,sysc"; >> + reg = <0x59000020 0x4>; >> + reg-names = "rev"; >> + clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>; >> + clock-names = "fck"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x0 0x59000000 0x1000>; >> + >> + bb2d: gpu@0 { >> + compatible = "vivante,gc"; >> + reg = <0x0 0x0700>; >> + interrupts = ; >> + clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>; >> + clock-names = "core"; >> + status = "disabled"; >> + }; >> + }; >> + >> aes1_target: target-module@4b500000 { >> compatible = "ti,sysc-omap2", "ti,sysc"; >> reg = <0x4b500080 0x4>, > > How about just use the default for the bb2d node with is "okay"? > That way there's no need set status = "okay" for each board file. > > If there is no driver loaded, we idle the target-module anyways. Yes you're right, I'll resend only this patch with no status property on bb2d node. thanks, Neil > > Regards, > > Tony >