From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840B7C4741F for ; Mon, 9 Nov 2020 23:44:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37C9E2074F for ; Mon, 9 Nov 2020 23:44:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f2s5ISiX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730571AbgKIXo6 (ORCPT ); Mon, 9 Nov 2020 18:44:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729451AbgKIXo5 (ORCPT ); Mon, 9 Nov 2020 18:44:57 -0500 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D47E0C0613D3 for ; Mon, 9 Nov 2020 15:44:55 -0800 (PST) Received: by mail-ej1-x642.google.com with SMTP id s25so14846161ejy.6 for ; Mon, 09 Nov 2020 15:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NItVTPQJT2kAjNu1ETSkMiz4X0SK4Dvc9o6+cAnG4FU=; b=f2s5ISiX2NTkP8UTQgo9j5/W5MEy4drOUs8Fd0oKAnhsq/V5WizwKpnN4TZmjqIcdI 3qMMuMlorh0hQM+hiq6WnLpx2sswTLf5TxeiDwiCLgHlEnBYcjU4wdnsDwmWiP27aEth qLr0kDT9YNqUiPqwBoNwFwhDDrTO6rvDfEccb9AQbCJZuFwF6V3qle1Fv+tQkcVbgMBK OaSfj/3xhixptSyiXdLPKgI75DIZqSJwrYbnsr+n/laSMPgHlUksxHs9dWs18FMoo7iB BcVkz2g5FFTSqAXzkCnXMdB5CfU5ZEku9zR58FESzq2n4cZGSnuV5ANwJp+49vpU/t3p hF2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NItVTPQJT2kAjNu1ETSkMiz4X0SK4Dvc9o6+cAnG4FU=; b=H8B4/ACp+8tD7WXJ06vFHhHewq75hOKIKJKaPENvk9JHcp9+Ob5plWk7017CaoV/Py BNeFkaXX3fnwsQwGuQIKGX/OJEDdgkugDzwJXFlcWDLrA89MTZ57HfZ/9vwnBV5rY+kW 2jUU9ldQ+OIr/55CfY5WfdNeW658/GQsOkzQC7QJln4Q2AQ2VXw2QuKtF8p6kJRS+m4Z Ea+cknc7thVdzJn34Vx7g2VVaAatXw3LFUS5CAedjwbJabVo57An/CjFPumb+eRj++K6 /NOpc2lWuwwyRc1hNa4Y5FWgctRhdKmOwroKMGDt9efTnGIjPJ7Xy9isC/n3sI1Tw4vM SJqw== X-Gm-Message-State: AOAM532DxvgtBaaC1egW6u4NIuauN7lhHnO2qiuh2D0FHUxJoFus1qgV S9BOjkkb0lXng+FxK6XLF70eUQ== X-Google-Smtp-Source: ABdhPJyCQO54uVQ40RKc89lI+n8d8Bsjz2fCIwfOUcA/RQoxqdNLI/zQAkPbYYQQVMkJT+ruB/RqZw== X-Received: by 2002:a17:906:8319:: with SMTP id j25mr18340054ejx.68.1604965494577; Mon, 09 Nov 2020 15:44:54 -0800 (PST) Received: from [192.168.0.4] (hst-221-20.medicom.bg. [84.238.221.20]) by smtp.googlemail.com with ESMTPSA id f7sm9461242ejz.23.2020.11.09.15.44.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Nov 2020 15:44:53 -0800 (PST) Subject: Re: [PATCH 0/3] HDR10 static metadata To: Nicolas Dufresne , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Ezequiel Garcia , Hans Verkuil References: <20201109173153.23720-1-stanimir.varbanov@linaro.org> <2f907743dbb77f4c2f871675070065dd372514be.camel@collabora.com> From: Stanimir Varbanov Message-ID: Date: Tue, 10 Nov 2020 01:44:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2f907743dbb77f4c2f871675070065dd372514be.camel@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/9/20 9:53 PM, Nicolas Dufresne wrote: > Le lundi 09 novembre 2020 à 19:31 +0200, Stanimir Varbanov a écrit : >> Hello, >> >> This patchset adds two HDR10 HEVC v4l2 controls for Content Light Level >> and Mastering display colour volume plus implenmentation in Venus encoder >> driver. >> >> Comments are welcome! > > It is not a formal review, but I did walked through the new API and > everything looks fine to me. One question though, are you aware that > the H.264/AVC equivalent is identical ? What is you plan for that ? Thanks for the question, I haven't thought for avc, yet. I guess we have few options: 1. introduce hdr10-ctrls.h, common control IDs 2. duplicate structures and control IDs in hevc/h264-ctrls.h 3. common structures and separate control IDs for avc and hevc 4. another option? I'd prefer option 1. We could extend later option 1 with hdr10+. > >> >> regards, >> Stan >> >> Stanimir Varbanov (3): >>   v4l: Add HDR10 HEVC static metadata controls >>   docs: media: Document CLL and Mastering display >>   venus: venc: Add support for CLL and Mastering display controls >> >>  .../media/v4l/ext-ctrls-codec.rst | 61 +++++++++++++++++++ >>  drivers/media/platform/qcom/venus/core.h | 3 + >>  drivers/media/platform/qcom/venus/hfi_cmds.c | 8 +++ >>  .../media/platform/qcom/venus/hfi_helper.h | 20 ++++++ >>  drivers/media/platform/qcom/venus/venc.c | 29 +++++++++ >>  .../media/platform/qcom/venus/venc_ctrls.c | 16 ++++- >>  drivers/media/v4l2-core/v4l2-ctrls.c | 61 +++++++++++++++++++ >>  include/media/hevc-ctrls.h | 41 +++++++++++++ >>  include/media/v4l2-ctrls.h | 2 + >>  9 files changed, 240 insertions(+), 1 deletion(-) >> > -- regards, Stan