From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752539AbdGGRIu (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Jul 2017 13:08:50 -0400
Received: from mx2.suse.de ([195.135.220.15]:43147 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751032AbdGGRIt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Jul 2017 13:08:49 -0400
Subject: Re: Problem with commit bf22ff45bed664aefb5c4e43029057a199b7070c
To: Thomas Gleixner <tglx@linutronix.de>
Cc: jeffy.chen@rock-chips.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        xen-devel <xen-devel@lists.xenproject.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Peter Zijlstra <peterz@infradead.org>
References: <dc3e7811-e3f8-1cf9-d556-1ac57288daa5@suse.com>
 <alpine.DEB.2.20.1707071747380.1871@nanos>
From: Juergen Gross <jgross@suse.com>
Message-ID: <e0f8cba4-a301-0e3f-280b-f911d1ed5fa1@suse.com>
Date: Fri, 7 Jul 2017 19:08:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1707071747380.1871@nanos>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/07/17 18:41, Thomas Gleixner wrote:
> On Fri, 7 Jul 2017, Juergen Gross wrote:
> 
>> Commit bf22ff45bed664aefb5c4e43029057a199b7070c ("genirq: Avoid
>> unnecessary low level irq function calls") breaks Xen guest
>> save/restore handling.
>>
>> The main problem are the PV devices using Xen event channels as
>> interrupt sources which are represented as an "irq chip" in the kernel.
>> When saving the guest the event channels are masked internally. At
>> restore time event channels are re-established and unmasked via
>> irq_startup(). Unfortunately above commit will let the unmask operation
>> be a nop as the irq handling doesn't know about the masking done before.
> 
> Rightfully so. Making assumptions about the inner workings of core code is
> always wrong.

That was my thought, too. :-)

>> I have a patch repairing the issue, but I'm not sure if this way to do
>> it would be accepted. I have exported mask_irq() and I'm doing the
>> masking now through this function. Would the attached patch be
>> acceptable? Or is there a better way to solve the problem?
> 
> Without looking at the patch (too lazy to fiddle with attachments right
> now), this is definitely wrong. I'll have a look later tonight.

Thank you very much


Juergen