From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74044C2D0BF for ; Tue, 17 Dec 2019 15:47:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C1402465E for ; Tue, 17 Dec 2019 15:47:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="jdlk6KB1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728076AbfLQPro (ORCPT ); Tue, 17 Dec 2019 10:47:44 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38552 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727572AbfLQPro (ORCPT ); Tue, 17 Dec 2019 10:47:44 -0500 Received: by mail-wr1-f65.google.com with SMTP id y17so11839945wrh.5 for ; Tue, 17 Dec 2019 07:47:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BH/GNjEuKwaSuSLw1wxU/rm9ywlcEyhGqhViGDKQ4n8=; b=jdlk6KB1CQWgSVBxrjkbO6Q1OsOiue3Cc/wgX96MQkUYTuLzX2w7+HbSI+nRie5Hxk DG9NML7SiMN6vJegdzuGh6e+MAYSG3B+SOz+jxM6SoOdUBJ7Ak7PveWFZ+y1TpG36DCq nW2/SQIy1ll4xvPGTmsqZDoobeu25hgFrGHRaMSwIq7GbdTqem9GTFRILHLl6pUBBeLF a25wSxYfSh97FiIFAqDPFtZOAYeAcCiiUk4u6lY9lVJmqbnDyLSisY5IieKTPCDza7rQ sNF54PXRt4GCWD7estr0m3j80SCByhlIfD5dEU6XpavUIT7ncxibg3PKJ+V0ce51XMRq bNXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BH/GNjEuKwaSuSLw1wxU/rm9ywlcEyhGqhViGDKQ4n8=; b=Tx/KqlEmL2BGYvnCCRV4e+qbH3KT1Qneeu8N6l3p7h7wqdqVyuJEPjXrJZbPWKHueJ ryI2LvWuxw+Lzi7GCvNay5hBXVX7jUHMKTWmrgiTBvB1EV4qb1F1W5nqCUgJNuKKY+xq 7pXZiKhQ8vkYF3TQ+799yor6moRbGSWuhrj3KV/ktvLSXVhTJVTgJQiszPK1v0sruPIN qDnRUF2w7pvGNqGtcXfsUGds7QcHeslS0vSfvUU9H3UMqmRWJ+wJuPej/dm/gRie9+PL JFwsmVtCZlTH/YCiSlOnRLl56gV7DvZYKssdcUxF+u0Lm+F3WjzLOY+X4UDPTy69yeGl Tfvg== X-Gm-Message-State: APjAAAWrFiW4YAWKHj66380SFiwLoDmzabxp58ZfVPkKkoYjmcFrOkqt TGqJwUSHUXSH2W8zs/dVtW1QECtE+mg= X-Google-Smtp-Source: APXvYqwnEA0SeuV8gW6pD1T907mTdAFjzJEgCw4Kn6mp7NMydfnWBMc4mxcEFNljrORO3+RH5Oh13g== X-Received: by 2002:adf:d4ca:: with SMTP id w10mr14624687wrk.53.1576597661609; Tue, 17 Dec 2019 07:47:41 -0800 (PST) Received: from [10.83.36.153] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id k13sm25710075wrx.59.2019.12.17.07.47.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2019 07:47:40 -0800 (PST) Subject: Re: [PATCH] tty: serial: samsung_tty: do not abuse the struct uart_port unused fields To: Greg Kroah-Hartman , Kukjin Kim , Hyunki Koo , HYUN-KI KOO , Shinbeom Choi , Krzysztof Kozlowski Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191217140232.GA3489190@kroah.com> From: Dmitry Safonov Message-ID: Date: Tue, 17 Dec 2019 15:47:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20191217140232.GA3489190@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/17/19 2:02 PM, Greg Kroah-Hartman wrote: > The samsung_tty driver was trying to abuse the struct uart_port by using > two "empty" bytes for its own use. That's not ok, and was found by > removing those fields from the structure. > > Move the variables into the port-specific structure, which is where > everything else for this port already is. There is no space wasted here > as there was an empty "hole" in the structure already for these bytes. Thanks! Sorry for not noticing this myself. > Cc: Kukjin Kim > Cc: Hyunki Koo > Cc: HYUN-KI KOO > Cc: Shinbeom Choi > Cc: Krzysztof Kozlowski > Cc: Dmitry Safonov > Cc: Jiri Slaby > Cc: linux-serial@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman I see you already applied it to your tree, but in case it helps anything: Reviewed-by: Dmitry Safonov Thanks, Dmitry