From: Ivan Vecera <ivecera@redhat.com>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: Prathosh Satish <Prathosh.Satish@microchip.com>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org,
Michal Schmidt <mschmidt@redhat.com>,
Petr Oros <poros@redhat.com>
Subject: Re: [PATCH net-next 4/5] dpll: zl3073x: Add support to adjust phase
Date: Tue, 15 Jul 2025 16:24:36 +0200 [thread overview]
Message-ID: <e1078cc6-f22e-441a-86f5-8c4c6e239f02@redhat.com> (raw)
In-Reply-To: <495a37e7-e31d-4671-a4d9-7e653ad80b60@redhat.com>
On 15. 07. 25 3:12 odp., Paolo Abeni wrote:
> On 7/10/25 5:38 PM, Ivan Vecera wrote:
>> +static int
>> +zl3073x_dpll_output_pin_phase_adjust_get(const struct dpll_pin *dpll_pin,
>> + void *pin_priv,
>> + const struct dpll_device *dpll,
>> + void *dpll_priv,
>> + s32 *phase_adjust,
>> + struct netlink_ext_ack *extack)
>> +{
>> + struct zl3073x_dpll *zldpll = dpll_priv;
>> + struct zl3073x_dev *zldev = zldpll->dev;
>> + struct zl3073x_dpll_pin *pin = pin_priv;
>> + u32 synth_freq;
>> + s32 phase_comp;
>> + u8 out, synth;
>> + int rc;
>> +
>> + out = zl3073x_output_pin_out_get(pin->id);
>> + synth = zl3073x_out_synth_get(zldev, out);
>> + synth_freq = zl3073x_synth_freq_get(zldev, synth);
>> +
>> + guard(mutex)(&zldev->multiop_lock);
>> +
>> + /* Read output configuration */
>> + rc = zl3073x_mb_op(zldev, ZL_REG_OUTPUT_MB_SEM, ZL_OUTPUT_MB_SEM_RD,
>> + ZL_REG_OUTPUT_MB_MASK, BIT(out));
>> + if (rc)
>> + return rc;
>> +
>> + /* Read current output phase compensation */
>> + rc = zl3073x_read_u32(zldev, ZL_REG_OUTPUT_PHASE_COMP, &phase_comp);
>> + if (rc)
>> + return rc;
>> +
>> + /* Value in register is expressed in half synth clock cycles */
>> + phase_comp *= (int)div_u64(PSEC_PER_SEC, 2 * synth_freq);
>
> Is 'synth_freq' guaranteed to be != 0 even on extreme conditions?
> Possibly a comment or an explicit check could help.
Under normal conditions (device is working and synth is enabled) this
should not happen but additional check here is reasonable to catch
unusual conditions to avoid division by zero.
Will add it.
Thanks,
Ivan
next prev parent reply other threads:[~2025-07-15 14:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 15:38 [PATCH net-next 0/5] dpll: zl3073x: Add misc features Ivan Vecera
2025-07-10 15:38 ` [PATCH net-next 1/5] dpll: zl3073x: Add support to get/set esync on pins Ivan Vecera
2025-07-14 14:13 ` Prathosh.Satish
2025-07-15 12:52 ` Paolo Abeni
2025-07-15 14:10 ` Ivan Vecera
2025-07-10 15:38 ` [PATCH net-next 2/5] dpll: zl3073x: Add support to get phase offset on connected input pin Ivan Vecera
2025-07-14 14:14 ` Prathosh.Satish
2025-07-10 15:38 ` [PATCH net-next 3/5] dpll: zl3073x: Implement phase offset monitor feature Ivan Vecera
2025-07-14 14:15 ` Prathosh.Satish
2025-07-15 13:02 ` Paolo Abeni
2025-07-15 14:18 ` Ivan Vecera
2025-07-10 15:38 ` [PATCH net-next 4/5] dpll: zl3073x: Add support to adjust phase Ivan Vecera
2025-07-14 14:15 ` Prathosh.Satish
2025-07-15 13:12 ` Paolo Abeni
2025-07-15 14:24 ` Ivan Vecera [this message]
2025-07-10 15:38 ` [PATCH net-next 5/5] dpll: zl3073x: Add support to get fractional frequency offset Ivan Vecera
2025-07-14 10:55 ` [PATCH net-next 0/5] dpll: zl3073x: Add misc features Jiri Pirko
2025-07-14 14:11 ` Prathosh.Satish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1078cc6-f22e-441a-86f5-8c4c6e239f02@redhat.com \
--to=ivecera@redhat.com \
--cc=Prathosh.Satish@microchip.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®