From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993833AbdDZIHo (ORCPT ); Wed, 26 Apr 2017 04:07:44 -0400 Received: from mout.web.de ([217.72.192.78]:62299 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1956780AbdDZIGb (ORCPT ); Wed, 26 Apr 2017 04:06:31 -0400 To: kernel@stlinux.com, linux-arm-kernel@lists.infradead.org, Patrice Chotard , Philipp Zabel , Srinivas Kandagatla , Stephen Gallimore From: SF Markus Elfring Subject: [PATCH] reset: sti: Use devm_kcalloc() in syscfg_reset_controller_register() Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: Date: Wed, 26 Apr 2017 10:05:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ZHplcEa5dKWXPp8K5lvzvYNJGMWripa7/jJCMtegtAEksSJvOxm aAtYamPiXtrtPcRYriGmx7tvEUxHKjHTY8V6kA3ynGc8WYqCU7MrLWg86stCUYfYKzSNL03 pBPFqcJwI2YuXhD3PbHFqHShdJYvjxPKJSRVVZuckWypTZuxNmMwO43ntLDsD2KEvO6YGf9 BHr440WgJjIBVY9r05XlQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Vq5QgvRbDak=:1NZqF9qW7w5f5EosVAOuTP Vcx9ZgvGozRDD/fTFst8HZW500w+x1GWkWlljttngZ7oMrvA19jJzfrbuqq9zNyqkj+7E3UnA t5wpDk+B0vwilR81qCP8iJwUi/irUrgAHn96xfad/MUCf0eIs+JGFY93wpbJR1CZi/QWc3isc lIWb0oc6aylIHv5uIO3/YNdVthVjUHScPs6kNH8R2OU8dShk7e4+3L8khnJ08LDZoOjoSJckF 2gnRSZ0fUvc1COCIVOnVmUhv7YTQa2DonV2DenezoU1K6+QXIEigx3kzllg1skT4f2dMrgYtH JKD2fPTFtAgz/XvEM9iL326DNLsN41qDU1mKKEyd7VnJWQNt9dSu5ZDjiUboIRxh+xWMSYEVL u+Se+HrtKBJ2W6yf9PjRGPHRh5nUCmN9CO4VqbODPKzeiwMZpov8vsdTEpZLuSb6YX3c7rd/b PtSBpQ9a1Q3o7gFQoiUX9TXtp4/0D6QUlpcRjLPYeZLfOC4bAVlKjgTcEtnZRybxkW0iD+Pto 89HaJihvbT2GOVyexCriEgpVmlYiijX5lXKtJ/Ss/TgYwusJ4vxrlQVXbkE0GdFL2Ig0RECH3 t7tRUFccJCMLzz1nuLqyr28wyqxNnxs8V38HD46zv4Mn79Xk4X/QuCGJx36biwrZYtc0RzZW3 grvjwu87BRFBnOsXahNXxEdne6j4MIKSycDWuItQVNch2aQf+e9yEdO9ak/x+ZyrTJa4ViVI2 koq9fhTUrowjs6SUz5cBe3JQAcpGd2luJ65b/wmgAE52v0bfzlp11SQVqcIp2fRddbOJs34Er f1RiQiC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 26 Apr 2017 09:50:34 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. * Delete the local variable "size" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/reset/sti/reset-syscfg.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/reset/sti/reset-syscfg.c b/drivers/reset/sti/reset-syscfg.c index 9bd57a5eee72..7e0f2aa55ba7 100644 --- a/drivers/reset/sti/reset-syscfg.c +++ b/drivers/reset/sti/reset-syscfg.c @@ -145,16 +145,14 @@ static int syscfg_reset_controller_register(struct device *dev, const struct syscfg_reset_controller_data *data) { struct syscfg_reset_controller *rc; - size_t size; int i, err; rc = devm_kzalloc(dev, sizeof(*rc), GFP_KERNEL); if (!rc) return -ENOMEM; - size = sizeof(struct syscfg_reset_channel) * data->nr_channels; - - rc->channels = devm_kzalloc(dev, size, GFP_KERNEL); + rc->channels = devm_kcalloc(dev, data->nr_channels, + sizeof(*rc->channels), GFP_KERNEL); if (!rc->channels) return -ENOMEM; -- 2.12.2