From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29989C0015E for ; Thu, 13 Jul 2023 13:32:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235072AbjGMNcA (ORCPT ); Thu, 13 Jul 2023 09:32:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233465AbjGMNb5 (ORCPT ); Thu, 13 Jul 2023 09:31:57 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CD872721; Thu, 13 Jul 2023 06:31:39 -0700 (PDT) Received: from nicolas-tpx395.localdomain (unknown [IPv6:2606:6d00:10:88d9::7a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4590B6602B7B; Thu, 13 Jul 2023 14:31:36 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1689255097; bh=kDEUD709UYt0FjgiG/msV7myR0LpqdQLMgwbpdW2vWU=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=MsqC4KZJaLsbwjzlNs9FondR2rTs5Uer9WQqF6jh117t04M6NCA5h0LTL6O/Zlmvk xzbP4jWlJLirMvS9Bm6NdM98TWjsBam1fx7oPzx7Jv0GQkU/m0LdKm8EhRXZZlX8dt G+Hg3P9PFpKopraeY47HPne4T1WtbOH2bhYFdE4VMzygrD0aEC6FdvKmkiFeE/JmmJ 9hERdEOFoad1su/qEdOXb5M/KnOT2eK5qcYu7xmcCMAlVXxe46SoU0TYJqOXJuHR3V rfuD5n9mzbFZorP0R8wyXTl5dDapFN5l/H0wt9Av+6FZey5745iCgTEF3/vOcM+daA AR2kZ2YT49Ylg== Message-ID: Subject: Re: [PATCH 0/3] media: mediatek: vcodec: Add driver to support 10bit From: Nicolas Dufresne To: Yunfei Dong =?UTF-8?Q?=28=E8=91=A3=E4=BA=91=E9=A3=9E=29?= , "nhebert@chromium.org" , "benjamin.gaignard@collabora.com" , "nfraprado@collabora.com" , "angelogioacchino.delregno@collabora.com" , "hverkuil-cisco@xs4all.nl" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "frkoenig@chromium.org" , "stevecho@chromium.org" , "wenst@chromium.org" , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , "daniel@ffwll.ch" , Mingjia Zhang =?UTF-8?Q?=28=E5=BC=A0=E6=98=8E=E4=BD=B3=29?= , Project_Global_Chrome_Upstream_Group , "hsinyi@chromium.org" , "linux-arm-kernel@lists.infradead.org" Date: Thu, 13 Jul 2023 09:31:27 -0400 In-Reply-To: References: <20230711125749.15555-1-yunfei.dong@mediatek.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le mercredi 12 juillet 2023 =C3=A0 03:11 +0000, Yunfei Dong (=E8=91=A3=E4= =BA=91=E9=A3=9E) a =C3=A9crit=C2=A0: > > This cover letter is missing v4l2-compliance report. This is needed > > whenever > > format mechanism is modified in a driver (not just for new drivers). > > Please add > > and make sure there is not regression too. > >=20 > Forgot to test v4l2-compliance, will add in next patch. >=20 > The flush test not include H264 for test fail, according to mingjia's > information, maybe gstreamer set wrong format. H264 fluster can test > pass when kernel driver force h264 in raster mode. For everyone interested, I've rebased MT2110R and MT2110T support MR in GStreamer. With the offending "return -EINVAL" removed, the test passes for= me. Consider updating your GStreamer build, let me know if you see further issu= e with GStreamer in this regard. I'm only missing a firmware with HEVC and 10= bit combined to confirm HEVC works too. https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3444 cheer, Nicolas