From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EACD3C585B for ; Fri, 29 May 2026 10:46:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780051568; cv=none; b=B0dbUFRrylX7G46MqqON0mGMtv1tSisUHzD+qCfniTavB8HOGKPypYOEX7TMdui4dnZ1/tgOtSv//fH3gFm3Ad2OEmhe+KejueNtCOS7XBCknlCfYXXc+UWUr0y5PNwPOdnXpJXd7EgkPBI0qQBoYrH9KUfYNBGOxY5CLFOrtac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780051568; c=relaxed/simple; bh=BzKay9Zrgr8HUXKy/Wnq91DkIwvyoKa451n4hP++RhM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CEoSSCkKH7lP4tlffJNvkONfKcaVVjpS6A8WlCXZuz5DDPUAPj4BoMGyB3Jxv0zvkwZPPpB9elEdxw2jr68PfNtz/bxBr4crmdzsbBAL+npjJcGs3xVcj3Ev+FhnCUsgxY2TksRN41+MEUuu8gxUJezb5XoNHgqXck0FdYeCrxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gE96DDkw; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gE96DDkw" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5a8ccfcbb3fso1352397e87.2 for ; Fri, 29 May 2026 03:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780051564; x=1780656364; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UilomXHH4waqyt5qI9rlYVpSlWxvQ+5JxykD1SfQgw8=; b=gE96DDkwmsyBQIhZSOLojF/cyIQYToHk54Z5zs0HukxE+gQCr0W2psTL6d4xFd5iTL 5pGVSCOlLAa2vvqvgqqFCHM9s/dypvOkVAfk/MxgC+1mCQxkPRACKHgv3c5xNGfp1YPV fXmB1ptwLHONtZFchkxNK9neXFsKiqatiWR3mh4qYx02tgB9Q/QJYm27LMkCL/HWAcLF 6UffA8DrEllrUxZG9EYDEGU0EVXLgLU3Jd0xgM1RPtiUSz78eI4jXLRJ2m5hgZRm8AiD TDLBQs4TeO/UOqYtbde/IM4P8FkfEHiU7RvcE2cn1MwjMq380zml30wBc6+Tp+XD2BQX h6bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780051564; x=1780656364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UilomXHH4waqyt5qI9rlYVpSlWxvQ+5JxykD1SfQgw8=; b=fsewpEp9fZcvY5NCgnCtoKLt2+2/f89uSzGFkrcYN3mKnODwMCJUDlsUKgZN8GLe5t pA14x4dixCOy7sRzutDhaZPA/FDWJiw9zgqij6K2XeN+lW7vFC4h0wzHjMGpqRnKNi63 xIPSMWPHxIk1YgHSEAsaQ5uK7zm47/5fA+T9RRsCn7nwjARfD1Dx51R+4+YEV+eD3X+b VPScFrmlER8sadG27uboCOEoKgJGMQg6H1bmRk2ejmzt7HxUwFRPcaX8CfM7tSmxZm/l P0I7WjeNQ1rGX050RvhNme6WtvX3L84RC9nSaIo/wE3gs5WI+JpickSkY+FKlzrfwo1E VvEA== X-Forwarded-Encrypted: i=1; AFNElJ/qKone1NcfhJLt8PH1KY49Pem68CaoLOxE9w7YqnBqwdSsg/zFjnEGX7yTJszLfPVkhiE3ikw61iJUUlI=@vger.kernel.org X-Gm-Message-State: AOJu0YzhdohhgKNAWeqNOD96vfTrtGKg94m+jQnYghe+Qlxmdzlg3Hnx agYHislf+xXyQvKOP/iNbJaewm7hSIu/s10N2eTV7b3+8LTw6tFFbvhi X-Gm-Gg: Acq92OE12xWZzCvYCKxfCJlziRPEoV3AKIYyZWcBEJmViHD209eOOc3DbbnYb1QV+Xu HQGrifhznlwJx8spjv4vhfMdxpM7fhcBbdVdVAMlkRim0jaJPcfXki+1zzdpiB5eqRdqPlsRakb MVuasrKQRU8nTAzmK6gOV414l6Ks1m6hBieHDOV6gUdZEQVVshLLRtUSc2XK0si5CoS+inGKgCs lbF5Whsl0gNcgH2GhaTjWebi45r4rSPT6yzukPQR5PRaeFsmRAsTz0ZX6GPGRmYea44UYUXvm6/ 7COHvOSIVOi/MUdTWFV1XdyyAhavIYpfsG/yr4iRsPccV0b+UAIbKH2MyHTO49DBUvXV+pqT1NY dduNd63vj2U+CVrTGkHxKoTP4Hm7OcskarmiY86x92CD0oaALg40BSfoa9Wv7l4rhV4jbE6oQRj JUPJPqbfrypx4EU41wP/daOGMYlRr2QBStJSpoOhlznY8hLJ4GLM/vnIQ= X-Received: by 2002:a05:6512:3a8a:b0:5a8:847a:dee2 with SMTP id 2adb3069b0e04-5aa5949d066mr324829e87.3.1780051563496; Fri, 29 May 2026 03:46:03 -0700 (PDT) Received: from localhost.localdomain ([94.158.61.193]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa5b788811sm192604e87.63.2026.05.29.03.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 03:46:02 -0700 (PDT) From: Stepan Ionichev To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] iio: accel: mma8452: use devm_pm_runtime_enable() to fix probe error path Date: Fri, 29 May 2026 15:45:44 +0500 Message-Id: X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mma8452_probe() calls pm_runtime_enable() and then iio_device_register(). If iio_device_register() fails the function jumps to buffer_cleanup but the existing manual unwind does not call pm_runtime_disable(), leaking the runtime PM enable_count on probe failure and on subsequent rebind. Switch to devm_pm_runtime_enable() so the enable (and the matching dont_use_autosuspend) are torn down automatically. On its new error path the probe jumps to the existing buffer_cleanup label so the triggered buffer, trigger and regulator cleanup chain stays intact. The pm_runtime_disable() and pm_runtime_set_suspended() calls in mma8452_remove() are dropped; the devm action runs after .remove() and handles the teardown. Signed-off-by: Stepan Ionichev --- drivers/iio/accel/mma8452.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 15172ba2972c..88ed47d33e03 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -1693,7 +1693,9 @@ static int mma8452_probe(struct i2c_client *client) if (ret < 0) goto buffer_cleanup; - pm_runtime_enable(&client->dev); + ret = devm_pm_runtime_enable(&client->dev); + if (ret) + goto buffer_cleanup; pm_runtime_set_autosuspend_delay(&client->dev, MMA8452_AUTO_SUSPEND_DELAY_MS); pm_runtime_use_autosuspend(&client->dev); @@ -1733,9 +1735,6 @@ static void mma8452_remove(struct i2c_client *client) iio_device_unregister(indio_dev); - pm_runtime_disable(&client->dev); - pm_runtime_set_suspended(&client->dev); - iio_triggered_buffer_cleanup(indio_dev); mma8452_trigger_cleanup(indio_dev); mma8452_standby(iio_priv(indio_dev)); -- 2.43.0