From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F19C433FE for ; Tue, 22 Nov 2022 15:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233151AbiKVPik (ORCPT ); Tue, 22 Nov 2022 10:38:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232611AbiKVPif (ORCPT ); Tue, 22 Nov 2022 10:38:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4F8E716F3 for ; Tue, 22 Nov 2022 07:37:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669131459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IYJvZpyPquZ6swRZiIUcOh5y3RG1j/mpcsdgMWy7LiQ=; b=Cpardqg6t3Ss7nB3VrcdbaQ6cuiGx7ylZ2cYySroILs2fHYJFwLgtt7yRjLRf74pUAkkXt V4Jc4xpR75RD/YRFzreU87+ocvSRkuQTH9JN6Xq3okWjrFZy+WbYDV/G2dh5f0vKxP1q3X 8SjK8t3oZub6IK3FMWIErmHdJ9pfRss= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-171-FdxfKEs5NymGllJQBR5nXw-1; Tue, 22 Nov 2022 10:37:38 -0500 X-MC-Unique: FdxfKEs5NymGllJQBR5nXw-1 Received: by mail-qt1-f198.google.com with SMTP id u31-20020a05622a199f00b003a51fa90654so14830988qtc.19 for ; Tue, 22 Nov 2022 07:37:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IYJvZpyPquZ6swRZiIUcOh5y3RG1j/mpcsdgMWy7LiQ=; b=SWTbHgjG5gYodTapV4MmWSEiCX4VU4+dSNfiYQm60DSGXiOCnTdr4AZAkJ+pjYisIq VHWY2xBnj1uSCwGH+xW2al/BxfYNX4KyV7vS3qCuzVtObfjGaoG6Q9DY9F/peu2z+EOs Urt6Hp/V8W6TgrQaqCHrie2YEh7eTSmVOI5hEHH6Z40J5/cAT2mpMDXUTAV66smN9t4O sXrAshXL5diYay9K88d1V6NhmcgZ55EjzewoXzQoR7GF/6P81z3ad8QgPBVNDupJAhV3 3A7+T40ht14XS3v40GJfxuXLb8eeVFZyPslA7OmPwFNEpwLZ+3EA5tXwd6xGuxesnf5a UwHQ== X-Gm-Message-State: ANoB5pm84bQP+vIBYtkFTLlU4y60KqCWFgH7wwidf5d4VokzxLUMRcOB J1zkauHwppJVofOwAD9aRLbNFdvpaEtQv6H9aa+04NzbhidjQhOSoDPXIbuIh72dCU6hAQitsED RNGTMFgtFi1lc5mLJxf7YP8wG X-Received: by 2002:a37:cd1:0:b0:6fb:74c7:ccf with SMTP id 200-20020a370cd1000000b006fb74c70ccfmr7682948qkm.146.1669131457578; Tue, 22 Nov 2022 07:37:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf6QcSoyyAxhrMKUbI9B03XaxqOQnOQuQhGiLn/VICj3mwjpfdUO6hBBmalLljb94SkdlehA4Q== X-Received: by 2002:a37:cd1:0:b0:6fb:74c7:ccf with SMTP id 200-20020a370cd1000000b006fb74c70ccfmr7682932qkm.146.1669131457341; Tue, 22 Nov 2022 07:37:37 -0800 (PST) Received: from [192.168.33.110] (c-73-19-232-221.hsd1.tn.comcast.net. [73.19.232.221]) by smtp.gmail.com with ESMTPSA id x10-20020a05620a258a00b006bb82221013sm10418903qko.0.2022.11.22.07.37.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 07:37:36 -0800 (PST) Message-ID: Date: Tue, 22 Nov 2022 10:37:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH net-next 2/2] bonding: fix link recovery in mode 2 when updelay is nonzero To: Paolo Abeni , netdev@vger.kernel.org, Jay Vosburgh Cc: Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org References: <38fbc36783d583f805f30fb3a55a8a87f67b59ac.camel@redhat.com> <1fe036eb-5207-eccd-0cb3-aa22f5d130ce@redhat.com> <5718ba71a8755040f61ed7b2f688b1067ca56594.camel@redhat.com> Content-Language: en-US From: Jonathan Toppins In-Reply-To: <5718ba71a8755040f61ed7b2f688b1067ca56594.camel@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/22/22 09:45, Paolo Abeni wrote: > On Tue, 2022-11-22 at 08:36 -0500, Jonathan Toppins wrote: >> On 11/22/22 05:59, Paolo Abeni wrote: >>> Hello, >>> >>> On Fri, 2022-11-18 at 15:30 -0500, Jonathan Toppins wrote: >>>> Before this change when a bond in mode 2 lost link, all of its slaves >>>> lost link, the bonding device would never recover even after the >>>> expiration of updelay. This change removes the updelay when the bond >>>> currently has no usable links. Conforming to bonding.txt section 13.1 >>>> paragraph 4. >>>> >>>> Signed-off-by: Jonathan Toppins >>> >>> Why are you targeting net-next? This looks like something suitable to >>> the -net tree to me. If, so could you please include a Fixes tag? >>> >>> Note that we can add new self-tests even via the -net tree. >>> >> >> I could not find a reasonable fixes tag for this, hence why I targeted >> the net-next tree. > > When in doubt I think it's preferrable to point out a commit surely > affected by the issue - even if that is possibly not the one > introducing the issue - than no Fixes as all. The lack of tag will make > more difficult the work for stable teams. > > In this specific case I think that: > > Fixes: 41f891004063 ("bonding: ignore updelay param when there is no active slave") > > should be ok, WDYT? if you agree would you mind repost for -net? > > Thanks, > > Paolo > Yes that looks like a good one. I will repost to -net a v2 that includes changes to reduce the number of icmp echos sent before failing the test. Thanks, -Jon