From: Dmitry Osipenko <digetx@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jiada Wang <jiada_wang@mentor.com>,
nick@shmanahar.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Andrew_Gabbasov@mentor.com
Subject: Re: [PATCH v4 1/1] Input: atmel_mxt_ts - implement I2C retries
Date: Mon, 14 Sep 2020 19:28:38 +0300 [thread overview]
Message-ID: <e116e162-763a-ff0f-5b33-35024d0f57c2@gmail.com> (raw)
In-Reply-To: <CAHp75Vfg6=5u1fthsub3xw3dxAKTGPUHfamjK_A2b5hcyw25PA@mail.gmail.com>
14.09.2020 18:50, Andy Shevchenko пишет:
...
>> It's more preferred
>> to accept patch as-is if it does right thing and then maintainer could
>> modify the patch, making cosmetic changes.
>
> It depends on the maintainer's workflow (which may be different from
> maintainer to maintainer).
Sure!
It's awesome that you're pointing out it all in the reviews because it's
important to have such things explained and definitely should help to
improve quality of further of patches! But it shouldn't be necessary to
demand a very minor changes, IMO.
In particular Jiada was submitting this and lots of other atmel_mxt_ts
patches for about a year now without much progress yet, and you probably
should know how a frustrating experience this could be for a contributor
since you're a longtime kernel developer.
next prev parent reply other threads:[~2020-09-14 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 0:55 Jiada Wang
2020-09-13 8:43 ` Andy Shevchenko
2020-09-13 12:57 ` Dmitry Osipenko
2020-09-14 13:49 ` Andy Shevchenko
2020-09-14 15:26 ` Dmitry Osipenko
2020-09-14 15:50 ` Andy Shevchenko
2020-09-14 16:28 ` Dmitry Osipenko [this message]
2020-09-13 16:56 ` Dmitry Torokhov
2020-09-14 17:29 ` Dmitry Osipenko
2020-09-14 19:33 ` Dmitry Torokhov
2020-09-14 19:36 ` Dmitry Torokhov
2020-09-14 21:33 ` Dmitry Osipenko
2020-09-14 22:32 ` Dmitry Torokhov
2020-09-15 1:13 ` Rob Herring
2020-09-15 15:55 ` Wang, Jiada
2020-09-15 17:40 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e116e162-763a-ff0f-5b33-35024d0f57c2@gmail.com \
--to=digetx@gmail.com \
--cc=Andrew_Gabbasov@mentor.com \
--cc=andy.shevchenko@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=jiada_wang@mentor.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®