mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bean Huo <beanhuo@iokpp.de>
To: Can Guo <can.guo@oss.qualcomm.com>,
	avri.altman@wdc.com, bvanassche@acm.org,  beanhuo@micron.com,
	martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	"open list:ARM/Mediatek SoC support:Keyword:mediatek"
	<linux-kernel@vger.kernel.org>,
	"moderated list:ARM/Mediatek SoC support:Keyword:mediatek"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support:Keyword:mediatek"
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 00/11] scsi: ufs: Add TX Equalization support for UFS 5.0
Date: Thu, 05 Mar 2026 16:04:43 +0100	[thread overview]
Message-ID: <e116e78ad9590f5845aaaf7d4e26833a7a0194d0.camel@iokpp.de> (raw)
In-Reply-To: <20260304135313.413688-1-can.guo@oss.qualcomm.com>

Can, 

On Wed, 2026-03-04 at 05:53 -0800, Can Guo wrote:
> Hi,
> 
> The UFS 5.0 standard was published today, 

Myabe replace time sensitive wording “published today” with stable wording?


> introducing support for HS-G6
> (23.2 Gbps per lane) through the new UniPro V3.0 interconnect layer and
> M-PHY V6.0 physical layer specifications. To achieve reliable operation
> at these higher speeds, UniPro V3.0 introduces TX Equalization and
> Pre-Coding mechanisms that are essential for signal integrity.
> 
> This patch series implements TX Equalization support in the UFS core
> driver as specified in UFSHCI v5.0, along with the necessary vendor
> operations and a reference implementation for Qualcomm UFS host
> controllers.
> 
> Background
> ==========
> 
> TX Equalization is a signal conditioning technique that compensates for
> channel impairments at high data rates (HS-G4 through HS-G6). It works
> by adjusting two key parameters:
> 
> - PreShoot: Pre-emphasis applied before the main signal transition
> - DeEmphasis: De-emphasis applied after the main signal transition
> 
> UniPro V3.0 defines TX Equalization Training (EQTR) procedure to
> automatically discover optimal TX Equalization settings. The EQTR
> procedure:
> 
> 1. Starts from the most reliable link state (HS-G1)
> 2. Iterates through all possible PreShoot and DeEmphasis combinations
> 3. Evaluates signal quality using Figure of Merit (FOM) measurements
> 4. Selects the best settings for both host and device TX lanes
> 

what happens when EQTR fails, mabye you have this comments in the patch.

Kind regards,
Bean



  parent reply	other threads:[~2026-03-05 15:28 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 13:53 Can Guo
2026-03-04 13:53 ` [PATCH v2 01/11] scsi: ufs: core: Introduce a new ufshcd vops negotiate_pwr_mode() Can Guo
2026-03-05 12:53   ` Krzysztof Kozlowski
2026-03-06 12:25     ` Can Guo
2026-03-05 21:03   ` Bean Huo
2026-03-06 12:41     ` Can Guo
2026-03-04 13:53 ` [PATCH v2 02/11] scsi: ufs: core: Pass force_pmc to ufshcd_config_pwr_mode() as a parameter Can Guo
2026-03-05 13:54   ` Bart Van Assche
2026-03-04 13:53 ` [PATCH v2 03/11] scsi: ufs: core: Add UFS_HS_G6 and UFS_HS_GEAR_MAX to enum ufs_hs_gear_tag Can Guo
2026-03-05 13:53   ` Bart Van Assche
2026-03-04 13:53 ` [PATCH v2 04/11] scsi: ufs: core: Add support for TX Equalization Can Guo
2026-03-04 20:46   ` kernel test robot
2026-03-04 23:18   ` kernel test robot
2026-03-05 21:50   ` Bean Huo
2026-03-06 12:59     ` Can Guo
2026-03-04 13:53 ` [PATCH v2 05/11] scsi: ufs: core: Add debugfs entries for TX Equalization params Can Guo
2026-03-05 14:00   ` Bart Van Assche
2026-03-04 13:53 ` [PATCH v2 06/11] scsi: ufs: core: Add support to retrain TX Equalization via debugfs Can Guo
2026-03-05 14:11   ` Bart Van Assche
2026-03-07 13:02     ` Can Guo
2026-03-05 21:25   ` Bean Huo
2026-03-06 13:26     ` Can Guo
2026-03-04 13:53 ` [PATCH v2 07/11] scsi: ufs: ufs-qcom: Fixup PAM-4 TX L0_L1_L2_L3 adaptation pattern length Can Guo
2026-03-04 15:10   ` Manivannan Sadhasivam
2026-03-06 11:14     ` Can Guo
2026-03-04 13:53 ` [PATCH v2 08/11] scsi: ufs: ufs-qcom: Implement vops tx_eqtr_notify() Can Guo
2026-03-04 15:20   ` Manivannan Sadhasivam
2026-03-06 13:41     ` Can Guo
2026-03-05 21:17   ` Bean Huo
2026-03-06 13:33     ` Can Guo
2026-03-04 13:53 ` [PATCH v2 09/11] scsi: ufs: ufs-qcom: Implement vops get_rx_fom() Can Guo
2026-03-04 15:39   ` Manivannan Sadhasivam
2026-03-06 14:04     ` Can Guo
2026-03-04 13:53 ` [PATCH v2 10/11] scsi: ufs: ufs-qcom: Implement vops apply_tx_eqtr_settings() Can Guo
2026-03-04 15:41   ` Manivannan Sadhasivam
2026-03-06 14:05     ` Can Guo
2026-03-04 13:53 ` [PATCH v2 11/11] scsi: ufs: ufs-qcom: Enable TX Equalization Can Guo
2026-03-05 15:04 ` Bean Huo [this message]
2026-03-06 14:14   ` [PATCH v2 00/11] scsi: ufs: Add TX Equalization support for UFS 5.0 Can Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e116e78ad9590f5845aaaf7d4e26833a7a0194d0.camel@iokpp.de \
    --to=beanhuo@iokpp.de \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=can.guo@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®