From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012008.outbound.protection.outlook.com [52.101.53.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14654301711 for ; Fri, 14 Nov 2025 09:14:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.8 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763111652; cv=fail; b=Zn+lmRB+5p34VtVxXx4rW2JFVYMc3ARO4jn+L5VAIxausoBENs8zu8lTDe/uwDRroA6S7is/St9LvNFmQUWxuqg5ec4cFcq80i7UMfXwkF+IKr8u+QiEcGjT4mJbJRXB2TIGAevhNmglVMZYI19tCa+MX0oWquXbiaLYdjZkags= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763111652; c=relaxed/simple; bh=atEQAljYX5gwKAveXlagqvlqhIJTUW45FI0n7+QXv6M=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=WosC0hp4pHwNDA7DcgSmm4vTayZVNzMwf+xW0VuvucoS5DYkRnU/kUgWDAXN3I7x7XFejyUg5gqiTiwTDLao0xADcWyo10Am+R+5suJLhKRgMb3Asn7++Rb7HAgfxzrI+XJKupC+1g+pDvmIunOH0k6ouqmMAR2p5H5sX9FShCM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=MGaSKRL3; arc=fail smtp.client-ip=52.101.53.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="MGaSKRL3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AcvVH3+ZMe5axg3iweV+hWoE/Muzbp+tMhqy1wpiOcARZQu/ygkyvrn4yiC9+JyIyV3N63DDqor9YrX14w0OdjPnS10JaKuUlXEzh82MDaMgS6SRPZSQcTZoNi2x25tv5X76qP+MLRyqYBdaD7WtELfMxSRGvMTsx+IiZ08YtHhoHZgAcqV8jyItgJDEIRfaZESTOwV/CQjarfPNaQthvmPMy4/jTLVog7yJIzPM3zLxUX3Vi3uOXl0yEps77V6mW972TYtHstXT4tIdEQkYIkgCP0GXGK6hJpUApjq34T4Sb1dCRoLxbfBw63bsAhpwb9F77kAR6c4PB5ciKi2RdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W/XA5wBx+okj4sWDPHbV1fPTlTRajTYCZeswIOgSVzE=; b=Zwe0zeRrQeDjK2MWlv0xfNNocuRrrkwIoOgaGHTRMKHB5/zSzI9CIYiSHXw8/KnqOVt0ufiMxvVDgmHyh7Y9MnUgcBz1tIoc+7ZjEafJxcQT8MtyiDqVHZr99SpwY11JeAeMxUaP4YbUd5LQi39OReGXdmbKLQR7h0nuFDdieM3cROOiULgit4oe4Xj+SnP/Ee55hiSrjEXF+oqVnDcPVfCbeM+2UTbcyBSRsuFxJcwFvndi9X5C97tYKLIojJ3IWK3wbKaTx2rBBOU0g4cmE/kD8NkJdpNhPbKVWOH5Wb7k6H1QxkNKXgNdCndXe76diYq3NAXCkZPT2MWpQsYvOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W/XA5wBx+okj4sWDPHbV1fPTlTRajTYCZeswIOgSVzE=; b=MGaSKRL3Fyk7njYZos+w57FLT1ZILTT+w26LT78L1DvVkkjiu5YcFIM+/EE5fdOQeaGRjeujuh7ANixbSSABpZhipWgFDHVbJ+KX4DONS+sEleGZrwvjdkEVwXbda4Ry7RdgAMPB2Hocd5io79Jx1M0Bv+yzh7JtQS8+vgH5plHSPJspkjWUfAnQ5Te0fXTKTmw+h90PUuvWl87LTdkUHZUd/4lANQUbAGDzRZDWlFS9H24UR24Gj4YLrE2a9QA36Y0m5Mqg6T2UEe4F8mFS/Otf5LuKXn0HjdaEKNxglIj/DMqjhipP8VhZo/LZLjZUnu6wrytvzgRCsVHKoK658g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from PH8PR12MB7277.namprd12.prod.outlook.com (2603:10b6:510:223::13) by CY8PR12MB8265.namprd12.prod.outlook.com (2603:10b6:930:72::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.17; Fri, 14 Nov 2025 09:14:05 +0000 Received: from PH8PR12MB7277.namprd12.prod.outlook.com ([fe80::3a4:70ea:ff05:1251]) by PH8PR12MB7277.namprd12.prod.outlook.com ([fe80::3a4:70ea:ff05:1251%7]) with mapi id 15.20.9320.013; Fri, 14 Nov 2025 09:14:05 +0000 Message-ID: Date: Fri, 14 Nov 2025 20:13:58 +1100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gpu/drm/nouveau: fix return type in nouveau_dmem_migrate_to_ram() To: "David Hildenbrand (Red Hat)" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org Cc: kernel test robot , Andrew Morton , Zi Yan , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Oscar Salvador , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Ralph Campbell , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Matthew Brost , Francois Dugast References: <20251114012221.2634832-1-balbirs@nvidia.com> <95e27bd3-6ce7-46a3-81d5-0fc830908b10@kernel.org> Content-Language: en-US From: Balbir Singh In-Reply-To: <95e27bd3-6ce7-46a3-81d5-0fc830908b10@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BYAPR02CA0068.namprd02.prod.outlook.com (2603:10b6:a03:54::45) To PH8PR12MB7277.namprd12.prod.outlook.com (2603:10b6:510:223::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR12MB7277:EE_|CY8PR12MB8265:EE_ X-MS-Office365-Filtering-Correlation-Id: efad51be-2b41-42ad-4ed4-08de235e28fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|1800799024|376014|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V01zOTVhWHQrdUJNTmd1QmJjWW05TFBPZTNFK0NqWDJ6cmsycEJSaWw2b2Jz?= =?utf-8?B?Vkp6UUFEWkNkODBzLzc0YzNWbGoyWm5tVkk3UVBLQUQ4ak1XNEhQM0dQenRQ?= =?utf-8?B?K2ZtdlVWaXRBN2FyWDJ6RnMwb1M0SE04K2R4b2xTV2ZrSnM3T0N1Y04rOGNz?= =?utf-8?B?Mk9tR1JyVk9oZzJWL3dmUzc1SG5NTDcwVTk0SnlNVXlrbzFPcEhLVjkvWHV2?= =?utf-8?B?MHZBcU00ZXkvd2R6SXk1cHFaVU96V2VLUGRxSURzMThXTmNudWl3NVBzR1o0?= =?utf-8?B?YUliODExbjArVUpxcGVseWI2SEZ6eGVBMFU0cGRZbjlxdCtxalpITnprZ3JE?= =?utf-8?B?d1hzc24vbTZ0QXoySWV3WmtTVVNIUWhrK2pSUDNoTGdFeHJ0UkZucWg5QW5U?= =?utf-8?B?eER5a3dDM05zaFFUZmVtdmRvZlFXQzl5WUcxK09Qb2FOZjF2T0t6ZlR5cUNS?= =?utf-8?B?TWZabTBEU2U1bkZJK1ByQWJkRWZEYkx0Qm9tNThSUEJOd0V5UVJLUU5TQjlI?= =?utf-8?B?bXMrN3JMd2JPQ3R2eFZ3WXJHMjYrZEZLTkVoajlWQnAzWUtDUkd4bGlpRFkv?= =?utf-8?B?amIxTllieDY4UmtOUFZDNGdSelIwWjFHSXBISDRDWnZrQVVKcG1lc0RKTkYx?= =?utf-8?B?Vjl3NEY4bnJaNUxhakQ4N1A2Z1VPRVc2Tks5UG1zUzBTODlndEVsblo4ZTJG?= =?utf-8?B?K1RFYUdPNEd4cWV1dW9kaXlGWFlQd2NuV3M2Z3ZpaGtzYUl5WXgxdWt0V0Vw?= =?utf-8?B?enRDZ295eUk2MjQvbXNGb3dNdVhsSFpKbk5veFRBemQzNlFCcTkwUGZiUzF0?= =?utf-8?B?TTBpZkZVV1FyS2hmTU5mTFVHQmM4bklQcXZNZnlmL0RWb2FNYlVjYkx6TC9a?= =?utf-8?B?NndMMC9WK1lRQUp5UUp1dTFsS3dZWXZTWnlhU2JnR0NJbXhzbzJYYlFhTkpq?= =?utf-8?B?aGFCbHgzeUxOdWo0NUtOQXlZNGUyZVJmWTRCSmR6eGRvWFJzWlhZSGl5VWlu?= =?utf-8?B?U3RFSXgzSDFNaUR5T1ZPN0tQVHVtQ2tkY01vdnByWFI4WmdFK25hRkdrUmFV?= =?utf-8?B?RTFsOTBsekpNNU4xa0g1YTEyTjhOOXpjODdzNDFTaGU0SXd1OXRkWnJLcG1F?= =?utf-8?B?WWVDa1RZdDhqc0JPZ3hNQjY5N3pGbVN5TzJiYWtPYnpXd3hHTjdxTTVrS1h3?= =?utf-8?B?Y1o2R01NUkZDdFc1SThRa3BMUytRZHBRWXhWSVFHNnZNUmFqK1JnQ0g5STVi?= =?utf-8?B?U29tMFBSY3I4SWtxcVNRcFZwVGNQYnQ3L2wrc1JvWU1TcTFsNFo0NElmYlIy?= =?utf-8?B?QmJiSnRmUGpTQzJWZGtHUk1mSzJmY09uZDhITFhOM0hEOTFYYklUcmhDT2JR?= =?utf-8?B?K0E5Q2ZqRXlPSE42dzVvZld6UFNySWl3VnhnNHczMGtZWEJqQzZML0FXb1lD?= =?utf-8?B?c21QWmkwdDVIeHBuNlJpV0tSbXo4aGNhT1RTc0FtZFNGSUI0bGIyMnBMeG5w?= =?utf-8?B?ZUt0dzIrVERodVNaS3o2aW05SG92SXdxK0hlMHZMOHhwNGdCSkVaTGNXc0JQ?= =?utf-8?B?N0JUd21IMUVPT1BWQmEwU0hOcmdpU09TaEJDMFRjSk1reDg0L1Z4NmNqb2tr?= =?utf-8?B?WHFaaktjMHZBRkdWM2dSUGxieEhxRDBwdEhiVXdBckxPSWpHYWlmNS8yNDQ2?= =?utf-8?B?clhTSUZMampoK1VQeHFCWUlobnBUaG56U2o4TG4vc1IzZ0hJOE0zZUNoSUdF?= =?utf-8?B?VUNJNXRtWUFQTFVOcG9xRWtRV3ozaUNRaEIyZ2hQcUNjZGpkbWVRNlVVK0dQ?= =?utf-8?B?R0VpcE8rWkYrV0JWTnJQaGVwd3FIQm1sdThEalFiM2g3Tnp0MTg4WGhsQ2dJ?= =?utf-8?B?dU4waXJydTJaeVBiZXNzV1IxWmdMSzFuVkl5ZHNqTGl5N21SSENQaGwxVlBy?= =?utf-8?Q?dMGdX1bGhh+gC3BJIr2+Cumcs8+dFOZv?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR12MB7277.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(1800799024)(376014)(10070799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bi95bkdtM0pCTUs3SFJiVVk0VDNma3lYTURTeCtuOEo5U3pyZll1c25DUmVE?= =?utf-8?B?K3dGY0tkc2FzbytOWVNmeWorbS81S2lnSWJTZ3AwMkRZRWszRE0xbVZLZGdF?= =?utf-8?B?bFBHaFhYWHlQaEFKRjR5UWVPLzcyWUEvc1lIYTBjdzFkNjduWGppK2Z3eis2?= =?utf-8?B?YTh3MXFyZVhBdE15elNUSktkbm4yWGRSQk9RWEJNRGY4MWUvUElxT0t0ZzBY?= =?utf-8?B?QVhGT0xVVS8xWEtrckZKa3lSY2dDSUlSUkJUMHgwNGFnMWt3TnpkUVp3MDlw?= =?utf-8?B?K0hkQlZISDg4aERmUU10dDlFdy9rck1BYVJpVmllYloxSTFrS2VvME1CUXFI?= =?utf-8?B?V3lIN0ZIemdlUG9EbDgyRTJlQTZTZWJHZkpPRXYrbVV5SUU1di9UMHdTYnV4?= =?utf-8?B?TTVPcDJqQ1hZTE83Nlg1NTBqMFo5K29CMHNCcWtydW02U0NmREloNk1LT3Uv?= =?utf-8?B?S0Q2aVFkT0xxT2tsQXBvOTlYOGhtWGIxMEV3eGs4a0hqVDhTWFJwTXdDalVr?= =?utf-8?B?aXJSd1lmdGNXUVQxVlRKcERTTFhJVXpIRmlPczVNTUhVSkJ2RmloQ0VmYzI3?= =?utf-8?B?NnJIMWdLWkxMUFpJOTkyTmxCSjc4ckpQaXVoQUplZnB3N2tiSDg3Q1BMdm01?= =?utf-8?B?cFZUQStQRlJhNEROTmhCekRzOExVMThTQzJJVzdaenhjbGkxN3NvUXp6Vjg2?= =?utf-8?B?TFJmUHVEc1o5VGk0UmhxNzgrQ0toOFg5V214NDJ1RjRmbytxakd5a3E1blRE?= =?utf-8?B?dzlDQWZncGNtWUFjNWRwbU52bXpMV3d0NlVjOGlQc1RTbzEvTStUczczTm5Z?= =?utf-8?B?L2VpM2xQc0NhQ1lnU01TanRlMU1mbFhsR1RlQTdBdkxoZTZYeHM2cnE4eU1s?= =?utf-8?B?RWdTOXNOTFRZRWVQcTZYVTNPOVJiR29ML09EVURzNVU4ZHhkWlRuak1jWWpD?= =?utf-8?B?dXFsTnluV3A3Y1h0eW5aTVhOMytrVm5VQ0JPMUR5WVpyeUhleVlkbTFRZzVS?= =?utf-8?B?STQxRmVPeHhPeG5lS3ZRSVowNjcrdWpYbEpNOVI5TFRjUXM3bHZ0TmRoazlo?= =?utf-8?B?SWVwRDQ5Y0k4amJoNDV5VXZFaStCbXRUT2lnZVlKc3grSVpWRGgvZmRRUDhM?= =?utf-8?B?L0FVcmVoTlN5N3pTL0dDeHFiWlpyZHBzSEJXUWFwU1RvSWZOSVNkQ1Z6TEpq?= =?utf-8?B?NnhRc2JQK0NPZUJQUlAzM0dKWmhxei8rWVNVUW9FN09GL2pyN3hIWjdva0FC?= =?utf-8?B?RkVNc2RLd1B4aGpUTUgyKzMzUlVTQ3JNc2dhWlZtcnBLU1JMcXRVRmszelV2?= =?utf-8?B?d0ZkSzRVTGZXU1FQZVpzRE1nQ014UnY5TkhCaC9lNVJ5Z2NEVVdaYmhhYzIy?= =?utf-8?B?cmtaSEVDOUlVS2F3UGdJNE40MWFFUUN1SkpPbW40RXh5YnQzbVJwbm1oNG96?= =?utf-8?B?Q0x0K1dDQTB0SXlWazgzVlFGUXBWdk1rUEhabnJrQ3R6RHZrRmFmeGREalBT?= =?utf-8?B?dVFjMDA3Q2xFaG1UUUlrWEFxVFlDQWJ4alBmU3ZEN1Nnb1J5UXV2SitITDNl?= =?utf-8?B?eFg5eXc0UHlYdFNYSUJNRFdPQ2RVNDh0UFdZWHIwMmdiRGI4KzRTS25GNThZ?= =?utf-8?B?TGZpQjBsYW9YT0crU0V3amtqRUNPdXdGc2RkK1V3UUFsRFdYdU5HQnFHTUVl?= =?utf-8?B?SUZCTzQ5VU5NNyszREhQZCtkNzFPOXNma1ZUUmxZQjVqV25NdmtMWlZqNXRZ?= =?utf-8?B?a28rMnA3MFlzSjJ5OTdsSmZvMnRSQjNjKzk5TzBJdld2UjFSajRXSUN0NVp6?= =?utf-8?B?MXgrV1JRNHB1MERVYzNVK3BKcWhiQ2wxTGQxRllJem5Zc1hqaGRBZWpQbjVw?= =?utf-8?B?RnRtY0d6NGxLYkdsMjVhekQ3cTdURm1RRWQ0WDJqNFMwNkoxUVhFWDU1TUpM?= =?utf-8?B?WVlCdmx5NCtYNlROTWRIVXo2bUlVTFZCWElsT2dPNXhGNm1BRlBoN3JETjBP?= =?utf-8?B?amg0UEVuK1padzkvWTc5YzVTQVAxd1FiRzNPdG1rbUgwcloxSGc2cjg0bERE?= =?utf-8?B?bUF5ZzhVeVc3RHdwZkYyb214VnNXa3VhT0VkQzloK2lLZTZnOWFpYXhuNXA5?= =?utf-8?B?TzZYNTBDanNOaDJ6UnB6YU5jaVliRzF3RzlaTHJGenNDRVE4ZXlMVmFxSFA5?= =?utf-8?Q?8sXsVo9LgQWqC3GgUbv96f9kEQ/e6MpH8zLo8phyHlgT?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: efad51be-2b41-42ad-4ed4-08de235e28fb X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB7277.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2025 09:14:05.5705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dR1aYvjV8KNUr+qKnAgKilEzWktP8fOgGErCG3sc8Yzo8JgMkjbzCxpV4Tl8jesTtIbyzPShk8y+qoJPZfa0qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8265 On 11/14/25 19:33, David Hildenbrand (Red Hat) wrote: > On 14.11.25 02:22, Balbir Singh wrote: >> ret of type vm_fault_t is reused to capture the return value of >> nouveau_dmem_copy_folio(), which returns an int. Use a new variable >> err to fix the issue. The issue is not new, prior to this the function >> called was called nouveau_dmem_copy_one() and ret was used to capture >> it's value. >> >> The bug does not cause a real issue at runtime, the value is used >> as a boolean to check if nouveau_dmem_copy_folio() succeeded or failed. >> The different types should not impact the execution of the code at >> runtime. >> > > Also, as commented previously, the prefix in the subject does not match existing norms. Take a look at > >     git log --oneline drivers/gpu/drm/nouveau/nouveau_dmem.c > > and note how it's commonly something along the lines of "drm/nouveau" or better "drm/nouveau/dmem". > > The only patch that uses "gpu/drm/nouveau" is from you recently. In fact, there is no other patch in the codebase that uses that prefix. > I'll fix the subject prefix Thanks for the review, Balbir