From: Jeuk Kim <jeuk20.kim@gmail.com>
To: Peter Wang <peter.wang@mediatek.com>, bvanassche@acm.org
Cc: James.Bottomley@HansenPartnership.com, alim.akhtar@samsung.com,
avri.altman@sandisk.com, beanhuo@micron.com,
can.guo@oss.qualcomm.com, cw9316.lee@samsung.com,
hyenc.jeong@samsung.com, j-young.choi@samsung.com,
jeuk20.kim@samsung.com, john.garry@linux.dev,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
mkp@kernel.org, ping.gao@samsung.com, rafael.j.wysocki@intel.com,
stanleyjhu@google.com, vamshigajjela@google.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2] scsi: ufs: mcq: Reap aborted CQEs before returning from abort
Date: Mon, 2 Nov 2026 09:44:56 +0900 [thread overview]
Message-ID: <e11a0f9b-e703-4f83-a5e9-cb28c85aadc2@gmail.com> (raw)
In-Reply-To: <c6c84b433923fb2c4d332dfd79875be9ebbd1681.camel@mediatek.com>
On 10/30/2026 5:00 PM, Peter Wang wrote:
>
> On Fri, 2026-10-30 at 10:13 +0900, Jeuk Kim wrote:
> > From: Jeuk Kim <jeuk20.kim@samsung.com>
> >
> > ufshcd_mcq_abort() can return before the OCS_ABORTED CQE is reaped.
>
> The Initiate Cleanup procedure polls SQ_CUS until the
> MCQ_POLL_US (500000) timeout expires. So is this issue caused by
> the hardware completing the cleanup operation only after the
> timeout had already expired?
>
Hi Peter,
No, this issue can occur even when SQ cleanup completes within the timeout.
SQRTSy.CUS indicates hardware cleanup completion, but it does not
guarantee that the driver has finished processing the OCS_ABORTED CQE.
Before this patch, ufshcd_mcq_abort() could return SUCCESS before CQE
processing completed, allowing the SCSI core to retry or finish the
command.
Thanks,
Jeuk
prev parent reply other threads:[~2026-11-02 0:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 1:13 Jeuk Kim
2026-10-30 8:00 ` Peter Wang
2026-11-02 0:44 ` Jeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e11a0f9b-e703-4f83-a5e9-cb28c85aadc2@gmail.com \
--to=jeuk20.kim@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@sandisk.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=can.guo@oss.qualcomm.com \
--cc=cw9316.lee@samsung.com \
--cc=hyenc.jeong@samsung.com \
--cc=j-young.choi@samsung.com \
--cc=jeuk20.kim@samsung.com \
--cc=john.garry@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=peter.wang@mediatek.com \
--cc=ping.gao@samsung.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=stanleyjhu@google.com \
--cc=vamshigajjela@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®