From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752281AbdI2Pyu (ORCPT ); Fri, 29 Sep 2017 11:54:50 -0400 Received: from mail-by2nam03on0086.outbound.protection.outlook.com ([104.47.42.86]:44496 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751975AbdI2Pys (ORCPT ); Fri, 29 Sep 2017 11:54:48 -0400 Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Tom Lendacky , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski Subject: Re: [Part1 PATCH v5 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support To: Borislav Petkov References: <20170927151329.70011-1-brijesh.singh@amd.com> <20170927151329.70011-3-brijesh.singh@amd.com> <20170928090242.ber7gynwaldinafa@pd.tnic> <20170928192347.gkpmpetmmp7523wu@pd.tnic> <0ed8db87-3f18-fd69-19e3-7f23a43bb8d2@amd.com> <20170929144146.ctidwarilxntpu3i@pd.tnic> From: Brijesh Singh Message-ID: Date: Fri, 29 Sep 2017 10:54:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170929144146.ctidwarilxntpu3i@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR13CA0008.namprd13.prod.outlook.com (10.169.208.18) To BY2PR12MB0148.namprd12.prod.outlook.com (10.162.82.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 49ba1660-356b-4052-c29c-08d507526806 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:BY2PR12MB0148; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;3:exo8a1kHU3XxGTSv+djfwLE5moMhXE1mfm4Fk2vjceUbAxbFawbp26G3OE5t+Br5HNPMdayoO7t4frdIv+6Y6bUwr20NsMfeznYs3mNX1fNavNvKDMTYx0O8PuoKDoMFv33pJ95fw7C0TzNAqCm8JTc+wSuOCqSfgZJ68K0YDRj+F75O3cBcUXrtgFnpH9mTUMaDVpGuKIx+Odcu5em+TPB+7/RndAKvOhklLvCStFHcfcZhblRc27bM9HXEIYhk;25:3ClpWdK+LYwIXiNTqrc6FrCrE/4pK4pppxfPkAXPDiy7y1r60zwG0N3ZggMO0tjoUarVzvgpqHqin+ESIus3pdgWLLV6BQhSyXTeZaewLJn+qfzPq5+RS8JpxRBshCpft7yY8tsKTtXFglnQ5Hk2GSeGxdA6MobDiIIEmP9cQdP+XgN7/iX9nggsiZEf2GgAM5pgXp94j7cAwHCzEdZ16gJTU+65L2MO1hWf9XnT1rh/MlEbNUC/R0VPfsa+HM+f/kLoRM0ymOuawppad26UwCMPWPFWiR8nGBbh7YQLGGtemYsZxT0AVedAb8TMysOT6R2LvjrlY0y0fd/SfizLAw==;31:RL1OIKKaJBoilDqHiDiGLpTJesWpWyKe00mkm8TMuyUMI0ZqC82BDoBxtUyf6HDA8OWngoCc+R2EOzJGnmIxg0SA9R4Q3L/y7Mlsl7zCrUJ6NXMqZg4Yvb3e752QobnfYqspTxt35i1nTav29Giq+PIOYDTaYqq5gosIuuTMnUlxywy++jsQJ5uXcWmLX+j55GzqS5u18/97SY4FCmm/PMir9Hx1s4Spe03Ya/661a4= X-MS-TrafficTypeDiagnostic: BY2PR12MB0148: X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;20:0s0fRSX0SnY3Q6WEw06s7ZZLLoCCDFC3k61LX+tl7undMlgNo942pdWM7FCanbJvkBjBpgS0o4wr860uGueou1OJiCNwAazkYce2KHo1EK1+3G0z2yPMW1Yet31d4nT9f7+4favKnSYgIjERCIpLwtysY+mRkwMN4+YWd+Iyx87ZQw2Ao5PhcfK187r+JVrZG1L+/1peRoY/tZTL0TvgyUxuDOn7w0+SGj5th+qyj54KaRUgRmziZMghlZe9aiTnidVzMEy1b6j8oeQTEWVzoURchB/Rr0ItulXCvt+gLEwU0lysZX/5C8FVEeuzyW3RHVKXUYuLaVvJsL1xkF5KHpP8269EXnJhU4i+LTgmABeX7MfvpHlCIbtTaQee0fT5d+iTkKQkEq0mPdbVx5T1bT+CGNmF3u6D9nHfLDWetVx1FNdIMHripmc4hiBs0FthNp1NiFJ+AVCehHT5+cqzu6OCn8qi6OW6HZCG3KRCyFiyLcGqRWkoDfPH9IkCMpYH;4:VPyUpVQBB19wfBtU5XL0cZhbdohwyStjvqTuTDnypckm75p6zbxJ8cb7QTBZRUYj9Ng+EDSY+YYcVWgQmyzQnP0uhKE8nTChJ6Q660VNv4FwifameQ/yxPODm/A9cIrgXzN2k71WV1K3tiWm1O3BzTA0JB/tt8uvlKUHbSI5v/MyLq0RzVgNYzJoxmDhLOOUMQxBeskN4gbHnzEmYPLA86oiGmsx8xPy43Rp/p50QGT/tLr+aEp/BNeiI/2BiLx5 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR12MB0148;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR12MB0148; X-Forefront-PRVS: 0445A82F82 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(346002)(376002)(39860400002)(199003)(189002)(377454003)(24454002)(47776003)(77096006)(65826007)(6486002)(6246003)(105586002)(7736002)(106356001)(5660300001)(90366009)(65806001)(66066001)(65956001)(305945005)(81156014)(53936002)(54906003)(58126008)(16526017)(53546010)(36756003)(50466002)(93886005)(33646002)(6916009)(2950100002)(97736004)(64126003)(31686004)(16576012)(316002)(229853002)(8936002)(81166006)(8676002)(83506001)(6666003)(2906002)(50986999)(31696002)(230700001)(23676002)(68736007)(25786009)(54356999)(3846002)(86362001)(478600001)(101416001)(189998001)(6116002)(76176999)(4326008);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0148;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjEyTUIwMTQ4OzIzOnBrMk42cWIrVjdTa3RJejErQ1AxK0F6VThz?= =?utf-8?B?emdVNXg4eHdmcW1PT05hb09wODJxSUdzTkVVeUZPdklHNnMvMUEvNVROKzB3?= =?utf-8?B?b0JuK1ZnWGtuZVRPWFhRL3VWL21UNzRpYlpTUk4vblhLdVNUZzh6Yjh1eXlU?= =?utf-8?B?RTBPQXFXNCtTWVFIdEN2NUYxeWZQZW5UcmxNWFJVWExzM2VoN2lnUjdFWFA4?= =?utf-8?B?Z0tMNnE0K3I5a2Y0Nk0zaVR0V2J0WVZKbE0xWDRQT2hNTGRoMFNCRlVMbTZV?= =?utf-8?B?YXlSQkFuYU4vcDZheFg0bCtkendDaVkvSzdrMGFoOG5xdU54TFVMS0Flb1ps?= =?utf-8?B?NjEzYmdKcnE4Wll4a2xTeHZsSHVWU2d2ejFqK1VZTkVHT2I1MldNY1VOQ2NI?= =?utf-8?B?SmI5Wm1JWW5vaWhjKy9jSHA2QUZLYlVtQ3BwemtqdThTOWJrMHN1c0xocmFJ?= =?utf-8?B?Y0RLZGZkcHRHd1E1dVY0YTF2akI5ZWJTMmVMSk9DTTM3akpuTXl0N21BZnNi?= =?utf-8?B?UVpTWFVTOGxXMmFiMGJOb2U1Yk9TenJtWlF6N2dLaDhCQ21NVmE4UmQ3Mm1o?= =?utf-8?B?SW90bmRvRTdwZ1lrK1JyY1JmYzlUczlFKzJVbXhQdzFqbXZ5Q0VEMmdEd2Zw?= =?utf-8?B?Zmw0MVZQZlR5Zk5HZnoyZEwrZ2gzRFVQb1hhcW5OdWZQcjIxS2krekc4QVhW?= =?utf-8?B?aks4aXVxSnEzQVB1YlhyYjQ1U2NmNk9lYXJvNnpPZTJRSFUrOGZFN2l3RmZa?= =?utf-8?B?YmxxUUtZbnI1Vlp4ZE5WbHVHdWtVYVBOWjRhNk9EMzdMT0tuL3o4WU90cXpp?= =?utf-8?B?S0RFWFgwR0krZTNhSFJOMHZld2wzZElZSDk5S1c5Undyeit6UmFHSnRxd3R3?= =?utf-8?B?WkpSaFdtYThCT1hySmRqR2FadFlJTWl5OVhrK0FOckp2djA1VGViaDVBM2ho?= =?utf-8?B?MUZsa3RKczNDUEMxNWxMUzFCdVpYUWViamJQeXNMTFJ5dUtMRVNaZElCZ1dq?= =?utf-8?B?Q0F5MjczVHplbU5lNStibklVVWNRdVowV0tQbUQ5bWxvQXVySFNSMGRMWWhE?= =?utf-8?B?RThJOExaUjRvaVhydEFQSklabXNLNVRiWlNEeEJGQ1RueUhKeC9MekhxVlF3?= =?utf-8?B?RE5DRWRKbWtodjQ1UGNmTGVKeHFJWWFRMEV0M1F0SFQ0NDFBTkdqQWVYTEJO?= =?utf-8?B?bXZKUHBBdk4reFRZSW1JNzNpL1ppajFGRDNlRGpvZVVVMW5oUDI1enRjQUs4?= =?utf-8?B?elFNY005WnpQK2REUWpzNGJvS2gzNUdCK2FqL3FZRDV3SjhlclpjS1VWeVNr?= =?utf-8?B?dVNJZXA3dDVPNHk0anVRb1YycU1xVVFVN1c3MjdqYlRNcmZmZVk3RnNBTy8r?= =?utf-8?B?ZkF5NGYxU0NNS1llZ0c4MXJFNjhXKzdPUWRVVzB3ZXprSXVmVjRHakxrbCtk?= =?utf-8?B?TitqOE1JWnM0RnV2VmZBSzQ1cFFIenlTZHRuOXJQcDRCaTdnc0xjSXRVYXJP?= =?utf-8?B?d0FNbmk5L0cyRmVQNmcwWXVCOTFBVUR1Qks4ODJqVVpxUnl4VW5MM2hTbFp4?= =?utf-8?B?RVpZSExTNEREUzAwc25TZ0N5MmgrbVZLamh1bTg3SlJHNFZGeGNnY3YwOXU4?= =?utf-8?B?Vi83UXVHN3c1eHVaRHp1L1l1LzZVR3pRa0xTUzNLcnFWcVM1OVJraW43Zmtl?= =?utf-8?B?dnpYeW01dE9LT2lPbTE0THB2eHVKQnFvaDB1UGFsNWZETy9hd0I2czNzd3Nt?= =?utf-8?B?QldPeXlzRG5QQXoxOURZdTlXbFYyZHY5RnZEV2d4UEMzQng1bEd5M2Ira1Y0?= =?utf-8?B?Nk1Yb0tGanI4ZWVzVGdCcTRMRHZSUUM5bmx3WDBzQUFhMXo2ZzV4RHZsZEZz?= =?utf-8?B?d1JqdmxLNDRyRWhyV3k2dkxrWHQ0b1UwU2pQemZ3czlYYSsyQUhueGtib3Fo?= =?utf-8?B?VVprQkI0SFRnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;6:K6X7OLAjcbsJhXMyZeU8hE/hwuHkDW8TMkf5o0bOBW0xrbTcqkt03nxuqi8f3G5dhSKzPdlKXpkR5jd+dssNwjA8Y4zHQdtD0ImkWSzZ9t5mPxyPihhGRH1V5KLahUW1ccc9NExPNZyvKmPWg/grbmg1RGBdXtir+jRvWR75jkiwp7OnKCPs/j0kumBBSQZ5MjpUK1+jP7/1WaiJ/ezghWrsBRtQz/WML4f8MmmpLxFAehMZ7TYHdxUm3P/LR/OQ4UrJs9zPyR2l+8zGL1xgPC4I0lnya5zG29Ipob+9jf5XJ003mSFxdM25jI9t1J90oP30u/9vXf75Zp7wuf03eg==;5:C8aKUVepnj/i1RnXMbTeF7wpQDfNItw3vziL8a2nbtck/NMcnZJxRPVRhQ5U2x6e878VSNY+rKyJKqgFMPxjNPrY4fenscKOEdPeA7DBn2+POtv0pvpCogZN9CGnztDLcu577WcxZ4GeXtEILZ81Ng==;24:6IH1owSh2JpDgX1ny7urZkMAhB0VfUfZaYqzBk4O7yfYHLD7fHuiPuF2GzCehTZ+3boZBYIRolCbcxi5TLVQJVk9AP0teUo/SmWIXBNhMF0=;7:Xzr4/FooUpgafPEmladukeEpmorxGas/ny7p4kmV4MZnTbq2NKlydOQam/gDMBGfs2w6vyzFO4zrWxM60pwE7OY2WGuQlywQzgJ7l1BmOzF7HoMQEGaF2ZegAgAmF4kTbM1V+/K9s5SxP2/t9A1zmlzzgo5ivr6semDy+NNQKx7vu7zzTmhDW3zOZ7c9OcbWlfVgPwnxreXi6HBjHG/jFAntoEKHcnQDmH583rdYAEo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;20:CnpVX3IZlKdvu1p+8e+pvEc0uL50baPlEIMx9XmOxVdMwKHLNcOE1Uv/W1No9vgIZk8N+mskGaRqQokEQAMzkV18X1m6hqyxE8roSa60PQKfy0wikoT5emJZtOOsb0wvAWkgG/Umj3nmeYzmWhbjQ+4GGFte/oJfXGRBfQs9fuD0igcq+1iQGJSDpqR68vkEBorynk2i3BWBvjXmFvGHgJ8Qq+zM0AHmBoIp8apv4w/RPt6PiaWmZnAhbBp+XwEm X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2017 15:54:44.7404 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0148 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/29/2017 09:41 AM, Borislav Petkov wrote: > On Fri, Sep 29, 2017 at 07:28:47AM -0500, Brijesh Singh wrote: >> if we are adding a chicken bits then I think we should do it for both >> "smeonly" and "sevonly". We can boot host OS with SME disabled and SEV >> enabled, and still be able to create the SEV guest from the hypervisor. > > Sure, but is that a real use case? I mean, who would want to run > encrypted guests on an unencrypted hypervisor? > In production, you do not want to run encrypted guest on an unencrypted hypervisor -- I was thinking about the debug environment. We can start with mem_encrypt=sme and if we see the need for 'sev' arg then we can extend it later. I am working on the patch and will send for the review. thanks -Brijesh