From: Mark Brown <broonie@kernel.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Vladimir Zapolskiy <vz@mleia.com>,
Zeng Heng <zengheng4@huawei.com>
Subject: Re: [PATCH 2/2] Revert "regulator: core: fix kobject release warning and memory leak in regulator_register()"
Date: Mon, 18 Sep 2023 13:05:23 +0100 [thread overview]
Message-ID: <e11bcb8f-be81-4a71-a7eb-30a2da981602@sirena.org.uk> (raw)
In-Reply-To: <d7361cf5c6bfc78f519149554eadad1d5ef5e76f.1694985959.git.mirq-linux@rere.qmqm.pl>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On Sun, Sep 17, 2023 at 11:35:14PM +0200, Michał Mirosław wrote:
> This reverts commit 5f4b204b6b8153923d5be8002c5f7082985d153f.
>
> Since rdev->dev now has a release() callback, the proper way of freeing
> the initialized device can be restored.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-09-18 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 21:35 [PATCH 0/2] regulator/core: A quick fix for struct device handling Michał Mirosław
2023-09-17 21:35 ` [PATCH 2/2] Revert "regulator: core: fix kobject release warning and memory leak in regulator_register()" Michał Mirosław
2023-09-18 12:05 ` Mark Brown [this message]
2023-09-17 21:35 ` [PATCH 1/2] regulator/core: regulator_register: set device->class earlier Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e11bcb8f-be81-4a71-a7eb-30a2da981602@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=vz@mleia.com \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®