From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933779AbdKBPLP (ORCPT ); Thu, 2 Nov 2017 11:11:15 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:45323 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932724AbdKBPLM (ORCPT ); Thu, 2 Nov 2017 11:11:12 -0400 X-Google-Smtp-Source: ABhQp+QCCNyAY9+jVyh1aG9XdamFP1irBMa7xAikgL11PxeT/lzESfU4Tl79pWhPltlRI00Wbjfq2g== Subject: Re: [PATCH] block: fix CDROM dependency on BLK_DEV To: Bart Van Assche , "arnd@arndb.de" Cc: "jejb@linux.vnet.ibm.com" , "davem@davemloft.net" , "linux-kernel@vger.kernel.org" , "hare@suse.com" , "martin.petersen@oracle.com" , "linux-ide@vger.kernel.org" , "linux-scsi@vger.kernel.org" References: <20171102111952.4021454-1-arnd@arndb.de> <212c24f4-7329-f1f5-93c8-090727ed7226@kernel.dk> <1509634878.2484.5.camel@wdc.com> From: Jens Axboe Message-ID: Date: Thu, 2 Nov 2017 09:11:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509634878.2484.5.camel@wdc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2017 09:01 AM, Bart Van Assche wrote: > On Thu, 2017-11-02 at 08:27 -0600, Jens Axboe wrote: >> On 11/02/2017 05:19 AM, Arnd Bergmann wrote: >>> After the cdrom cleanup, I get randconfig warnings for some configurations: >>> >>> warning: (BLK_DEV_IDECD && BLK_DEV_SR) selects CDROM which has unmet direct dependencies (BLK_DEV) >>> >>> This adds an explicit BLK_DEV dependency for both drivers. The other >>> drivers that select 'CDROM' already have this and don't need a change. >> >> Thanks Arnd, applied. > > Hello Jens, > > Can you wait at least 24 hours after a patch has been posted before applying it > such those who want to post review comments have a chance to do that? I generally at least do that, unless they are trivial... -- Jens Axboe