From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753094AbcFVRBq (ORCPT ); Wed, 22 Jun 2016 13:01:46 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60987 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095AbcFVRBp (ORCPT ); Wed, 22 Jun 2016 13:01:45 -0400 Subject: Re: [PATCH] ACPI: CPPC: Return error if _CPC is invalid on a CPU To: Hoan Tran , Ashwin Chaugule , "Rafael J. Wysocki" , Len Brown References: <1466201791-13351-1-git-send-email-hotran@apm.com> Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, lho@apm.com, Duc Dang From: "Prakash, Prashanth" Message-ID: Date: Wed, 22 Jun 2016 11:01:42 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466201791-13351-1-git-send-email-hotran@apm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hoan, On 6/17/2016 4:16 PM, Hoan Tran wrote: > Based on 8.4.7.1 section of ACPI 6.1 specification, if the platform > supports CPPC, the _CPC object must exist under all processor objects. > If cpc_desc_ptr pointer is invalid on any CPUs, acpi_get_psd_map() > should return error and CPPC cpufreq driver can not be registered. > > Signed-off-by: Hoan Tran This patch looks good to me. So, Reviewed-by: Prashanth Prakash Thanks, Prashanth