From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9912E377EA1 for ; Fri, 27 Mar 2026 12:47:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774615676; cv=none; b=agPWXD/yL1A/Ar7FYoMSDsNAi/5uFuOwN/D3dWF0Lc90W4XecrtVYxjNaLoUxyfThfybt3PuwQn0quc+7ixpkN2N7xjBWxXE76jVkkhUFs9uINe521k1GE//8ebrLEWllHXM4z+3ouy0UFY3HzEJErzFOyRBERHdFx7wXfE1jeU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774615676; c=relaxed/simple; bh=vA3uN2ML7GJtaLvb/dMgvC7ai+cMTjDlNlylEH6lWrY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y3eQyQ8pQOUr8WG357AILuzwYjO5OWQTDGLvB/HUHD+EWDouErJFz6KkByFZLqh/NGTmKHxcRzZ5Icoyv82QEf9AQH3lmdpgX/DiT0y7PnEZ8GdQ1KvtXBTxue2rXaX0Nen+A9jw89WY7ClOM7UBUTbWluCLy4L9HPASH+FZTw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=p83FsuCh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TjD+9plg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="p83FsuCh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TjD+9plg" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62R6w39s1860247 for ; Fri, 27 Mar 2026 12:47:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3WKEUDRkSeItXtXpqPiTHpqAYgm/9B9D7SnPy3ACdn0=; b=p83FsuCh5RKXu+ba WXmOcvqyHEoR8zESFxFo2DdKsMoIHBZPYf2WtMBKJ/jrwxkDQu47tkyxSZ2miQqC WYNmrdz+5GRO3gAtjsxud4Vb577CulPsLB5zGBk545pq4TUjGsG2zQdJCNm9vTul 7mduuZZqyxi+Ioyc3iR3YKaRt18rgdnGsDpXSMFrKevpbuB1i61InjKSLcTv4qEY F90XvaxqrszDYSXf5Eb+FHEVpkqXlhiKiu3c8IJ6e75LtjLcgciXd0hJTtMeIalK +TH6I7igcCfRiTxkYGr2lcePK+VdtSoYA4hIDbhfP8zAS+Lw1YKL87DnqjQ9EzzF sIayVA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5bxv322x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 12:47:54 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50b9074bd42so6511191cf.0 for ; Fri, 27 Mar 2026 05:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774615674; x=1775220474; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3WKEUDRkSeItXtXpqPiTHpqAYgm/9B9D7SnPy3ACdn0=; b=TjD+9plgX71qnNdHaNpJO45u0mOaPXm+FwoFkOHViUYWxXAliQ6PbAL/eNyPZQjEwV cT3Y9g/WIS+L2SiUM/5XwwzANOl0wRVhXjdoA8JLftkoWlmcKIrWVMEy7lCyihNeZW5a QzorXckmMhppYrvFUb1kguuwoHSoAGSvQvd72LAcB/NA8nfu/iys7P8kkEu53FBB47In 9IOvRuKRB5MBkIsDwAIwZ6InBm5FjYaYbV9k8r1YPJej6RoTrBUE+2JcKZFLUOEixB0d 6AU9rr1GbBIlmRJIczuBPzt2gvZytdH4nNBmjqX0DI7sdGFxwDMLop6VhTqr6fZgFDFG 2DSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774615674; x=1775220474; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3WKEUDRkSeItXtXpqPiTHpqAYgm/9B9D7SnPy3ACdn0=; b=eRtFXNoV5qYBp0rqaVALxKfu7Fj7pHaUZONjkG4DT8QbbaxtlmUdLADCBi021atgTV IZCFwc/sbc79dMwxWj1NiVCifxrf0DfEEfV968s4+c0Ad9KeFv8sSE7kwgUxzmMWA9Q3 Kxjg9yl1RcjgvOL+39c1ncd3eoMNWsnkO6NKFv7FoO7ybBFjbTLWGS7fsL5Wcwu+AFp5 E8G4EktHgjV0lgFmmgcUnJNWwNjWx2msvkAZz0j8zf9cSZeXP7JJ5u1IcBCJOZ43Tgj2 BvalxvLUtI7dWDRfxOh/wT2k5yjqt6KtwA5CGs7WZVQ77qNIz0P7MHMoV7ugfUnp3g1r H4eg== X-Forwarded-Encrypted: i=1; AJvYcCXHbDnCJgt6G1HN+dZjum23abrmvofGMF0fPlXUHMy3NsPakNf+90hbsWlM+vektivQpO7faL5VGi+pEMM=@vger.kernel.org X-Gm-Message-State: AOJu0YydnPTmS4taFSXIpBQwu0cnxBzGqOKBzWvPOqzkhilCpe3+HKTk MfuWDmXR+FQkWpW6fLRLIkLTFHo75/eand8mocN2utpjFcfPrwiP8mpP8j/G/9Yzd6A7kjRVYvQ qHzisgmRJUO5agELg4XEq+vWonYghFUWbvqR+xm5h72LK/b4U/W14/4gaFZhnXQAKbe8= X-Gm-Gg: ATEYQzz0frLxHPvXAN7tKqeyst90tOZpe7vXCwPXHBpclU1dPuSXBQ0LEtKTIryFoHc bIBdLKDt4HUKXFIzmCVyaIGrfPVos6mgrN3vUmUzC/XxPzviGbXw39up2AGx/8UdwDNZy+BFyNW 3EzAkZYjEf6dDO61JTlsV1RXoW4QW1jOg1L64BBDUAPzoP9sXPD5y8d9IgrX/iL3TZoNzf+FaDV w8+wQJjivSox7/yb41YexNiOQAGyNYWPrnKAfUQwwll7Y4RvZTogeHU8nU1Br8cnw8aH4Cx4Zuy 89J0tmyPQckMgI2sLf+5fqB0idiTT5nksmWmtii4NFZlqrZciMmCL8Tvkjn4bxb37oIaMFyXWbI PC7uWp8demQH9tvQNUBsGiGJVYJ7t+MaNMpJEdv/SpDidrE+3p7H0LoBIQFP4rNxM9qjoFrzPCG kXaZc= X-Received: by 2002:a05:622a:1386:b0:50b:92cc:f879 with SMTP id d75a77b69052e-50ba39655dcmr21840491cf.7.1774615673879; Fri, 27 Mar 2026 05:47:53 -0700 (PDT) X-Received: by 2002:a05:622a:1386:b0:50b:92cc:f879 with SMTP id d75a77b69052e-50ba39655dcmr21840131cf.7.1774615673384; Fri, 27 Mar 2026 05:47:53 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66b0e41fbbesm1568517a12.11.2026.03.27.05.47.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 05:47:52 -0700 (PDT) Message-ID: Date: Fri, 27 Mar 2026 13:47:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/11] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add ov02c10 RGB sensor on CSIPHY4 To: Neil Armstrong , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260316-x1e-camss-csi2-phy-dtsi-v2-0-859f3fa55790@linaro.org> <20260316-x1e-camss-csi2-phy-dtsi-v2-10-859f3fa55790@linaro.org> <85483caa-5e62-4c66-b3a9-23ff7fc16f98@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <85483caa-5e62-4c66-b3a9-23ff7fc16f98@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=A99h/qWG c=1 sm=1 tr=0 ts=69c67c7a cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=-UYcpfoDvQNaV7eXuvMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: hEe1jmGaNYMQ0aj4VaLkDz_vckdsCFk2 X-Proofpoint-GUID: hEe1jmGaNYMQ0aj4VaLkDz_vckdsCFk2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDA4NyBTYWx0ZWRfX5zMnrhBK92NN fw/fQL0WQ69mSZLE0HSlVTcBAjRm+U+ndarJQZetpmkLiO8z2ig6PIAOqi9WKZUYPFAA9Fo6AR/ BRqdRkFZR3zIRaKOJfzYbPOSP581j8U4F045QwR54P6pB389KP1VuHQb+tyTx85iZSvXsVM7pV/ WVAb1XgNpdRzvgS5V04q7necGVG3XdefBeYJ+V9u64mEEZN7bA8k2AAxQIXmiDkMxBYHRwTJ4T6 aKOaFD1zsSfJKa/mylgQvNZENuSOPlKxS5l2WWBQ/watlmLDMLkIBU9iwPqikUd5DoZk7El/dVM LmcJEpmSg/Fp0V9U8GoE5+bXXf4YDmluvGZJbNrA8kRMlShaH/X37fsABB745iD11N0zJAaM1pb x/uOzF2xnv2AjcZHwPevUV6EjqxSdXV9pb2k67+JxDhv+peV8956slc9HwrgHNsSJTmqq1bvoLH uvBcqF3XZNz5jwCEcTw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 malwarescore=0 spamscore=0 impostorscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270087 On 3/18/26 10:26 AM, Neil Armstrong wrote: > On 3/16/26 12:46, Bryan O'Donoghue wrote: >> On 16/03/2026 08:28, Neil Armstrong wrote: >>>> +    ports { >>>> +        /* >>>> +         * port0 => csiphy0 >>>> +         * port1 => csiphy1 >>>> +         * port2 => csiphy2 >>>> +         * port3 => csiphy4 >>>> +         */ >> >> Hi. >> >> Thanks for the review. >> >> I think the above comment probably isn't making this very clear. >> >> port0 => csiphy0 => msm_csiphy0 in the media-graph. >> >>>> +        port@3 { >>>> +            camss_csiphy4_inep0: endpoint@0 { >>>> +                clock-lanes = <7>; >>>> +                data-lanes = <0 1>; >>>> +                remote-endpoint = <&ov02c10_ep>; >>> >>> This is quite wrong, with the PHY in a separate node, the lanes layout has nothing >>> to do in the "controller" ports since the sensor is connected to the the PHY which >>> configures the lanes functions. >>> >>> The PHY should be a media element in a port/endpoint chain to properly describe the >>> data flow from the sensor to the controller. >> >> If I am reading your comment right, we are already defining the data-lanes where you've said they should be msm_csiphyX below port@X here maps to msm_csiphyX in the media graph. >> >> So for example here is how we configure this before and after the changes in this series >> >> media-ctl -v -d /dev/media0 -V '"ov08x40 '2-0036'":0[fmt:SGRBG10/3856x2416 field:none]' >> media-ctl -V '"msm_csiphy4":0[fmt:SGRBG10/3856x2416]' >> media-ctl -V '"msm_csid0":0[fmt:SGRBG10/3856x2416]' >> media-ctl -V '"msm_vfe0_rdi0":0[fmt:SGRBG10/3856x2416]' >> media-ctl -l '"msm_csiphy4":1->"msm_csid0":0[1]' >> media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]' >> media-ctl -d /dev/media0 -p > > So a csiphy is a media element here, so why implement it as a PHY ? and there's a data link with CSID with should represented with a port/endpoint relationship... Does it need to be a media element in the first place? If it's just about configuration, then we can (?) make an assumption that the PHY is hardwired to the sensor, and if we want/need to mux CSIDn to the sensor device, which would then trigger a change in the PHY (if the PHY even needs to know it's being remuxed?) i.e. the above sequence would have: media-ctl -l '"ov08x40 '2-0036'":1->"msm_csid0":0[1]' Konrad