From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39BAB1A073F for ; Mon, 27 Apr 2026 03:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777260307; cv=none; b=ECQSESXzrUm06IjV6o/I+pbElJNHtB02VTnlCryrU04k1iy/YF7IqgAS7Lbb1gH8q5ohhpVqPkhSQa0DvFn85hmT+EgS2uhEeu79/i39dx0ARfYdajwBQc5C7us+ZhKYS4W4pbf8vYRNhfQMWpMTeXQqSwo7c64/v5vgFmSXF3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777260307; c=relaxed/simple; bh=xEAINMnZz9D/DBSt6LR1wkjRgSAuMWgsV4JWRptfsVE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qYIIRUsoF/L1fpkfQ0SnaL05+C31GAOd+Jj0csWHi4FdvISD3b6Ex8BtA08Q60dXRDAAo+aMEPGa+xVeePqW5Dw66yxXp2SIwVQmgxZdb81m9kbLY8lVDaEudkVhh31KOJ3rE1jW2s1HQIOloZjhyGKq6TaCcWlWdyRu8JSVhd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RXsyhAzs; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RXsyhAzs" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-35fb7c1a455so3584501a91.3 for ; Sun, 26 Apr 2026 20:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777260305; x=1777865105; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=1J71hYa3LRkXZXSVBEaVZVZA7V4M4SqbkBCX9WO4BWM=; b=RXsyhAzsxUq2s/LISe6w093UCRGVX4v/6QymRZ6yFeqNa0sajn7GuYdF6UJymRD9Oc JhiRoKPIpYrrAx4aHxbcBye3zUhOtD4Vm8OuF+EV8uMA3QJ/ZyGqWtaRX6Rnr04s6Vqs 3bdSDCe7Ypje5aoAdBZKDd4eQby+3b5H5eBMjseGXGaqDxJbB8UW19UFjYEh7/tft9Xx oBlWNvWrw6vsdkSfknsf+uYjX5XP2p02/RspbFjkBf0wttxkaU5M2D1nQYLj4pKd0d6a wCgRJR6xNqj8RnB3fDIqoUjwBbYTf43IGdrD5ynaIKe1PjW9ChSb7hmORh3iq1Zmtl/X uzaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777260305; x=1777865105; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1J71hYa3LRkXZXSVBEaVZVZA7V4M4SqbkBCX9WO4BWM=; b=G4FfuMnNndHjZI86gLJ7ABajNYD1zxj7t+XVJe64+gMXlTarm45qb4VgeynjYO2SIj duO2scp9LH3wOmwM7omFPVejfe706yUMk8WLsPiKshuZTvwYpsz6AuH0C3VlyqgIpMIg oE6f9uf2l/ilZr64pIpF9N9DiPga+ADhCO6me09RNfuuW5NNMv3EzOeSUG0Toxl5QMMF N4M4WHM9S9xZQDkKUAH4Yy+k006hEnX1ry7Jv91/975u/kxjAD9ED3O18mHZbVdxutcn YoEShoaomkZFnvbvet765zs8ZG81iuSE28wA+NaPl4dsUwvIBZJdn9TzXVHFze+fS6tO pzSA== X-Forwarded-Encrypted: i=1; AFNElJ9INZ8G6bZOKjmbEGvZjIlNoF9EZr44w3jNcScpcZ15u0ZLLZENiCw8DMLMh2Ag6HEq9nOUacuIwV2FeU0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8DVdSaPf81SdU5wgnOEDFnPZpNAM76M9jtCefykq3ypPZDX3j hcx2kxzC9VcQz1m3TMowRPa5wO5SKqM+oBnITQM+ylDL0sLi7+g7GfON X-Gm-Gg: AeBDieu1i24SqtDr3N0JXEpVTCAM0B/643LWuNM/stNkEX8PHR/0zDQxC446CpJjTKW u9rhU99KY7VllnT/1s4fBnu6/w2ph7NU8jFfdn/4mnreiaHIxry1xKuU6A3ntl1u5yoIvbT0whp vdhGJVYh5indPE5Ly5sAfDkAc1FgDLmB4NebOs24QBOa63EVwqADTMXVQcLPOqLO4RPHwKPyeCn 8EiRjxQcxvUu93vWRXOFncXDNvAb0kwOUsznXO0afjInhYhL5U7zV6skQPu/U5FOWH0iaWU9rWP ZK2uTB1wn3f3kp5QHHAT3ui3vC36+rUwJGOrabNABWgOVzZAhcRmXYzTWGEtnHnwh8Bto338hhK ZUn4kDK84uIjBeJolg0jcNpUbffc9LPQ2DsbCFQ1gKXLaE6dK3NOYMAk2WhnQQVCy/hPbF+ZRg/ +zzju+vKiSEm70zuRwvp1aTESYICO9ziBLFqQ7ntUpWM/GzWY= X-Received: by 2002:a17:90b:1d50:b0:364:7a37:4066 with SMTP id 98e67ed59e1d1-3647a3742c0mr2208396a91.14.1777260305450; Sun, 26 Apr 2026 20:25:05 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36140ff2e1esm29220875a91.8.2026.04.26.20.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 20:25:04 -0700 (PDT) Sender: Guenter Roeck Date: Sun, 26 Apr 2026 20:25:03 -0700 From: Guenter Roeck To: Stephen Eta Zhou Cc: Daniel Lezcano , Thomas Gleixner , linux-kernel@vger.kernel.org, Guenter Roeck , kernel test robot Subject: Re: [PATCH v2] clocksource: timer-sp804: Fix an Oops when read_current_timer is called on ARM32 platforms where the SP804 is not registered as the sched_clock. Message-ID: References: <20251225-fix_timersp804-v2-1-a366d7157f58@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251225-fix_timersp804-v2-1-a366d7157f58@gmail.com> Hi, On Thu, Dec 25, 2025 at 04:16:31PM +0800, Stephen Eta Zhou wrote: > On SP804, the delay timer shares the same clkevt instance with > sched_clock. > On some platforms, when sp804_clocksource_and_sched_clock_init > is called with use_sched_clock not set to 1, > sched_clkevt is not properly initialized. However, > sp804_register_delay_timer is invoked unconditionally, > and read_current_timer() subsequently calls sp804_read > on an uninitialized sched_clkevt, leading to a kernel > Oops when accessing sched_clkevt->value. > > Declare a dedicated clkevt instance exclusively for delay timer, > instead of sharing the same clkevt with sched_clock. > This ensures that read_current_timer continues to work correctly > regardless of whether SP804 is selected as the sched_clock. > > Fixes: 640594a04f11 ("clocksource/drivers/timer-sp804: Fix read_current_timer() issue when clock source is not registered") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202512250520.APOMkYRQ-lkp@intel.com/ > Signed-off-by: Stephen Eta Zhou I found that the integratorcp qemu emulation still hangs unpredictably with this and the preceding patch in the tree. I have no idea what is causing the problem, except that it disappears if I revert this patch and 640594a04f11. It appears that no one else has reported the problem, which suggests to me that no one cares. Given that, I'll stop testing the upstream kernel against the integratorcp qemu emulation. This is just informational; no action expected or warranted. Thanks, Guenter