From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6BC82877C3 for ; Mon, 16 Jun 2025 13:55:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750082149; cv=none; b=H3eyf/HZnHVkf9zSfy9eeX+frdvuPvRyaGASGDQR/tQrtN83j/zJ03BR8+YAKXDzWkI5yjLb5pNk8mlEzkQnqkcmqac62yAPi2u5y0ra5WMJlJaeAOMYA/EUQM6NVO/X+lbVncEz+Edgft9kRu0m90owJ+NmK+urz3m48koVnr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750082149; c=relaxed/simple; bh=3e3eB4muD3EpvcsC9L6Q0h5kVqMreAfRRRIj6lFfMjI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Yo3vFo1nPfpegSt1WBKp657i+aDV+IuazMAR81yNUt84Faaw5c4I0Gl6COJCrOK7T+76NgzjCydvVCVZtz3N1mjWoLVQ6SmOqOwMc3yCkUHeT31L4nS1UeoTGWRIiHwGc0jsOuVaMdx5CAiHWHdcbHZRWfhRHz+R2rUroYvUA58= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=C7l26tzL; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="C7l26tzL" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-451d7b50815so37959295e9.2 for ; Mon, 16 Jun 2025 06:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1750082146; x=1750686946; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0CEry3X85ozS8Z1Uce4c2f0+5kW2c09B3vCuZTGfDKo=; b=C7l26tzLFY5+QVD/YWv8OeByVcL/rij7VKbuSG6HHVkkbJ1bgwW5Nk04x5Jnve+EVW BTcOJmg4xdlR2l4xpETxks0jzLyCqQ9jY/ev4NPYmd7KKzrKMli/BOE3Al59hc5dKb/f 0lvV3GkWo1mwKswDscEXSZLhcz4tLp4ZrkPKnQSYJb0vbpoPmbqaeIdF320MJIxpbKPK 3cxNkaoHKULtAfkhnuOPLuo0bk+KZNdq+rsg52rLEtwqljPzCVyEVVxcsgF46h4f537m xCutLZ8fDE+wPP4MK8StfmGU7hT31haYfeos3jTXXs3Q16Y9ai15FFkQa+sUAi0I1ab/ gj7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750082146; x=1750686946; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0CEry3X85ozS8Z1Uce4c2f0+5kW2c09B3vCuZTGfDKo=; b=AYAZRW+9qAOcuf12i0EoC6MZJOsIJWMu6Bycye1q5glMTMpHzsu3KaU79/bjFFRtdo XTEXRX+UFCRzKwSeHw29W3aBJ7dFf5qk1aTdfD62M/MfFYU2TQEx58CP2oRccKooeYPc 5B+pyG1+YflIHIDLZ2TvhLxwJxl3upFbhgQw2U+sUcBCiEauDXe6BZGan0R7BEEcY4BW rqfVxx86PSwsskFTDjozCXsCiDcru70nZ5dXhX4Wo6Xe6CgXJHQArqSK61/AhAr5E9K/ LVlGgNN9bJH784QH1Zw7lU/ghv4AqNMsxYLY0deg5DRnHl+6szjNqW1T2L6brJ5CwXHp +Vzg== X-Forwarded-Encrypted: i=1; AJvYcCUh8lahOiB37qjB1yM5+rN/KbxCvLFV4K9z+saMsmW95/IAtbJ1Cgpjq9kQKlEECdUYymDg+hFc/OrfUWc=@vger.kernel.org X-Gm-Message-State: AOJu0YyLwKTqyJBvZ4dkMJDZ6Odf3RgTXKOQqYJ7M8Z4/nbWLXQbSZ4N yZtsriJVat9RAcifq3VgBOVhYxn94J5n5Qyv5FqdHAbedFsV/CX/hIFM7Tvmh1+nFPU= X-Gm-Gg: ASbGncsIKr4V4lAibFqB3IsDzTprATvqy6RqM/VIXW/NHuG8FQMBeAxbpyF/1CgyTYK lTxfRQevAJw+h5NmXHRUk4ylpGIeITSqJ9FJJ7X4A3qVVsgJdBMaKP6Uq8lsxivE1ZSC7zCYAnt mhaGmMU3GtZfOxSzn6vFN8A1vqJ0umfsgesuk+Hepv/hufxI3tnebtOZQRR++Rs5+/IwluY84ej gCpkgS9rgVN7YYkDqI/PQsArVyfXHVIMarbgDw+bE/OcTOOc7vSy2QK6QK7U2yDTvt7VR1NR4YM 8CQrNd49bVaTlbp68NmCXDiVt8d8byC9Z0xq2fvnXWaQkEbGWYclF4VEQjqndPxuPg== X-Google-Smtp-Source: AGHT+IE7aNvrL801nce5K/gCd4B0EbDVYCJl9pyUvZAsnQZSq9qyx+zKtCFrtCQyL2xM4CQ5A+4QYA== X-Received: by 2002:a05:600c:3587:b0:43d:4e9:27ff with SMTP id 5b1f17b1804b1-4533cacf27fmr81249365e9.7.1750082146044; Mon, 16 Jun 2025 06:55:46 -0700 (PDT) Received: from [10.100.51.209] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b19b32sm11311798f8f.67.2025.06.16.06.55.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jun 2025 06:55:45 -0700 (PDT) Message-ID: Date: Mon, 16 Jun 2025 15:55:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] audit,module: restore audit logging in load failure case To: Richard Guy Briggs Cc: Paul Moore , Eric Paris , Steve Grubb , Linux-Audit Mailing List , LKML , linux-modules@vger.kernel.org, Linux Kernel Audit Mailing List References: <9b7b21e5f37f5718fe9176a36ebf670bbdfdd54a.1748462545.git.rgb@redhat.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: <9b7b21e5f37f5718fe9176a36ebf670bbdfdd54a.1748462545.git.rgb@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/13/25 9:58 PM, Richard Guy Briggs wrote: > The move of the module sanity check to earlier skipped the audit logging > call in the case of failure and to a place where the previously used > context is unavailable. > > Add an audit logging call for the module loading failure case and get > the module name when possible. > > Link: https://issues.redhat.com/browse/RHEL-52839 > Fixes: 02da2cbab452 ("module: move check_modinfo() early to early_mod_check()") > Signed-off-by: Richard Guy Briggs Looks ok to me from the modules perspective. Reviewed-by: Petr Pavlu -- Thanks, Petr