mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuogee Hsieh <quic_khsieh@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	<dri-devel@lists.freedesktop.org>, <robdclark@gmail.com>,
	<sean@poorly.run>, <swboyd@chromium.org>, <dianders@chromium.org>,
	<vkoul@kernel.org>, <daniel@ffwll.ch>, <airlied@gmail.com>,
	<agross@kernel.org>, <andersson@kernel.org>
Cc: <quic_abhinavk@quicinc.com>, <quic_sbillaka@quicinc.com>,
	<marijn.suijten@somainline.org>,
	<freedreno@lists.freedesktop.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 4/5] drm/msm/dpu: calculate DSC encoder parameters dynamically
Date: Fri, 21 Apr 2023 14:30:55 -0700	[thread overview]
Message-ID: <e1294f23-5eda-6aa1-0363-a4d503d2fa59@quicinc.com> (raw)
In-Reply-To: <62df2f48-2553-72f0-43e4-9a5d4027ab81@linaro.org>


On 4/21/2023 2:13 PM, Dmitry Baryshkov wrote:
> On 22/04/2023 00:07, Kuogee Hsieh wrote:
>>
>> On 4/20/2023 5:27 PM, Dmitry Baryshkov wrote:
>>> On 21/04/2023 02:25, Kuogee Hsieh wrote:
>>>> During DSC preparation, add run time calculation to figure out what
>>>> usage modes, split mode and merge mode, is going to be setup.
>>>>
>>>> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
>>>> ---
>>>>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 56 
>>>> ++++++++++++++++-------------
>>>>   1 file changed, 32 insertions(+), 24 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c 
>>>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
>>>> index 2fdacf1..5677728 100644
>>>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
>>>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
>>>> @@ -529,17 +529,9 @@ void dpu_encoder_helper_split_config(
>>>>   bool dpu_encoder_use_dsc_merge(struct drm_encoder *drm_enc)
>>>>   {
>>>>       struct dpu_encoder_virt *dpu_enc = to_dpu_encoder_virt(drm_enc);
>>>> -    int i, intf_count = 0, num_dsc = 0;
>>>> +    struct msm_display_topology *topology = &dpu_enc->topology;
>>>>   -    for (i = 0; i < MAX_PHYS_ENCODERS_PER_VIRTUAL; i++)
>>>> -        if (dpu_enc->phys_encs[i])
>>>> -            intf_count++;
>>>> -
>>>> -    /* See dpu_encoder_get_topology, we only support 2:2:1 
>>>> topology */
>>>> -    if (dpu_enc->dsc)
>>>> -        num_dsc = 2;
>>>> -
>>>> -    return (num_dsc > 0) && (num_dsc > intf_count);
>>>> +    return (topology->num_dsc > topology->num_intf);
>>>>   }
>>>>     static void dpu_encoder_get_topology(
>>>> @@ -1861,41 +1853,57 @@ static void dpu_encoder_prep_dsc(struct 
>>>> dpu_encoder_virt *dpu_enc,
>>>>       struct dpu_encoder_phys *enc_master = dpu_enc->cur_master;
>>>>       struct dpu_hw_dsc *hw_dsc[MAX_CHANNELS_PER_ENC];
>>>>       struct dpu_hw_pingpong *hw_pp[MAX_CHANNELS_PER_ENC];
>>>> +    struct msm_display_topology *topology = &dpu_enc->topology;
>>>>       int this_frame_slices;
>>>>       int intf_ip_w, enc_ip_w;
>>>> -    int dsc_common_mode;
>>>> +    int dsc_common_mode = 0;
>>>>       int pic_width;
>>>>       u32 initial_lines;
>>>> +    int num_dsc, num_intf;
>>>>       int i;
>>>>         for (i = 0; i < MAX_CHANNELS_PER_ENC; i++) {
>>>>           hw_pp[i] = dpu_enc->hw_pp[i];
>>>>           hw_dsc[i] = dpu_enc->hw_dsc[i];
>>>> -
>>>> -        if (!hw_pp[i] || !hw_dsc[i]) {
>>>> -            DPU_ERROR_ENC(dpu_enc, "invalid params for DSC\n");
>>>> -            return;
>>>> -        }
>>>
>> Why?
>>
>> MAX_CHANNELS_PER_ENC == 2
>>
>> This works for dsi since it use 2 dsc encoder.
>>
>> Since DP only use one dsc encoder, this will cause it return at loop 
>> 2 without execute dpu_encoder_dsc_pipe_cfg().
>
> Then the loop should go up to num_dsc rather than MAX_CHANNELS_PER_ENC
>
>>
>>>
>>>>       }
>>>>   -    dsc_common_mode = 0;
>>>> +    num_dsc = topology->num_dsc;
>>>> +    num_intf = topology->num_intf;
>>>> +
>>>>       pic_width = dsc->pic_width;
>>>>   -    dsc_common_mode = DSC_MODE_MULTIPLEX | DSC_MODE_SPLIT_PANEL;
>>>>       if (enc_master->intf_mode == INTF_MODE_VIDEO)
>>>>           dsc_common_mode |= DSC_MODE_VIDEO;
>>>>   +    /*
>>>> +     * If this encoder is driving more than one DSC encoder, they
>>>> +     * operate in tandem, same pic dimension needs to be used by
>>>> +     * each of them.(pp-split is assumed to be not supported)
>>>> +     *
>>>> +     */
>>>> +
>>>>       this_frame_slices = pic_width / dsc->slice_width;
>>>>       intf_ip_w = this_frame_slices * dsc->slice_width;
>>>> +    enc_ip_w = intf_ip_w;
>>>> +
>>>> +    intf_ip_w /= num_intf;
>>>> +
>>>> +    if (num_dsc > 1)
>>>> +        dsc_common_mode |= DSC_MODE_SPLIT_PANEL;
>>>> +
>>>> +    if (dpu_encoder_use_dsc_merge(&dpu_enc->base)) {
>>>> +        dsc_common_mode |= DSC_MODE_MULTIPLEX;
>>>> +        /*
>>>> +         * in dsc merge case: when using 2 encoders for the same
>>>> +         * stream, no. of slices need to be same on both the
>>>> +         * encoders.
>>>> +         */
>>>> +        enc_ip_w = intf_ip_w / 2;
>>>
>>> So do you want to get enc_ip_w / 2 or enc_ip_w / num_intf / 2 here?
>> enc_ip_w / num_intf / 2
>
> But previously we had enc_ip_w = intf_ip_w / 2. Was it because of the 
> assumption that num_intf = 1?
i think so since there is no num_intf involve at previous code.
>
>>>
>>>> +    }
>>>>   -    /*
>>>> -     * dsc merge case: when using 2 encoders for the same stream,
>>>> -     * no. of slices need to be same on both the encoders.
>>>> -     */
>>>> -    enc_ip_w = intf_ip_w / 2;
>>>>       initial_lines = dpu_encoder_dsc_initial_line_calc(dsc, 
>>>> enc_ip_w);
>>>>   -    for (i = 0; i < MAX_CHANNELS_PER_ENC; i++)
>>>> +    for (i = 0; i < num_dsc; i++)
>>>>           dpu_encoder_dsc_pipe_cfg(dpu_enc, hw_dsc[i], hw_pp[i], dsc,
>>>>                       dsc_common_mode, initial_lines);
>>>>   }
>>>
>

  reply	other threads:[~2023-04-21 21:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20 23:25 [PATCH v1 0/5] add DSC 1.2 dpu supports Kuogee Hsieh
2023-04-20 23:25 ` [PATCH v1 1/5] drm/msm/dpu: add support for DSC encoder v1.2 engine Kuogee Hsieh
2023-04-20 23:54   ` Dmitry Baryshkov
2023-04-26 16:09     ` Kuogee Hsieh
2023-04-21  3:52   ` kernel test robot
2023-04-21 19:12   ` kernel test robot
2023-04-22  0:25   ` Dmitry Baryshkov
2023-04-20 23:25 ` [PATCH v1 2/5] drm/msm/dpu: separate DSC flush update out of interface Kuogee Hsieh
2023-04-20 23:58   ` Dmitry Baryshkov
2023-04-20 23:25 ` [PATCH v1 3/5] drm/msm/dpu: save dpu topology configuration Kuogee Hsieh
2023-04-21  0:12   ` Dmitry Baryshkov
2023-04-21  0:36     ` Abhinav Kumar
2023-04-20 23:25 ` [PATCH v1 4/5] drm/msm/dpu: calculate DSC encoder parameters dynamically Kuogee Hsieh
2023-04-21  0:27   ` Dmitry Baryshkov
2023-04-21 21:07     ` Kuogee Hsieh
2023-04-21 21:13       ` Dmitry Baryshkov
2023-04-21 21:30         ` Kuogee Hsieh [this message]
2023-04-21 21:31           ` Dmitry Baryshkov
2023-04-20 23:25 ` [PATCH v1 5/5] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets Kuogee Hsieh
2023-04-21  0:07   ` Dmitry Baryshkov
2023-04-21 22:05     ` Kuogee Hsieh
2023-04-21 22:16       ` Dmitry Baryshkov
2023-04-21 23:08         ` Kuogee Hsieh
2023-04-21 23:11           ` Dmitry Baryshkov
2023-04-21 23:16             ` Kuogee Hsieh
2023-04-21 23:22               ` Dmitry Baryshkov
2023-04-24 16:58                 ` Kuogee Hsieh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1294f23-5eda-6aa1-0363-a4d503d2fa59@quicinc.com \
    --to=quic_khsieh@quicinc.com \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_sbillaka@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®