From: Shawn Lin <shawn.lin@rock-chips.com>
To: Li Wei <liwei213@huawei.com>,
ulf.hansson@linaro.org, jh80.chung@samsung.com,
hkallweit1@gmail.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: shawn.lin@rock-chips.com, guodong.xu@linaro.org
Subject: Re: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver init
Date: Mon, 14 Aug 2017 09:18:36 +0800 [thread overview]
Message-ID: <e1297f68-112e-1a93-d769-ad06b04714cd@rock-chips.com> (raw)
In-Reply-To: <20170811080624.42173-1-liwei213@huawei.com>
Trim cc
On 2017/8/11 16:06, Li Wei wrote:
> This commit modifies dw_mci_probe(), it moves reset assertion before
> drv_data->init(host)
>
> Some driver needs to access controller registers in its .init() ops. So,
> in order to make such access safe, we should do controller reset before
> .init() being called.
>
LGTM
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Wei Li <liwei213@huawei.com>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> Signed-off-by: Chen Jun <chenjun14@huawei.com>
> ---
prev parent reply other threads:[~2017-08-14 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 8:06 Li Wei
2017-08-11 8:06 ` [PATCH v10 2/2] mmc: dw_mmc-k3: add sd support for hi3660 Li Wei
2017-08-14 1:18 ` Shawn Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1297f68-112e-1a93-d769-ad06b04714cd@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=guodong.xu@linaro.org \
--cc=hkallweit1@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=liwei213@huawei.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®