From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752324AbdBMKtP (ORCPT ); Mon, 13 Feb 2017 05:49:15 -0500 Received: from mx2.suse.de ([195.135.220.15]:50096 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144AbdBMKtM (ORCPT ); Mon, 13 Feb 2017 05:49:12 -0500 Subject: Re: IB/hfi1: Adjust another size determination in hfi1_user_sdma_alloc_queues() To: SF Markus Elfring , linux-rdma@vger.kernel.org References: <8a997282-09c7-0f9f-645e-d7c6e8c79e67@users.sourceforge.net> <0fdf4d81-58d7-c6fc-b37f-41d47675dd83@users.sourceforge.net> <4dca91c1-488d-120d-bd25-74f400242bd2@users.sourceforge.net> <9ce8c7b1-1ae5-fe15-2740-b4f7653555c4@suse.de> <8ec653df-9d73-3c94-9559-7a732417e578@users.sourceforge.net> Cc: Dennis Dalessandro , Doug Ledford , Hal Rosenstock , Mike Marciniszyn , Sean Hefty , LKML , kernel-janitors@vger.kernel.org From: Johannes Thumshirn Message-ID: Date: Mon, 13 Feb 2017 11:49:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <8ec653df-9d73-3c94-9559-7a732417e578@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/13/2017 11:37 AM, SF Markus Elfring wrote: >> and you introduce a stylistic glitch (the new line break in a function call). > > There are different opinions about this implementation detail, aren't there? As I said, I'm just a casual reader of the RDMA list and I expressed my opinion that this change is counter productive. It's up to the RDMA maintainers to decide whether they want to take the change or not. But as someone who's dayjob is to work with this code (or better backport patches to stable trees and fix customer issues) I prefer keeping it as it was. So enough bikeshedding for today. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850