mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adam Young <admiyo@amperemail.onmicrosoft.com>
To: YH Chung <yh_chung@aspeedtech.com>,
	Jeremy Kerr <jk@codeconstruct.com.au>,
	"matt@codeconstruct.com.au" <matt@codeconstruct.com.au>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	BMC-SW <BMC-SW@aspeedtech.com>
Cc: Khang D Nguyen <khangng@amperemail.onmicrosoft.com>
Subject: Re: [PATCH] net: mctp: Add MCTP PCIe VDM transport driver
Date: Thu, 17 Jul 2025 17:43:11 -0400	[thread overview]
Message-ID: <e1314a38-5350-41cb-9ffa-82617eff67be@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <SEZPR06MB5763125EBCAAA4F0C14C939E9051A@SEZPR06MB5763.apcprd06.prod.outlook.com>


On 7/17/25 03:17, YH Chung wrote:
>  From my perspective, the other MCTP transport drivers do make use of abstraction layers that already exist in the kernel tree. For example, mctp-i3c uses i3c_device_do_priv_xfers(), which ultimately invokes operations registered by the underlying I3C driver. This is effectively an abstraction layer handling the hardware-specific details of TX packet transmission.
>
> In our case, there is no standard interface—like those for I2C/I3C—that serves PCIe VDM. So, the proposed driver tries to introduce a unified interface, defined in mctp-pcie-vdm.h, to provide a reusable interface that allows developers to focus on hardware-specific implementation without needing to duplicate or rework the transport binding logic each time.
>
> Could you kindly share your thoughts or guidance on how the abstraction model used in our PCIe VDM driver compares to the existing abstractions used in I2C/I3C transport implementations?


Would the mailbox abstraction work for this?  It is what I am using in 
the MCTP over PCC code.  Perhaps a PCIe VDM mailbox implementation will 
have a wider use  than just MCTP.


  parent reply	other threads:[~2025-07-17 21:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14  6:25 aspeedyh
2025-07-14  8:54 ` Jeremy Kerr
2025-07-14 12:37   ` YH Chung
2025-07-15  1:08     ` Jeremy Kerr
2025-07-17  3:07       ` YH Chung
2025-07-17  5:37         ` Jeremy Kerr
2025-07-17  7:17           ` YH Chung
2025-07-17  7:31             ` Jeremy Kerr
2025-07-17  8:21               ` YH Chung
2025-07-17 21:40                 ` Adam Young
2025-07-18  3:24                 ` Jeremy Kerr
2025-07-17 21:43             ` Adam Young [this message]
2025-07-18  5:48           ` Khang D Nguyen
2025-07-18  6:03             ` Jeremy Kerr
2025-07-18 11:05               ` YH Chung
2025-07-15  2:26 ` kernel test robot
2025-07-17 10:39 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1314a38-5350-41cb-9ffa-82617eff67be@amperemail.onmicrosoft.com \
    --to=admiyo@amperemail.onmicrosoft.com \
    --cc=BMC-SW@aspeedtech.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jk@codeconstruct.com.au \
    --cc=khangng@amperemail.onmicrosoft.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeconstruct.com.au \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yh_chung@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®