From: Andrew Lunn <andrew@lunn.ch>
To: joseph@telaak.dev
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Chuanhong Guo <gch981213@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-mips@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: Add Siflower SF19A2890 GMAC
Date: Wed, 4 Nov 2026 22:29:10 +0100 [thread overview]
Message-ID: <e134193f-ba1b-47c1-9a06-419b1b796ea0@lunn.ch> (raw)
In-Reply-To: <20261104-sf19a2890-gmac-v1-1-a15965a49574@telaak.dev>
> + rx-internal-delay-ps:
> + description:
> + Applied in steps of about 55 ps, rounded to the nearest step.
> + maximum: 14025
Please add minimum, and multipleOf.
I've not looked at the code yet, but default: 0 would also be good.
> + rx-internal-delay-ps = <550>;
> + tx-internal-delay-ps = <935>;
These values are odd. The RGMII standard says 2ns is required. Where
is the rest coming from.
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
Does this mean there is a switch on the other end? Maybe look at what
the switch is doing for RGMII delays.
Andrew
next prev parent reply other threads:[~2026-11-04 21:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:22 [PATCH net-next 0/2] net: stmmac: Add the Siflower SF19A2890 glue Joseph Telaak via B4 Relay
2026-11-04 7:22 ` [PATCH net-next 1/2] dt-bindings: net: Add Siflower SF19A2890 GMAC Joseph Telaak via B4 Relay
2026-11-04 21:29 ` Andrew Lunn [this message]
2026-11-04 22:16 ` Joseph Telaak
2026-11-05 0:34 ` Joseph Telaak
2026-11-04 7:22 ` [PATCH net-next 2/2] net: stmmac: Add Siflower SF19A2890 glue Joseph Telaak via B4 Relay
2026-11-04 7:53 ` Maxime Chevallier
2026-11-04 8:40 ` Joseph Telaak
2026-11-04 21:35 ` Andrew Lunn
2026-11-04 22:19 ` Joseph Telaak
2026-11-04 7:58 ` [PATCH net-next 0/2] net: stmmac: Add the " Maxime Chevallier
2026-11-04 8:02 ` Joseph Telaak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e134193f-ba1b-47c1-9a06-419b1b796ea0@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=gch981213@gmail.com \
--cc=joabreu@synopsys.com \
--cc=joseph@telaak.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®