From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751914AbdAaLHr (ORCPT ); Tue, 31 Jan 2017 06:07:47 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:28499 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751482AbdAaLHm (ORCPT ); Tue, 31 Jan 2017 06:07:42 -0500 Subject: Re: [PATCH 15/17] net: stmmac: remove dead code in stmmac_tx_clean To: Corentin Labbe , , References: <20170131091152.13842-1-clabbe.montjoie@gmail.com> <20170131091152.13842-16-clabbe.montjoie@gmail.com> CC: , From: Giuseppe CAVALLARO Message-ID: Date: Tue, 31 Jan 2017 11:21:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170131091152.13842-16-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG4NODE1.st.com (10.75.127.10) To SFHDAG4NODE1.st.com (10.75.127.10) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-31_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/2017 10:11 AM, Corentin Labbe wrote: > Since commit cf32deec16e4 ("stmmac: add tx_skbuff_dma to save descriptors used by PTP"), > the struct dma_desc *p in stmmac_tx_clean was not used at all. > > This patch remove this dead code. > > Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 3d52b8c..b494bc2 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -1124,13 +1124,6 @@ static void dma_free_tx_skbufs(struct stmmac_priv *priv) > int i; > > for (i = 0; i < DMA_TX_SIZE; i++) { > - struct dma_desc *p; > - > - if (priv->extend_desc) > - p = &((priv->dma_etx + i)->basic); > - else > - p = priv->dma_tx + i; > - > if (priv->tx_skbuff_dma[i].buf) { > if (priv->tx_skbuff_dma[i].map_as_page) > dma_unmap_page(priv->device, >