mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Zi Yan <ziy@nvidia.com>, Sasha Levin <sashal@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R . Howlett" <liam@infradead.org>,
	Nico Pache <nico.pache@linux.dev>,
	Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
	Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
	Usama Arif <usama.arif@linux.dev>,
	Kiryl Shutsemau <kas@kernel.org>, Shuah Khan <shuah@kernel.org>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/mm: skip split_huge_page_test without the split_huge_pages file
Date: Thu, 5 Nov 2026 16:51:14 +0100	[thread overview]
Message-ID: <e135e15d-6a93-4856-a7ac-30977a2a2b5d@kernel.org> (raw)
In-Reply-To: <4B926B36-D797-4861-B6D6-27E8D7870287@nvidia.com>

On 11/5/26 16:19, Zi Yan wrote:
> On 4 Nov 2026, at 22:02, Sasha Levin wrote:
> 
>> Every case in split_huge_page_test goes through
>> /sys/kernel/debug/split_huge_pages. When that file does not exist,
>> because debugfs is not mounted or the kernel has no CONFIG_DEBUG_FS, the
>> first write bails out of the whole test and it is reported as a failure:
>>
>>   Bail out! write_file(/sys/kernel/debug/split_huge_pages): No such file or directory
>>
>> Skip the test in that case.
>>
>> Fixes: fa6c02315f74 ("mm: huge_memory: a new debugfs interface for splitting THP tests")
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>> ---
>> Found with KernelCI's NVIDIA lab, which runs the tests in a chroot
>> without debugfs. Tested on an AMD EPYC 9655P with KernelCI's x86_64
>> build of next-20261104: without debugfs the test now skips, and with
>> debugfs mounted it still passes all 62 cases.
>>
>>  tools/testing/selftests/mm/split_huge_page_test.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
> 
> Thanks. But I do think we need a way of specifying the necessary
> Kconfig options for selftests. Oh, we do have one:
> https://elixir.bootlin.com/linux/v7.3.1/source/tools/testing/selftests/mm/config. Can you add CONFIG_DEBUG_FS=y to it while at it?

Just what I was thinking.

-- 
Cheers,

David

  reply	other threads:[~2026-11-05 15:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  3:02 Sasha Levin
2026-11-05 11:49 ` Kiryl Shutsemau
2026-11-05 15:19 ` Zi Yan
2026-11-05 15:51   ` David Hildenbrand (Arm) [this message]
2026-11-05 17:18   ` [PATCH] selftests/mm: add CONFIG_DEBUG_FS to the config fragment Sasha Levin
2026-11-05 17:21     ` Zi Yan
2026-11-05 17:53       ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e135e15d-6a93-4856-a7ac-30977a2a2b5d@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=dev.jain@arm.com \
    --cc=kas@kernel.org \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=nico.pache@linux.dev \
    --cc=ryan.roberts@arm.com \
    --cc=sashal@kernel.org \
    --cc=shuah@kernel.org \
    --cc=usama.arif@linux.dev \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®