From: Sun Ke <sunke32@huawei.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: <xiang@kernel.org>, <chao@kernel.org>,
<linux-erofs@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, <yinxin.x@bytedance.com>
Subject: Re: [PATCH] erofs: fix error return code in erofs_fscache_meta_read_folio and erofs_fscache_read_folio
Date: Wed, 17 Aug 2022 10:48:47 +0800 [thread overview]
Message-ID: <e1369566-6459-2eae-35f4-818865a7df20@huawei.com> (raw)
In-Reply-To: <YvxVWP0njcgghe+r@B-P7TQMD6M-0146.local>
在 2022/8/17 10:41, Gao Xiang 写道:
> Hi Ke,
>
> On Wed, Aug 17, 2022 at 09:44:46AM +0800, Sun Ke wrote:
>>
>>
>> 在 2022/8/16 13:16, Gao Xiang 写道:
>>> On Mon, Aug 15, 2022 at 11:48:29AM +0800, Sun Ke wrote:
>>>> If erofs_fscache_alloc_request fail and then goto out, it will return 0.
>>>> it should return a negative error code instead of 0.
>>>>
>>>> Fixes: d435d53228dd ("erofs: change to use asynchronous io for fscache readpage/readahead")
>>>> Signed-off-by: Sun Ke <sunke32@huawei.com>
>>>
>>> Minor, I tried to apply this patch by updating the patch title into
>>> "erofs: fix error return code in erofs_fscache_{meta_,}read_folio"
>>>
>>> since the original patch title is too long.
>>
>> Should I send a v2 patch to update the title?
>
> I've already updated this by hand if you have no concern ;)
> will push out to -next today...
;)
Thanks,
Sun Ke
>
> Thanks,
> Gao Xiang
>
>>
>> Thanks,
>> Sun Ke
>>>
>>> Thanks,
>>> Gao Xiang
>>> .
>>>
> .
>
next prev parent reply other threads:[~2022-08-17 2:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 3:48 Sun Ke
2022-08-15 4:03 ` Gao Xiang
2022-08-15 12:14 ` JeffleXu
2022-08-16 5:16 ` Gao Xiang
2022-08-17 1:44 ` Sun Ke
2022-08-17 2:41 ` Gao Xiang
2022-08-17 2:48 ` Sun Ke [this message]
2022-09-05 15:10 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1369566-6459-2eae-35f4-818865a7df20@huawei.com \
--to=sunke32@huawei.com \
--cc=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
--cc=yinxin.x@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®