From: Sinan Kaya <okaya@codeaurora.org>
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>, bhelgaas@google.com
Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com,
shyam_iyer@dell.com, keith.busch@intel.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Check for PCIe downtraining conditions
Date: Thu, 31 May 2018 11:30:24 -0400 [thread overview]
Message-ID: <e137d5bf-b640-68ef-c07e-d872a9343548@codeaurora.org> (raw)
In-Reply-To: <20180531150535.9684-1-mr.nuke.me@gmail.com>
On 5/31/2018 11:05 AM, Alexandru Gagniuc wrote:
> + if (dev_cur_speed < max_link_speed)
> + pci_warn(dev, "PCIe downtrain: link speed is %s (%s capable)",
> + pcie_bus_speed_name(dev_cur_speed),
> + pcie_bus_speed_name(max_link_speed));
> +
Also this isn't quite correct. Target link speed is what the device tries to
train. A device can try to train to much lower speed than the maximum on purpose.
It makes sense to print this if the speed that platform wants via target link
speed is different from what is actually established though.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-05-31 15:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 15:05 Alexandru Gagniuc
2018-05-31 15:28 ` Sinan Kaya
2018-05-31 15:29 ` Alex_Gagniuc
2018-05-31 15:38 ` Sinan Kaya
2018-05-31 15:46 ` Alex G.
2018-05-31 15:54 ` Sinan Kaya
2018-05-31 16:01 ` Alex G.
2018-05-31 16:13 ` Sinan Kaya
2018-05-31 16:49 ` Alex G.
2018-05-31 16:50 ` Alex G.
2018-05-31 17:11 ` Sinan Kaya
2018-05-31 17:27 ` Alex G.
2018-05-31 21:52 ` Alex G.
2018-05-31 15:30 ` Sinan Kaya [this message]
2018-05-31 21:44 ` Alex G.
2018-06-01 13:30 ` Sinan Kaya
2018-06-02 17:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e137d5bf-b640-68ef-c07e-d872a9343548@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mr.nuke.me@gmail.com \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®