Re: [PATCH] soc: ti: smartreflex: void function return statements are not generally useful

[Dan Carpenter <dan.carpenter@linaro.org>]

No need to CC linux-staging@lists.linux.dev.  Use
scripts/get_maintainer.pl to find the appropriate lists.

Your From header doesn't have your name, just your email address.

The subject is too long.  Change it to:

[PATCH] soc: ti: smartreflex: Remove unnecessary return statement

The patch is corrupted.  Take a look at
Documentation/process/email-clients.rst.  Send an email to yourself
first to verify it applies.
> diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c
> index 62b2f1464e46..20abfb0b8f26 100644
> --- a/drivers/soc/ti/smartreflex.c
> +++ b/drivers/soc/ti/smartreflex.c
> @@ -955,7 +955,7 @@ static void omap_sr_shutdown(struct platform_device
> *pdev)
>      if (sr_info->autocomp_active)
>          sr_stop_vddautocomp(sr_info);
> 
> -    return;
> +

This introduces two blank lines in a row which is a style violation.  In
fact, there should be no blank lines before the last } closing brace in
a function so delete the other blank line as well.

>  }

regards,
dan carpenter