From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31302369970 for ; Sun, 12 Apr 2026 09:35:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775986541; cv=none; b=q83uXx+n+pQBESvqeZ2axBZ1smvYqr5dFLtzZLLEkdK/BLX4rVNWkB6oeY8JlpD1xpsVQTEBtBwgPaT5QMn2w3mLmEMcV+Unfi+F0K+Ldr50hlyapYc/YMwhLKq12JVEFAfESyi1/mSs4EIZTel6qzfZT97Hf17LVI9Ps0XBke0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775986541; c=relaxed/simple; bh=5KcLbBnpUP526jc6HeKCPLsUm6VqSn6+Giqky6YBi2E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dNeZzL09gAH7c5Upsx4HfIIru0JT16C2TLKNgKkzKhW7XvUM81yVhbN6Z1R91pkKla8HXntLrbI8ep2ReZIZg0tywBBbwZWVzHRbhbFuBb61gaj8emAWwesRm7AGr5NOYYAB4jl7ByM4um6c1uT9khZRCxwrT8ZFOlIgJfWOMm4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gHaRacsI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TIfiFSkX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gHaRacsI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TIfiFSkX" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63C4tcfK1557880 for ; Sun, 12 Apr 2026 09:35:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ntDR8NBqpIqaw9Ou8YQiyz9oJYsTv5hhvLULdDquyzs=; b=gHaRacsIHQ3rhQBO 10CmLBKSZaS9YhpTdxeU5anrIQfP2dDbLH2GcpvxkZX9hu6rZyO71XFHtuu0NrxT kvHXNgKtvAugWtIrMedoZDS1dPzMkbsH2l2r8XZImLI/vcLYVGZ1FKcpFNbfo/p4 nXqatTDvmi0e0EvDrGTYFECibheFChe7KLcrBd6ONdpa48ulBHy9K8NSJRHCzXSx dKQYNDeYpP3qPSuVQk251hlI0jGasdWGzqyHPkhsxkpwhctQCeNcsdNu7fs93apF lW0oHuW/ALgEg9JXQ/3I52LKAGCi0uvWQWq9Z/OpBQItx0Da38ph37eGtXRzQpuI FxbPiQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dfexct4a6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 12 Apr 2026 09:35:37 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50b323c43fdso61078731cf.2 for ; Sun, 12 Apr 2026 02:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775986537; x=1776591337; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ntDR8NBqpIqaw9Ou8YQiyz9oJYsTv5hhvLULdDquyzs=; b=TIfiFSkXAK4+HAiSMOk1aWoiooiYqtWhY2QzE6sDg9gnwL3hjAtGxUVT7WtvgCUIak OFYTA1PTlc4jWpDsDL9wO2QGFPQFccIlFfGEPowSuftFPTuW7rv87mtXfNahZ/D4mxzW wp9DjWpKeLyC+/Nmqtmtl0SyOBVgI09wJny1NOjie1aZgxnKyvGlBDxAA7S8mFO8NSAi ckV2fZyNLb91YAlWitH9BSiM55PbPGdbwe2u1DWeFf+dukEe6x6en6mShlZE0H16gpoY F21i/VgJc0GZJS0nwyRao5iwPrjda964j1DpkMA31NmZmbvPKN2Y/gmc0B3dvGCB0PMq 6Log== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775986537; x=1776591337; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ntDR8NBqpIqaw9Ou8YQiyz9oJYsTv5hhvLULdDquyzs=; b=hv6wdQBEqKlsRsy7h1bJFKqXUd5qy1EcMcmhJqa+O/67dKbgpeLC8amGLqAzvQhmEK a9eQpFnQlhWFpGx6xKdVUgMX3rmh/pyebZTYx6fH9QR0p6Jv1911DpPIvuaWOqWc1u8P fQxIFXsYregC7scp2ubLso33aIrM936WB1ZhKuXPOmleuvPSH1b1It33HsAR3md8Vdid 2jxq0ud+OmYLL+uHEYVK5omMarXBBhIYTjYzPo1l3bMrEvklqOnWgNP7wSubkgbU+Cnt elVS4+iVLNd2BMsxoM3VsRIm9fmFyr1z8OC5WSYsglurmfSYuy68YL61rqBcNmW0yOu0 3Iig== X-Forwarded-Encrypted: i=1; AJvYcCUStAHtaYZ8zEMtgv3ONPSehUBBwE1fMrKg53ofxyiNbqaoGc4wZ3NZYZXP+upIVSGR2ABYSDlt7SJJmc0=@vger.kernel.org X-Gm-Message-State: AOJu0YxNEt8cbiaXgAQwa3b0I6OyW5VZ3rq3mqa5FuRcvrAH26e2X/Zs taE4ROCfzaZitvwrN0atBnqfUXrYU7dZElexrXlvDDn3ltVJTuIyumab+/bmTB9MUg3jMlA5l2P nkB/byB1xpbCt1CEMP6THw3hrDwvkBHXZXuvXlJSAo9WkQ8rMQnRoBYHzoOBDHy7pTF4= X-Gm-Gg: AeBDievkPshXUEvhVV4pqf2u2fFNXZriHFRkRyFikUCUK7ekvBihVs19IjAOAMiS6/p bw+Kx0QamM/AptScg3sWedpZ+WiFoPk5B9dtKIXae+zhf5M1GX84rcnZzcEEs8+R7X1pNtaiHam DWOOt0Ru9TzHE7Je6M0so5BVhxhWl+DIHN22E18t1oRW0MBOJeFjCxYzzvkCSdUPsdJuFIfGR1H Cszdukm2Qana6IludsoLyW+2e0kj8urLjM1wrwXH2yUE4iXGVfDm0JOD1A8TYvrTctPPNyMApH9 Grvp05NOnWyGkt3969ofUKYMt1dJKZ6BIKV+4p31+6YJLANoIho19Hd4aS3lFFTyDYFSYxKcy0A nYXVgfpBDYciV5y+76J13S/6GvvYg7H/aRQ8BS5g0Pcgc3eXddSD8w5Dx7mlWaOSgLOAiHNGQWC LJnaufCPaP X-Received: by 2002:a05:622a:8a04:b0:50d:855a:8909 with SMTP id d75a77b69052e-50dd5b7cca7mr107851021cf.32.1775986537194; Sun, 12 Apr 2026 02:35:37 -0700 (PDT) X-Received: by 2002:a05:622a:8a04:b0:50d:855a:8909 with SMTP id d75a77b69052e-50dd5b7cca7mr107850761cf.32.1775986536700; Sun, 12 Apr 2026 02:35:36 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:ccc9:82ca:cc1b:b64c? ([2a05:6e02:1041:c10:ccc9:82ca:cc1b:b64c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5df2062sm69408705e9.12.2026.04.12.02.35.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Apr 2026 02:35:36 -0700 (PDT) Message-ID: Date: Sun, 12 Apr 2026 11:35:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] thermal/drivers/imx: Fix thermal zone leak on probe error path To: Frank Li , Felix Gu Cc: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Oleksij Rempel , linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260412-imx-v1-0-cc3b45d63811@gmail.com> <20260412-imx-v1-1-cc3b45d63811@gmail.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEyMDA5MSBTYWx0ZWRfX/F5NNuoPD3h/ Mogk+5cR4l07MSgzpEIi4qJgx8UAO+kLx6lfHmuu6hG/f8bCFe3QSE7MH6krH5lR7O/XYibvDne hb7gOAc/w1igiaEJo0SUiWaO/4Bbl+iZW83cEOwy09rnx+yadkzFRSJGbOFjbyfWnhPg1sGAKIt Ww3Wx99PTnQ+zd/+ycgdiMgI3wSyBkdFtkczruA2Fn+u7cR+E6dDsrdr+ftpX5sTyPiyrJHpVcP klBpTNPKE35CsdZfvDfrL9sr7Egei/Y0kYBjUPpNj4dN5ocjQ2b9dSbxlvkBMluVBDtyIEZ1/lH +3WQOfFfCW4QmCrx16p/Pihhws434y+DaJbHtWCvsMZRO10SgBeSx08NMZxS38ZoAVDeIrOnuQL yGZxyyxfwIqvE8SWZIX84VzMg1crimUFReFgUli96gyBqf1TOefbJnbM09nNOR9eUmaZAPiOvrk +0B/Tyd8vXD0xrTW25g== X-Proofpoint-GUID: 4WP2LS2Mw1vM1TDdXCMd7B4j1uB5LNes X-Authority-Analysis: v=2.4 cv=MqliLWae c=1 sm=1 tr=0 ts=69db6769 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EhLqWX2mNhMJiQ7EdO4A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: 4WP2LS2Mw1vM1TDdXCMd7B4j1uB5LNes X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-12_02,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604120091 On 4/12/26 02:58, Frank Li wrote: > On Sun, Apr 12, 2026 at 03:03:03AM +0800, Felix Gu wrote: >> If pm_runtime_resume_and_get() fails after the thermal zone has been >> registered, the probe error path cleans up runtime PM but skips >> thermal_zone_device_unregister(), leaking the thermal zone device. >> >> Move thermal_zone_device_unregister() into disable_runtime_pm so all > > Use devm_thermal_of_zone_register() to fix this problem +1