From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EBCE1F9A8B for ; Tue, 27 May 2025 07:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748329361; cv=none; b=JQ5d6+KJZVafQF06KME/+vGQeEROIryZth0sJ5FqO/F2YsCzM70oiBZllOBdjb1FKln8ltoMn581+2Ydcp0ESMd/PASwdpYa8HO2kiiimTmBrnuyotM4qJh6IZV09QRNVecK+1SVT5SgtY3sH+PZdITg/MoZ8sdnFjhOIkH7XO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748329361; c=relaxed/simple; bh=uerM567QcQCVqLcNbyZwn68Uozgpe9FXmx2lyhpHDvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lOz74JHhT/XpbE5fdCQ+tUEJZc+muEUKgg6DgV2u1xW6j5GKlgZYr0ARcXViHCVjCDjlqOcJWiLjvMjiJLLr8kXnsmVpLCAGb8UX3x/t+UB/uPcIF1D0Zq4/lgC0miv/wzcKEa5mxjS54LSAe2BhMi/i/y7qpBZu6x7tLzSyqG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Yi4dtCcf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yi4dtCcf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748329358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lPj65lDKBn8X+w6dITxUNDiVhmFCDqyup7L8wrKjKWs=; b=Yi4dtCcf+bzMTess/9cd0O1keZtHM/VSd5wGkglld6w41j+37osuioI1u1JYegBohXH+Tr MWhOIASd/ULT+e3Di4pDa7FAAEfMOTIL69v5ghtyUOgiOkG4kVW/TpbxgcwRDf8zwn8gJ+ 8XVZs0OUCuihB5n9uy0TxRDJgrJA1jo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-rg2SgysuNz-_wlNw9Xleag-1; Tue, 27 May 2025 03:02:34 -0400 X-MC-Unique: rg2SgysuNz-_wlNw9Xleag-1 X-Mimecast-MFC-AGG-ID: rg2SgysuNz-_wlNw9Xleag_1748329354 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4d51e563eso789091f8f.3 for ; Tue, 27 May 2025 00:02:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748329353; x=1748934153; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lPj65lDKBn8X+w6dITxUNDiVhmFCDqyup7L8wrKjKWs=; b=k9SlHrX9a6dGeOuA41UreLHrq6cqA8nGvsV5t4u+8KdARUz3dStsxqkKnG0Ii9OuNI 6fhYT8s0LATliFjDJ7PiiTl2iFBOkE/Ed6n5WsdnoQgfos2Fh/Z31qxXUNHl67+zvhVX ZeQg5dNFZ4Gjws4J80NDmQA60KrIKvPspTsm2CXmj4W81Khux0jDUvSEVJBQGv0yEtO9 5LZG3mM8Xve7iLMCqU8HpLeDOdCm1GSv4g/eU7Zm5I5OuBicR019wsVyVyQx6FA6p9Ls 5Mjt7aHn9PjGMMsvgPHq2Gyv2xDkzXqZ7AZDCO0qn70/LsOV/1yCs/JTk2m3Hv7c7bTq l5Ug== X-Forwarded-Encrypted: i=1; AJvYcCVXwfWMnCZggh/ctP4GTod/SQyQH7Eo43MT/qfRdw6bwEWaJ6SXn2g7o0Mgg3yUBIVIg/AFqaDzWOEIfpY=@vger.kernel.org X-Gm-Message-State: AOJu0YwAtVb/Yy2vIgJE4oyX1T3NE+KFJvb7zJ8YL8k7bQEe5Uf7zwz7 1KXH2s22OM7VmvBNNCJxDueMUzKEY2tBoj1jGj1ipjXU9XgbjEFFgy5g9XfKYXIh29eaU1RmtCE jiCicm+8NQSvzhgKEhnyesx1EXrVeMilzsrmyAcjBGJpiv4kXLElHW5WgS7gpYSxIfw== X-Gm-Gg: ASbGnctybPO53+RkmbYWy25tFT01XKW+Bv+eUI++oVGiri22lUYlhVG3AazHW1uyXpv +rpiUhZKz/LgMPMzOSgrB1G8wlHAebyc1GqlNPaaG+dFuolCc6LzBKEnnMHOBmAO4mzs/xKo+KY Hn89CEQrfHd7bl6tZjhP7YMhAybI9uAt60q6DpfZmWvuNFzIudJrYqUWDOtrNRk4kSMmPfr3w9w emZbQT+yGkUrsNrYXVDDZx63VUArRE0NU5DBLNNolt953tWJbjI/eJJOeVZRdLaEtB9j1z/dujo io5A26ZO/gPYQCmhLfds9/WkOmAwKQDIJNEP8dOjoAGSD24w2UJicLepn6I= X-Received: by 2002:a5d:5543:0:b0:3a4:cf66:efbb with SMTP id ffacd0b85a97d-3a4cf66f1f6mr7608615f8f.57.1748329353536; Tue, 27 May 2025 00:02:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGex5mHhM/OYaq2gRKUAD/HxHUJY3MptMrHBU8jm/eQhY8uxpjEvS25/QUCzUXZRuezIVGAwQ== X-Received: by 2002:a5d:5543:0:b0:3a4:cf66:efbb with SMTP id ffacd0b85a97d-3a4cf66f1f6mr7608571f8f.57.1748329353087; Tue, 27 May 2025 00:02:33 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2728:e810:827d:a191:aa5f:ba2f? ([2a0d:3344:2728:e810:827d:a191:aa5f:ba2f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4cc52ab88sm9930473f8f.11.2025.05.27.00.02.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 May 2025 00:02:32 -0700 (PDT) Message-ID: Date: Tue, 27 May 2025 09:02:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 8/8] net: core: Convert dev_set_mac_address_user() to use struct sockaddr_storage To: Kees Cook , Kuniyuki Iwashima Cc: Willem de Bruijn , Jason Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Stanislav Fomichev , Cosmin Ratiu , Vladimir Oltean , Florian Fainelli , Kory Maincent , Maxim Georgiev , netdev@vger.kernel.org, "Martin K. Petersen" , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Mike Christie , Max Gurtovoy , Maurizio Lombardi , Dmitry Bogdanov , Mingzhe Zou , Christophe Leroy , "Dr. David Alan Gilbert" , "Gustavo A. R. Silva" , Lei Yang , Ido Schimmel , Samuel Mendoza-Jonas , Paul Fertser , Alexander Aring , Stefan Schmidt , Miquel Raynal , Hayes Wang , Douglas Anderson , Grant Grundler , Jay Vosburgh , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jiri Pirko , Aleksander Jan Bajkowski , Philipp Hahn , Eric Biggers , Ard Biesheuvel , Al Viro , Ahmed Zaki , Alexander Lobakin , Xiao Liang , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-wpan@vger.kernel.org, linux-usb@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-hardening@vger.kernel.org References: <20250521204310.it.500-kees@kernel.org> <20250521204619.2301870-8-kees@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250521204619.2301870-8-kees@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/21/25 10:46 PM, Kees Cook wrote: > diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c > index fff13a8b48f1..616479e71466 100644 > --- a/net/core/dev_ioctl.c > +++ b/net/core/dev_ioctl.c > @@ -572,9 +572,11 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, void __user *data, > return dev_set_mtu(dev, ifr->ifr_mtu); > > case SIOCSIFHWADDR: > - if (dev->addr_len > sizeof(struct sockaddr)) > + if (dev->addr_len > sizeof(ifr->ifr_hwaddr)) > return -EINVAL; > - return dev_set_mac_address_user(dev, &ifr->ifr_hwaddr, NULL); > + return dev_set_mac_address_user(dev, > + (struct sockaddr_storage *)&ifr->ifr_hwaddr, > + NULL); Side note for a possible follow-up: the above pattern is repeated a couple of times: IMHO consolidating it into an helper would be nice. Also such helper could/should explicitly convert ifr->ifr_hwaddr to sockaddr_storage and avoid the cast. /P