From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762391AbdAJLph (ORCPT ); Tue, 10 Jan 2017 06:45:37 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:55840 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757979AbdAJLpe (ORCPT ); Tue, 10 Jan 2017 06:45:34 -0500 Subject: Re: [PATCH] scsi: remove useless acpi functions in the head file To: Hanjun Guo , , References: <1484036044-9514-1-git-send-email-guohanjun@huawei.com> CC: , , Hanjun Guo , From: John Garry Message-ID: Date: Tue, 10 Jan 2017 11:44:40 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1484036044-9514-1-git-send-email-guohanjun@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.181.152] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.5874C938.01C9,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 812d69f67937b9944d57acd22c2787b5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/01/2017 08:14, Hanjun Guo wrote: > From: Hanjun Guo > > commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support") > removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(), > but forgot to remove them in the head file, do it now. > > Signed-off-by: Hanjun Guo > --- > include/scsi/scsi.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h > index 8ec7c30..a1e1930 100644 > --- a/include/scsi/scsi.h > +++ b/include/scsi/scsi.h > @@ -29,16 +29,6 @@ enum scsi_timeouts { > */ > #define SCAN_WILD_CARD ~0 > > -#ifdef CONFIG_ACPI > -struct acpi_bus_type; > - > -extern int > -scsi_register_acpi_bus_type(struct acpi_bus_type *bus); > - > -extern void > -scsi_unregister_acpi_bus_type(struct acpi_bus_type *bus); > -#endif > - > /** scsi_status_is_good - check the status return. > * > * @status: the status passed up from the driver (including host and > Looks ok, Reviewed-by: John Garry