From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: quic_msavaliy@quicinc.com
Cc: alexandre.torgue@foss.st.com, broonie@kernel.org,
christophe.jaillet@wanadoo.fr, kernel-janitors@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
mcoquelin.stm32@gmail.com, patrice.chotard@foss.st.com
Subject: Re: [PATCH] spi: stm32-ospi: Fix an error handling path in stm32_ospi_probe()
Date: Fri, 18 Apr 2025 14:20:19 +0200 [thread overview]
Message-ID: <e148faa8-6ee0-45bd-8cd8-37ea42a1de2a@wanadoo.fr> (raw)
In-Reply-To: <72f49447-5c99-4028-90cf-3f5cc11e8b53@quicinc.com>
Le 18/04/2025 à 14:09, Mukesh Kumar Savaliya a écrit :
>
>
> On 4/18/2025 4:57 PM, Christophe JAILLET wrote:
> [...]
>> diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c
>> index 668022098b1e..9ec9823409cc 100644
>> --- a/drivers/spi/spi-stm32-ospi.c
>> +++ b/drivers/spi/spi-stm32-ospi.c
>> @@ -960,6 +960,10 @@ static int stm32_ospi_probe(struct
>> platform_device *pdev)
>> err_pm_enable:
>> pm_runtime_force_suspend(ospi->dev);
>> mutex_destroy(&ospi->lock);
>> + if (ospi->dma_chtx)
>> + dma_release_channel(ospi->dma_chtx);
> why can't you move to devm_dma_request_chan ? No need to cleanup.
Unless I miss something obvious, this function does not exist.
CJ
>> + if (ospi->dma_chrx)
>> + dma_release_channel(ospi->dma_chrx);
>> return ret;
>> }
>
>
>
next prev parent reply other threads:[~2025-04-18 12:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 11:27 Christophe JAILLET
2025-04-18 12:09 ` Mukesh Kumar Savaliya
2025-04-18 12:20 ` Christophe JAILLET [this message]
2025-04-18 13:16 ` Mukesh Kumar Savaliya
2025-04-22 6:39 ` Patrice CHOTARD
2025-04-23 11:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e148faa8-6ee0-45bd-8cd8-37ea42a1de2a@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=alexandre.torgue@foss.st.com \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=patrice.chotard@foss.st.com \
--cc=quic_msavaliy@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®