From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbdGSKyv (ORCPT ); Wed, 19 Jul 2017 06:54:51 -0400 Received: from lb1-smtp-cloud3.xs4all.net ([194.109.24.22]:51358 "EHLO lb1-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbdGSKyt (ORCPT ); Wed, 19 Jul 2017 06:54:49 -0400 Subject: Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver To: Todor Tomov , mchehab@kernel.org, hans.verkuil@cisco.com, javier@osg.samsung.com, s.nawrocki@samsung.com, sakari.ailus@iki.fi, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <1500287629-23703-1-git-send-email-todor.tomov@linaro.org> From: Hans Verkuil Message-ID: Date: Wed, 19 Jul 2017 12:54:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1500287629-23703-1-git-send-email-todor.tomov@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/07/17 12:33, Todor Tomov wrote: > This patchset adds basic support for the Qualcomm Camera Subsystem found > on Qualcomm MSM8916 and APQ8016 processors. > > The driver implements V4L2, Media controller and V4L2 subdev interfaces. > Camera sensor using V4L2 subdev interface in the kernel is supported. > > The driver is implemented using as a reference the Qualcomm Camera > Subsystem driver for Android as found in Code Aurora [1]. > > The driver is tested on Dragonboard 410C (APQ8016) with one and two > OV5645 camera sensors. media-ctl [2] and yavta [3] applications were > used for testing. Also Gstreamer 1.10.4 with v4l2src plugin is supported. > > More information is present in the document added by the third patch. OK, so this looks pretty good. I have one comment for patch 12/23, and the dt-bindings need to be acked. I suggest you make a v3.1 for patch 12/23 and then I'll wait for the binding ack. Once that's in (and there are no other comments) I will merge this. Regards, Hans