mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, jbrunet@baylibre.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
	carlo@caione.org, khilman@baylibre.com, peppe.cavallaro@st.com,
	alexandre.torgue@st.com, martin.blumenstingl@googlemail.com,
	neolynx@gmail.com, andrew@lunn.ch, narmstrong@baylibre.com,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue
Date: Tue, 29 Nov 2016 16:43:20 -0800	[thread overview]
Message-ID: <e14a3b0c-dc34-be14-48b3-518a0ad0c080@gmail.com> (raw)
In-Reply-To: <20161129.193853.827524417068912706.davem@davemloft.net>

On 11/29/2016 04:38 PM, David Miller wrote:
> From: Jerome Brunet <jbrunet@baylibre.com>
> Date: Mon, 28 Nov 2016 10:46:45 +0100
> 
>> This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F).
>> The platform seems to enter LPI on the Rx path too often while performing
>> relatively high TX transfer. This eventually break the link (both Tx and
>> Rx), and require to bring the interface down and up again to get the Rx
>> path working again.
>>
>> The root cause of this issue is not fully understood yet but disabling EEE
>> advertisement on the PHY prevent this feature to be negotiated.
>> With this change, the link is stable and reliable, with the expected
>> throughput performance.
>>
>> The patchset adds options in the generic phy driver to disable EEE
>> advertisement, through device tree. The way it is done is very similar
>> to the handling of the max-speed property.
> 
> Patches 1-3 applied to net-next, thanks.

Meh, there was a v4 submitted shortly after, and I objected to the whole
idea of using that kind of Device Tree properties to disable EEE, we can
send reverts though..
-- 
Florian

  reply	other threads:[~2016-11-30  0:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28  9:46 Jerome Brunet
2016-11-28  9:46 ` [PATCH net-next v3 1/4] net: phy: add an option to disable EEE advertisement Jerome Brunet
2016-11-28 10:28   ` Yegor Yefremov
2016-11-28 12:20   ` Andreas Färber
2016-11-28  9:46 ` [PATCH net-next v3 2/4] dt-bindings: net: add EEE capability constants Jerome Brunet
2016-11-28 10:28   ` Yegor Yefremov
2016-11-28 12:21   ` Andreas Färber
2016-11-28  9:46 ` [PATCH net-next v3 3/4] dt: bindings: add ethernet phy eee-broken-modes option documentation Jerome Brunet
2016-11-28 12:22   ` Andreas Färber
2016-11-28  9:46 ` [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable advertisement EEE for GbE Jerome Brunet
2016-11-28 12:31   ` Andreas Färber
2016-11-28 12:40     ` Jerome Brunet
2016-11-28 13:42 ` [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Neil Armstrong
2016-11-30  0:38 ` David Miller
2016-11-30  0:43   ` Florian Fainelli [this message]
2016-11-30  1:13     ` David Miller
2016-11-30  1:15       ` Florian Fainelli
2016-12-18 13:37         ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e14a3b0c-dc34-be14-48b3-518a0ad0c080@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=alexandre.torgue@st.com \
    --cc=andrew@lunn.ch \
    --cc=carlo@caione.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=neolynx@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®