From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 276AD224885 for ; Thu, 20 Mar 2025 10:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742467887; cv=none; b=Y3NYCa/nmUq6qbJ84WqusWuIhF5g2llcnb80KWPAlW0caQWpLh0zwlOEHD0//tgLieO4I263JzAVaNU+soSs6Xc7aFLWEMut10Mc40Oxr/qFhKhHSt2nVey+5LhzJpmx+NANn+5EyoZ7P9JlUDqoCjPbVFKeHLtoNEyYFWikWD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742467887; c=relaxed/simple; bh=L1U+bcSW7YBmAkqow20Q/7C4mb141BejkLwPN0H1D8w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mprpSNW502df6bKOf/1+7kjcteDxLbfYjCiWX3QVPImhjnNc5mLLTuJ4hMHUOFXk8JGSsMntTdG9BJz3QBmA5tJCF/iBmJi33dcKm6UGhFRPxWXlTicB/ZFM5fKlggh82LE/RtOj9ugUCizjtxkyswhnOAZXKtgLpZr8jSI1RFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CUA56aLu; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CUA56aLu" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43d0618746bso3927715e9.2 for ; Thu, 20 Mar 2025 03:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742467884; x=1743072684; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kKb0bPBVVY6/KTAskiDvg6ejT22LGD+C1zdwso8I9VI=; b=CUA56aLuBpZFj0k+V9oJWMoj375kPA0vDUBw0Mo/aPm228+mwu74FL/xXIUqk6pZsW BSKZLFKMR4mF07QT/P4B6ctNop0lvj8W7yp3CImsxC298B+t8OMbIoVxcgqk8nd7MeQU 3NUGGwsPF4shPPvnxWyIr5IFT+2yx+MGLfSSHOIkBKxc4XzdUwSv0n7QFEHkaAgw6dgF dN2Db2FMJpUez/HF1QPVun6l+s7w0+SFCGKihy3b+vadaYxD8/wRN6NuagHGgHSJAtxT TGwTcXZS7QxOOVzPEOY+b58aehoQtEgK//diul/LGtNNRVDyuNTvTTNLh9ypvDDYT6A+ i0mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742467884; x=1743072684; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kKb0bPBVVY6/KTAskiDvg6ejT22LGD+C1zdwso8I9VI=; b=fQpOgbeac1cieDHw0FdgEEyrukNrB+nhOw4XLcXWDsveCMuUK883byQmsBuoW346aZ M6EyBzYUZAsjgO/N80V6Ezd1R/F4mqRPdoNLr2FZnP3A9zumJfpX2KPsMmEuHU/HsmeA gTqL1QewUhLoc0efMGvxjA4O8rptpOIVlWW9sUqVIM2ANfk93ItZkSV14w6HNhTc2Mlm GnAm9RjHae/otp+XLe4Jb4MWh9YK2LEDSWJMDjSKLf/46V7iMxc10XPqXuKs1zB+3Z1G HxVpX8lIDMWC/w2O/xgwPq/I6o7P1onz1UMVYoqkse5Lb4XuWSV7dnj7CuU5BzraZ+cy y6TA== X-Forwarded-Encrypted: i=1; AJvYcCVmvk4yD07Bf1wUfCDk7ted4Qfym007ZqgXIOiprJMC4bfo3gFRgM6fbqQBcoE8KEf6n6fzDmAAz8XSaQc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy98haW0KpqZkeEq8wTQTNudgERZ1ZFjV6C/nLTGuSYwdqCWzyD 0GXKu2EluwI57IaJBIT1FPHokOTJewt1+HHSXY1RCHOiSnWqUOyYpnsxl7b04lc= X-Gm-Gg: ASbGncuROTSBrNhzXPppQdbVe9LBxf+/u3dnIDAGUlPNbrxsWeZ3Z6vos5RA7UIaXKz iCibKVYIHHPMfrtqtlC7+264HVWFuIEtupdW3b4uVGkY82sdl6CcHPaH2A12ySRBqJpeN1gQC9H qOFxWLEqc1O1sXJGqHNRZztkuuGUBOPND+SqqX/HOzdQc/i8OcR2KJKiKSPAYCzWf7B3l6wUVT0 DS0r+srqElR/QtgAi9TjxNKxtPMzJ5RG4SVDxBCiaNzZLHrpA/fRTR6Kdbrj6Lc9X5Idkh5DBls H7eLiTfczNRDoGCn8/I5pPqX3o89GajkvGeePtQ/xItjcZEEsnP54NGiRWifsgN4JpgNhNZ6ag= = X-Google-Smtp-Source: AGHT+IF5aG2ScR9F02Ij63Lszxbdolrxhc9/khSjeWGnACxp6gXIdgu3JK1Wfic3Xr2VhHMhTlyaIg== X-Received: by 2002:a05:600c:3556:b0:43c:eea9:f45d with SMTP id 5b1f17b1804b1-43d437c2dc4mr56164285e9.18.1742467884219; Thu, 20 Mar 2025 03:51:24 -0700 (PDT) Received: from [192.168.68.117] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-43d440ed793sm44630255e9.39.2025.03.20.03.51.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Mar 2025 03:51:23 -0700 (PDT) Message-ID: Date: Thu, 20 Mar 2025 10:51:23 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] ASoC: dt-bindings: wcd93xx: add bindings for audio switch controlling hp To: Krzysztof Kozlowski Cc: Mark Brown , Dmitry Baryshkov , andersson@kernel.org, lgirdwood@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org, perex@perex.cz, tiwai@suse.com, dmitry.baryshkov@linaro.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org References: <20250319091637.4505-1-srinivas.kandagatla@linaro.org> <20250319091637.4505-2-srinivas.kandagatla@linaro.org> <4ie22uuz5tpg77jto3c3hec6lhonr44hrjda7jk655axlaxvba@u3atd4gcyghn> <660115f1-d1fb-4fd7-a453-e8c177be9eed@linaro.org> <51dd7cb2-0c22-4043-b3a1-fa8410903cbd@sirena.org.uk> <938cb09f-3fb1-4daf-802d-2d95222f30db@linaro.org> <20250320-feathered-super-walrus-8eeef8@krzk-bin> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20250320-feathered-super-walrus-8eeef8@krzk-bin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/03/2025 09:31, Krzysztof Kozlowski wrote: > On Wed, Mar 19, 2025 at 06:00:51PM +0000, Srinivas Kandagatla wrote: >> >> >> On 19/03/2025 16:03, Mark Brown wrote: >>> On Wed, Mar 19, 2025 at 03:59:23PM +0000, Srinivas Kandagatla wrote: >>>> On 19/03/2025 10:01, Dmitry Baryshkov wrote: >>> >>>>> Is this regulator supplying the codec or some external component? In the >>>>> latter case it's likely that it should not be a part of WCD bindings. >>> >>>> This is regulator powering a mux that is driven by gpio which is part of >>>> codec binding. So I would assume this will fall into the codec. >>> >>>> Where would we fit this if not part of codec? >>> >>>> Unless we mark this regulator as always on. >>> >>> I would expect that the mux would appear in the DT and consume both the >>> GPIO and the regulator. >> Yes, its doable, so we would endup with a mux driver consuming regulator and >> gpio and move the gpio handling in codec to move to use mux control. >> >> Let met try that and see how it looks like. > > Looking at schematics this is clearly not a supply of a codec, but as > Dmitry said, separate switch. Actually two switches. AFAIU, Adding single mux for both seems to be the best option. Eventhough physically they are two muxes but they can not be driven independently, and logically/functionally they are doing only one thing of handing us/euro headset. But if we represent these two muxes as two different nodes then the driver is messed up, as all the resources (gpios. pinctrls, regultors) will be shared and we can not control them independently. thanks, Srini > > Best regards, > Krzysztof >