From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAB4B3D1705 for ; Thu, 11 Jun 2026 10:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781174943; cv=none; b=gRirMw6IG9LW7OQ7ERcpu7tJnOG/HPmnQDXxVCSr6gVR8n82GV728LO5CwvRAL17BW/nOUNkYzUxpIqdhBDP4yb5Ew4FsYysHeWlvqLbkOjLcVjF3JvA+QDGWzj/iYNfX+v7kNMzMB4AJRU3OfhhOb0PdGVKxd8kExE4DYPflHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781174943; c=relaxed/simple; bh=GBkrhv7d64W4h/1OBsfcnntVKPA+JRwLwnMW6tdFuKw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ic35gx++ip+9cq4RJdOvCd6wMNFToQ4RSaxd5Qzn+QmL3W9s+F5uoDESrBsg/sCPkXQGp+8bTJWcn/InCb61MMc9vP3jwFfzNKh2Y84/iTdm1wrDiJ8gLYcR/ZKQbSdJDHgxv/2LTomGEBAq37bR+8xd3S3Q0HzsMjggkkrr/cA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=msT64OzS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LxdeMk8s; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="msT64OzS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LxdeMk8s" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65B9xHXk284107 for ; Thu, 11 Jun 2026 10:49:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R2oeESidr35zR0i0LnOjUC2aTb3T+iA/MYAO/hg3kcg=; b=msT64OzS7I+w5IY/ /a5HZvJ1DfrwjTpEs5aY8myJ+YeHesMzS1Y2kTZCPSle+AId92xhvDYwIElnp32G NDUBjOLDHA47My87sQ90+y/3guPAdq5g1ogTfFlNGw89BZXxAFMINqUg5kJ9VDGy wydLpadhqBLZTIQECp7WcmLn0BRuczYBCQiG63HRxTzv+v2ThYOAyPJndaQJ2lvO MEeyMg/NtAUNsGHfDks5ycbPK5Ww7JXX1yc8VV/r4luCU/9EgwKanILj1UshsFmK ptpL+4tRADcHpmZhS+9RViD+ifdr3qUV1d5ebDRqPAzGjOQBizHo4LpTaU5gzw9O AMwOjQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe6tk1qj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 10:49:01 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5178ac43d27so21876021cf.0 for ; Thu, 11 Jun 2026 03:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781174940; x=1781779740; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R2oeESidr35zR0i0LnOjUC2aTb3T+iA/MYAO/hg3kcg=; b=LxdeMk8sBasjJCayDRHJbcbSq51xAHPjpBGncgLs55EtJUVfGvFjFTjqwDifyCjB0j e7EWqat/SrSvju7EotZtaCEIMX4VOuVzbto/TVQK8s4vlkH2rsqOYUMmjVNNh3T6q87B z0iRYUIYd1QRu7bl4lm2HVGkAMvdNQXhy0MnKfFGvq0aT+0alh4iF4Z712Qa1Yfvzl2H gXdf2AAZ9GULHTWsOvc6G7NZPMf20NdwDDszdhjYTSZjyini4iIlqCuNEGfU1dnh22x4 DGgywFqJ905YzgQ1M+7I0sFII57sd3lh01MuZ10XU+D45nOGYd3wbgspXy3PeoF0if9c CwZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781174940; x=1781779740; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R2oeESidr35zR0i0LnOjUC2aTb3T+iA/MYAO/hg3kcg=; b=rTJePZ52/IBGpplWrEuNulbVQDBAl4VD7LR6Y/+2z0P4VqB/D5iv4+p06+eRj5aoBn bmt4svUBcS5BAwFfAy/EWRukYM+mpV2JaUuAMHYKWfnXRJ9muYoyyAKGxY8LyL0xSwJB n6qVqSEOM1GEW5G+W+fiOuUq6i0+R+HL7aYzERVWBN1r+sABSRzc0uYnQP40Ra/ohceW oKGdraSXKuDf1jOZ+BUD5aTD7eBpnaS2S6Ljn7ZDH1w04cidePlRDLv4/tCIBQ9eY11V a5JVq/9cBQh4UmHEHpm8+G0+yYPPt8xusUkLFltH+eedFEg0bk+Wjm4JqNsL3MsSf7g5 +qqA== X-Forwarded-Encrypted: i=1; AFNElJ/QIHgm0HznRKBrap4kpqYJQIna29IczwdLpBNZRVzYeB6KegJYhe6Njmsm/d2egxp/c+Gfp7d4mAgEpss=@vger.kernel.org X-Gm-Message-State: AOJu0YzKEtmUBCVAW2QC30eO2b/hA568SepBsU3An7v531zZrpgyIEDW 3O7TPep8rKGKMM+/at0SYPvuVPcHsYKe/EBWWGA22Kg9CMjQ6+4E50rNp9PLFdtpxb1aDkCeV3K 4FxBqZKMxpA2S6EYDLCTTpjqsveXXYnBpoA9fbL1WFW3l24p3v7hCrfnWo0qnjxo49RA= X-Gm-Gg: Acq92OHxBDXwMMzsOqkwtATW3AwLh+lR3C/2ywy4kG5sJTwm40M/Yyom9UaptG9Um87 CBEW3RiJEqeShZ6IdR2Ubcxcqd0NJ65u+MbeieixcfHzbsDZDPrwv/UrV8znL//v8b6CYBtsson uUcRFmOHB+KoiRhDG4Ll/uh8z7+XL3AQZimA+svhaSLjU7rpxrHjA/7vdvQ55gaPG1Vv/pHMCc/ 1x3LDzfqh7fL2OO90VwgYE5DtEtjWh4SO5QeP31+BS+jo1Umi45kzGBFgIBwXVOphnPodC7n8Uc eJB5ZBhv6yAmawMfaoS9auMk9xZlEVIqY6AmnNEJNAs77qkd048sQLB+NsuEYQv8lkAua7t1h34 DSH5ik4SLIiXqqipJSg3t/TW8R9TnknONikyHdACs7gqNSrOhnre+wDuZ X-Received: by 2002:a05:622a:4813:b0:517:5e32:f3c2 with SMTP id d75a77b69052e-517edcd94cdmr21330541cf.1.1781174940209; Thu, 11 Jun 2026 03:49:00 -0700 (PDT) X-Received: by 2002:a05:622a:4813:b0:517:5e32:f3c2 with SMTP id d75a77b69052e-517edcd94cdmr21330251cf.1.1781174939813; Thu, 11 Jun 2026 03:48:59 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfcb6785ee3sm48945666b.58.2026.06.11.03.48.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 03:48:59 -0700 (PDT) Message-ID: Date: Thu, 11 Jun 2026 12:48:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] irqchip/qcom-pdc: restructure version support To: Maulik Shah , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Sneh Mankad References: <20260526-hamoa_pdc-v2-0-f6857af1ce91@oss.qualcomm.com> <20260526-hamoa_pdc-v2-1-f6857af1ce91@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260526-hamoa_pdc-v2-1-f6857af1ce91@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDEwOCBTYWx0ZWRfX6A8Fsf16AyFw 7F7GtAKITQka/kGizyUbhrbItBjbaXvrGModm81BNWKovc4JwZuh2bSiapYR0DHMYGyq3rRseAB tUpITr8yUMGxocWkefcCWyBkC80DEtOAgHAzuWAUx3Ec58PtU7EyTpew2ueJ64B/v1NjW3IOpfn IhSZOjF6bki5n6je7ITH6Zqs3M/GeNa1RR6i1HkTwyPP2zbO98WGX0dlCx9Zh2coqrIZAmR59+V +HQejkYC7EtzkqGXrHdWXRYcestVLZqZX/y4wn27CfYUa0TrVQXUyMj11Dh+F6IVTk8vnVAkPWb 1BquPparVoXFLZwwnBXvJjVLUYVbCVRmzGlp896xMhGYvP8jauSDpxI08045kgfM58dEPd6mFtS QiTSqAg/EK+phQ7SWsg8jBS7pPMZDPD6Lb2h2U3Z4yTy7fB169qWwJ3wcAUDvjkC6HjO+O+oshQ PwvJ/2brV7EYdBRYv5w== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDEwOCBTYWx0ZWRfXzNvqKk1facH6 8keCD42+P/D0eqlnXjf5kFqBjZWIZRwqwy1Hy9VdGFiI4rJmAJ2MqnoCpZQkfWKlPpy7A0bPYpJ 1ZscUQAZ5IavLSF2BPqELcQG5LfvFk4= X-Authority-Analysis: v=2.4 cv=AaiB2XXG c=1 sm=1 tr=0 ts=6a2a929d cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=OlIdmLjaEo8V13lRhzgA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: HHzBegI2Gx7DhDliBojZM9t9cvEa88Pr X-Proofpoint-GUID: HHzBegI2Gx7DhDliBojZM9t9cvEa88Pr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110108 On 5/26/26 12:54 PM, Maulik Shah wrote: > PDC irqchip updates IRQ_ENABLE and IRQ_CFG and for three different > versions v2.7, v3.0 and v3.2. These registers are organized in H/W > as below on various SoCs. [...] > +static const struct pdc_cfg pdc_cfg_v3_2 = { > + .irq_enable = GENMASK(3, 3), BIT(3) [...] > + pdc->base = ioremap(res.start, res_size); Can we use devm_ioremap() here? [...] > if (of_device_is_compatible(node, "qcom,x1e80100-pdc")) { > - pdc_prev_base = ioremap(res.start - PDC_DRV_SIZE, IRQ_ENABLE_BANK_MAX); > - if (!pdc_prev_base) { > + pdc->prev_base = ioremap(res.start - PDC_DRV_SIZE, > + pdc->regs->irq_en_reg + IRQ_ENABLE_BANK_MAX); likewise Konrad