From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 971F11AD3FD for ; Wed, 31 Jul 2024 16:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722444557; cv=none; b=cttxToNBDe9cHkFu3iBZPUuR3bk1JXhJ+Vi500BNNrm7PW9NYkYnBiKxZpNME7kZVvRiy2o7zndwt72Pw8qyLgpxn3Yzvi+ZgiampnBMn/Utk+6fjm81sv+I3VxuGAqZNe2Lr2ddykgtRIuQJ3t2bjJgwwNwSEd3jMBhV+iho5Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722444557; c=relaxed/simple; bh=vIgPYTY/ATG6dVRk9yyFG0fpmnnN1RIECDKQLxtV1LM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QLIvZyI/krDAjHnsCPdDrbn90+PUylDTS64MXxjYqryys1rPiudLQAmAglULL9SbJ/DN+nMSGJTwr/oqxvWYtIPrAdKT7jxDHjUoRPGdKvSbDFOxAEVId28jydyGNNjYZXnk619U2BLp8W5I+23YWAu1VAjJY1DOedDiw0Fj7T8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UeCwLE6d; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UeCwLE6d" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-70d28023accso4533502b3a.0 for ; Wed, 31 Jul 2024 09:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722444555; x=1723049355; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=v3tHZSVh1zalLsmMr1S88H2jiHIf6ekYi55+kBLD0Hg=; b=UeCwLE6dtLk3EPZ0VsiDPp5sp4vFF+BUT+0h91LJXK+7F56zZNCUwTloeaJQjXlo7X 16KWxl8f1LBQXJnRb+NWzDmzTBUAaf/5UGSEuNZqF5QI571V1WK2vqzIO9OPRmuoPNEA 2+lK56ScaAJww+PgtNHmDuGs5Lpj+NCJarqWU5DtfN1GWcxKXuTo+qKrS/u9tu0RBc6v Y3LSplIe1QtIw5aq6cTKf3mZFzpytqaOC8H9PS0XFBkg3QRtXalKFokkqMHPbCJgcgeD p+LiM+Y0SHa9ucxUApGTxQOH018GNeeXQPsSsgwo/bbTN4Jvb5ozKf1P6zszmU0DcyZ4 0rXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722444555; x=1723049355; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v3tHZSVh1zalLsmMr1S88H2jiHIf6ekYi55+kBLD0Hg=; b=hgSMQpX7dlXivdTukzJrLLvPQWsVvOYCtgEeXm+oBO29L/u0k/TJ08AKZicGzDM0oa YHNoOSFaSiaDwtgtZKYwtLdwlapu+IcGvuH1yCNc1MfX06zPY3r7vwPQj0HHQ8bkGBnt XDspWCC4SqiaYd8M2nE8XfLDuLbmvlXd3iRjYWRJKXFZw5dO4lS+KQK4kLK0RPv625q1 PoHewE27x3flYJ+qiIykzXV9Y0KaDKA/OT+KgWTdVjoebRWafJTxsFuPrkoHUeomundp AKswHRaLibBbEy3ERb6E9e19K9Dyl2tjatGtA4TDIjFZySvrX6UumCdKxGpqsT/d6bWS S8tg== X-Forwarded-Encrypted: i=1; AJvYcCVRN/A19wy5XTJ9xZg4IUlO7drHEwf2NaGsat0itzIpsoCxLHKWiZ83kjGeofiY8dsr5aIbYPLb6//7k4BgUG6Z9d6/KcU6XqROvh8m X-Gm-Message-State: AOJu0YxZiuoUGFl2+PmraGiia23E37UJqu13DUca2TFcql9SXol9w7Wk fYlY+kayx+gumO4VlTdqwCZvz7KXg+NXiM0gfAPGE6fziU0ah87wn/EfCA== X-Google-Smtp-Source: AGHT+IFml1MY9k5R9lQFYUaFTYKrD8FYyzZdq1b7j+G/eRAbNnvB7sJZyKX+J55/ix4iegOQjx1KSw== X-Received: by 2002:a05:6a00:14c4:b0:70d:3916:8515 with SMTP id d2e1a72fcca58-70ece9fc25emr14431991b3a.2.1722444554758; Wed, 31 Jul 2024 09:49:14 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead51abc4sm10191770b3a.0.2024.07.31.09.49.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 09:49:14 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Wed, 31 Jul 2024 09:49:12 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Linux 6.11-rc1 To: Linus Torvalds , Peter Zijlstra Cc: Thomas Gleixner , Jens Axboe , Andy Lutomirski , Ingo Molnar , Peter Anvin , Linux Kernel Mailing List , the arch/x86 maintainers References: <20240730192237.GR33588@noisy.programming.kicks-ass.net> <231e7a2e-7e2e-4b82-b084-8943b2236de0@kernel.dk> <20240730193841.GS33588@noisy.programming.kicks-ass.net> <20240731122002.GE33588@noisy.programming.kicks-ass.net> <87mslx67dm.ffs@tglx> <20240731155551.GF33588@noisy.programming.kicks-ass.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/31/24 09:17, Linus Torvalds wrote: > On Wed, 31 Jul 2024 at 08:55, Peter Zijlstra wrote: >> >> Right, so Thomas found that i386-pti fails to map the entire entry text. >> Specifically pti_clone_pgtable() hard relies -- and does not verify -- >> that the start address is aligned to the given granularity. >> >> Now, i386 does not align __entry_text_start, and so the termination >> condition goes sideways and pte_clone_entry() does not always work right >> and it becomes a games of code layout roulette. > > Lovely. > >> Also, should we just kill PTI on 32bit perhaps? > > I don't think there's much technical reason to keep it - I can't > imagine any security-conscious people actually use 32-bit x86 any more > - but apart from fixing this bug I wonder how much of a maintenance > burden it is? I think most of the code is shared with 64-bit, isn't > it? The 32-bit case in many ways is simpler, even if it happened to > hit this odd alignment issue because it's obviously also a lot less > tested. > > I'd rather kill highmem and X86_PAE, but I also suspect that horror > has a much larger chance of still being used. > I guess there is at least one user - me with my annoying boot tests ;-). But seriously the question is: How likely is it for that code to find potential problems in the 64-bit code ? pti_clone_pgtable() doesn't seem to be 32-bit specific. Guenter