mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: Pin-yen Lin <treapking@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Revert "arm64: dts: mediatek: mt8173-elm: Move display to ps8640 auxiliary bus"
Date: Wed, 15 Mar 2023 11:34:16 +0100	[thread overview]
Message-ID: <e15eac65-94d4-6a70-cab1-4fdb550116f7@collabora.com> (raw)
In-Reply-To: <20230315041107.2886940-1-treapking@chromium.org>

Il 15/03/23 05:11, Pin-yen Lin ha scritto:
> This reverts commit c2d94f72140a28d0f516b7c5e8274a9c185a04ff.
> 
> The `lg_lp120up1_mode` defined in panel-edp.c is not working for some
> panels used on elm/hana devices. Move the panel node out of the aux-bus
> subnode so the driver only uses the modes retrieved from the EDID.
> 
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> 

This commit was sent to fix display functionality on MT8173-Elm (Acer Chromebook
R13).... apparently this should get fixed with [1].

Investigating if this is the case.

Regards,
Angelo

[1]: 
https://patchwork.kernel.org/project/dri-devel/patch/20230315035508.2874915-1-treapking@chromium.org/

> ---
> 
>   arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++-----------
>   1 file changed, 12 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index d452cab28c67..d45a2aeb0eb1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -90,6 +90,18 @@ switch-volume-up {
>   		};
>   	};
>   
> +	panel: panel {
> +		compatible = "lg,lp120up1";
> +		power-supply = <&panel_fixed_3v3>;
> +		backlight = <&backlight>;
> +
> +		port {
> +			panel_in: endpoint {
> +				remote-endpoint = <&ps8640_out>;
> +			};
> +		};
> +	};
> +
>   	panel_fixed_3v3: regulator1 {
>   		compatible = "regulator-fixed";
>   		regulator-name = "PANEL_3V3";
> @@ -282,20 +294,6 @@ ps8640_out: endpoint {
>   				};
>   			};
>   		};
> -
> -		aux-bus {
> -			panel: panel {
> -				compatible = "lg,lp120up1";
> -				power-supply = <&panel_fixed_3v3>;
> -				backlight = <&backlight>;
> -
> -				port {
> -					panel_in: endpoint {
> -						remote-endpoint = <&ps8640_out>;
> -					};
> -				};
> -			};
> -		};
>   	};
>   };
>   


  reply	other threads:[~2023-03-15 10:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15  4:11 Pin-yen Lin
2023-03-15 10:34 ` AngeloGioacchino Del Regno [this message]
2023-04-21  9:44   ` Pin-yen Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e15eac65-94d4-6a70-cab1-4fdb550116f7@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=treapking@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®