From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E0D036897E for ; Tue, 10 Mar 2026 11:47:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773143248; cv=none; b=mcXmr9WoqcUsuuJoG62E7qTAU05O8BQezkccY6JZxZMjhKFnNtgW5Tbfqwqw7v3w4ks7eWq0kbmc2OLDz3ZaSHRFX9Xr4eVO89SLm2mAq6ZnXgDfRxwsR27CPieaiWQf8rEIagGFP+KI0BRG7s8nWUBI5H3GFNtBjDBGX1jw1NM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773143248; c=relaxed/simple; bh=3TzIzozpkkcPshRim4uY3bWDxbMPNuyIhaHT6FqqG8c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NokfwsOh+Jhg+SIX90OsWzrnPXAxMibjOv9R0rbCCC9MKaC7or6wx8ziLKJ6CHKFplyu5cmQNJMf0q0rmVB/6nKsonzejnAV296EXjEdTnFk7IBA8auShTj3LOjJ4JgM9hx96OMBhphD7bUyAPH3kzD3BEgJfq+aMTqw6kDn1jI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CUseJ1yB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=i9MqFv1x; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CUseJ1yB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="i9MqFv1x" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A8tmud3754749 for ; Tue, 10 Mar 2026 11:47:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fLjziEkCWvVYAwCSbEhEhM5xOOiTSe9RlV+ZJVYKifA=; b=CUseJ1yByI5+Aoey LjcA5dfs2eht1ShkEXB+Uac+WWZaO/p03r538dllkERYLmwmnB8iQ+x/bNhiUAL3 FLgKg/y7/IeFRoiSRC22X1SMWIvKTVy18v7PSIsY1GXFum69Nl4cFqEaO1Mp/tHh T0+jCpfhxV1ZUtbptrqmuCLbEttXAFz8XW/b+sIjrd7kk4/wPSVkW+GaIIZZ9ybl QYhf946WZlv1q/3U2ejfGh5ocVmeM8F8Rly49lXM7C6oWMkP6h1pDMx1fUjhslpX KwMpoZEwUHhgN2jDwXr2C+rjkJfvZL+/bMJUj3ehDQc8gZxczj/FYqj3WTNjcRYg KsZBRw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct477k0vy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 11:47:26 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-89a086578c5so53525286d6.3 for ; Tue, 10 Mar 2026 04:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773143246; x=1773748046; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fLjziEkCWvVYAwCSbEhEhM5xOOiTSe9RlV+ZJVYKifA=; b=i9MqFv1xBipG1sLv5ljvXxNCwGPdEf2ZteFVnk3aBO2Qhc2qcMBgo4sNG8IV39cAES AZFuDzrfSn7v31qbXhCJqTioFnupNZBlE2ry8qBArEB0nXvHsdY7d7KF83YbrnKoEjtC 46BCIr7L0Hr7qhrlsZcIq/Im2USnWNC8dZx/0kZGsaVz6TH1ZlnZox0WGLZGV8A3vnYz jR2H0Hxy2/GyAzOZJb0xe5rhEvNeQHMa+DCXVVXf9DdGiHNAxbovSyUyUp378A9dEkup oWqzbHItny7QWVzY+cpv9ZPpjWGTZ5XAiWq4aryygAHywFhVl7xEbGB0XZ6MnOa2FkvH GsxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773143246; x=1773748046; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fLjziEkCWvVYAwCSbEhEhM5xOOiTSe9RlV+ZJVYKifA=; b=P8CmZscQKCvd3Q6LhIFW28cPMLlV6XCRnRTFjh0Qj83zjh7jPpFM/pqHGBXDuAg11B Dl1eMMi0evSr6nV2gAz2FIen6FOWy4czVPGlFBCOBq3yzHMPWzmWST7xwTinfAYLT1NI 9MRsLHIs85zhYSq+KYd4iLF5vysXG6UnsJjlrWdhfc+LOCCGKeD1CKrObEXLPW42LNIx /MqBs+HOOrQgFSc1YgQNIRUjmW0pKLuP2asPcO2eYKp/eeJeW/6HuhmLc5csu/COx1Al A/mrbNnUgU8fjSlfSGsSgIkfXzz09qB8/ecCXh3sdJ+L9naFFwpinBc7i7BhHXEF6QWR 2poQ== X-Forwarded-Encrypted: i=1; AJvYcCWXF0qrrXEjp3InGAiry443wRjn7UD5OWOBNQzwOfZ1BvlhxSPVVKXTUlTgt+wjtFhPY6V2VkO1Epwa2jg=@vger.kernel.org X-Gm-Message-State: AOJu0YwmlCI1EtMCCKXud9E+54hLHu+NveoI1Ao7tFtm1PF+HvVfYFFx agXCD1///ot8GqMZF7XkLw/j/NeABSX2vKw2g1UKsyLYwhZdAk88xuLPiYDC33jVPCtrGr0KiE4 bBe9NcdMG6bx4LBBsvfmZO8gICsCt8JOGSTIUZM6cJBNIzOVt74fmj/U21++GJVpe+AQ= X-Gm-Gg: ATEYQzwxgDvtROq+pm/sXdntj15KSqU6slSuHdq59/hzDuRQyhzPT9LRX72V9y6n0g1 6z6qqiLTxLuWkyCeOppK1yqr6TWSRjz0/qfwparEAhGZBYFzeFs6BPbbxVJz8w8Gd4jnWiAIpWs HE58LOyVQBDvpm1HHcQUqmoCUrCSyJsmG6RIv8svExjgopkqNQOcO8Vo9uKuTYOkNsNQ8+MRp0M NS+opD2ToNu2mgdq9RCmnD/JJnRj6H8UWS+h5kk2HWoUu/CfGCBBUU3XIIgj+zX8sbu1m/Kc5wn VGRKvYRmYTWwlgfGswDvjZy+GKzzlhtun+F93ik08q1k/GTlKyNpQ+HVPjqx3IDQEKkyiMA4TMb otYLnvaBgoX4q5JiaqpjAg7J8ud7OL3C7IZebEVSdYSAWcf7aL/q6lGVG44oqu3wiTsTW0K7K0d uJ0eQ= X-Received: by 2002:a05:6214:8017:b0:89a:6263:feb6 with SMTP id 6a1803df08f44-89a626406c4mr2042126d6.4.1773143246031; Tue, 10 Mar 2026 04:47:26 -0700 (PDT) X-Received: by 2002:a05:6214:8017:b0:89a:6263:feb6 with SMTP id 6a1803df08f44-89a626406c4mr2041896d6.4.1773143245673; Tue, 10 Mar 2026 04:47:25 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b96da58b66dsm369600066b.42.2026.03.10.04.47.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 04:47:24 -0700 (PDT) Message-ID: Date: Tue, 10 Mar 2026 12:47:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] clk: qcom: gcc-sc8180x: Use retention for USB power domains To: Val Packett , Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: Konrad Dybcio , Johan Hovold , Manivannan Sadhasivam , Dmitry Baryshkov , Maximilian Luz , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260309010214.224621-1-val@packett.cool> <20260309010214.224621-4-val@packett.cool> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260309010214.224621-4-val@packett.cool> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDEwMSBTYWx0ZWRfXx0wtEZj8vFtA yGr6IEVXrjtB+6feCe7+IBfrj6hgn10Zu3fj81QIk1xjMxcix/R+04HFSdV31rYgKo6vfKTl1n4 BLIwgMKP0XCfI3dTI2T1fJTa20B35PRm6iluPtumkxZhKZgO6AVyIA+sDRQoFnHPXaASzqlisgY 6BrsY+9HeucTxSfng0L/e474dC+tygqE+abiR1CvEXwqyx2vdx8+Lu1uOF3b5aQDro2852IXjw+ B1jy2UJ7UUTBbpR04GvWQcMEsg7CDDK3iFW3i+wh3kCWSuP+/mw6q6h6VlvUzoZcn14FgW+j8LE jo89oukMGGnwUffXs+UN6NnJX4HI7m/ylmvar8r0QQ/2pJKFQRvYMHBoorpBzL19JeCLmbv3bGS A8+8qZeB9+5NaGml3oWqDahcsnupSGrdZ3vo+0/Rgd0awyNzvpP8GU3iQ39jFFebolx6ewp+KVU +0xVSVvODshJq6HqJyg== X-Proofpoint-GUID: fUC0dLZ033_Dk408Cs80hfi3qk_-h00K X-Authority-Analysis: v=2.4 cv=KLxXzVFo c=1 sm=1 tr=0 ts=69b004ce cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=M0n0xMwgRafrvhQXqkIA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-ORIG-GUID: fUC0dLZ033_Dk408Cs80hfi3qk_-h00K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 bulkscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100101 On 3/9/26 2:00 AM, Val Packett wrote: > The USB subsystem does not expect to lose its state on suspend: > > xhci-hcd xhci-hcd.0.auto: xHC error in resume, USBSTS 0x401, Reinit > usb usb1: root hub lost power or was reset > > (The reinitialization usually succeeds, but it does slow down resume.) > > To maintain state during suspend, the relevant GDSCs need to stay in > retention mode, like they do on other similar SoCs. Change the mode to > PWRSTS_RET_ON to fix. > > Fixes: 4433594bbe5d ("clk: qcom: gcc: Add global clock controller driver for SC8180x") > Signed-off-by: Val Packett > --- Take a mental note that this is a workaround and one day we'll get rid of it Reviewed-by: Konrad Dybcio Konrad