From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93F5B40EBAD for ; Thu, 20 Aug 2026 10:17:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787221055; cv=none; b=TCffANyT5yoxT3Gb7jng7WxHnIiMQzLCS3Txc6pjaFykWBUlnTgy96HTt7nrBh7J492kuLNOREjbh1Z45EFm6aS29jlnib9KF877VedmKecO/fYHZeLmLPz8oE652V4TMQKSi/znr6cw9FzYao0SXoNqfsplpG+ruQuS8uJ+IJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787221055; c=relaxed/simple; bh=Rt4KCNIC0bk4LE3kNjZBDI9ppI6hU368mOP8+6m3pu0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fv2AHugdMni6zW8lOK0GIx3/7NpLVs3SY4CZqS6aOqbXIc/fCy6f2JIr+tUjTh/0O4Umx3Mvh9VtmmwZJ52lSc4xy9F/2omrnYh+f++dRV+iSvTWJnieoTlYkRqz3JXsHrTDAY9SA66Ny+toDCrBHVGFEQHKMk3FZhrm8VIwnLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MFv5c1Hi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=esdjtWs8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MFv5c1Hi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="esdjtWs8" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67K6nGPn3732561 for ; Thu, 20 Aug 2026 10:17:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VZ8bSWEjaxQsf5haBbDFpLTYwqaPZD3nOYIzf6zf4FU=; b=MFv5c1HisMjCcEdY P02LVDO0cNXReYCDtoEh66zz0umjXu6YAhOfS1iHv7HcB/MDQCB4xoWyT0kyvQQH ftVk4OU+7LiTlIUl0PUbJKe3HD/UX9JwYfVnvzvmFabV0ZNakNHuefiFshPCGym/ KuZLqViSjyYpj/usGaTpIchsDsUUnFGa4Qo/tveI4237mNDl0riNDP4mR5rXYziw OjF/EXiGeOT8I46bqW6j5XWX+vrENwPT3bJ7RhQA8bNid1tQczoDEZQ2nFJFtt7X CBcJcE18VIBaXzl4Rsw8NJQgvX0xWR8uM7t06luSRuxr4yAFP7fdFviA57h44S7Y DCNTAg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g5vn88srp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Aug 2026 10:17:21 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-52d57d17d6cso1015541cf.3 for ; Thu, 20 Aug 2026 03:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787221040; x=1787825840; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VZ8bSWEjaxQsf5haBbDFpLTYwqaPZD3nOYIzf6zf4FU=; b=esdjtWs8ZiBtHoGo/1XzJTxVH/RcLNhIeR/suXgF8eCH0XmUobrQK5zSGisHRXBfsx DGgQT86gk1CVqXHRS6bA3dtQCYFC/FO83z9tlTQp+UcUg0kGEx0oRGavFYwNnwojA4QM RHigFxRBqxFoRHsanlRmciRNrzBFuSk6+nF6nejO5KnuNYzmW0musWbdn8v+/YeUcEu3 YtGFYamzf9ZGcZL8dkQMF05BQhBxvxmfIcD1IKOl4CEhRzSUIH1TQV2atobZ3T41h7z2 EgJyTaKMYXS+P7ijdaFcyRmSIavpeVPqxrU9h9zwDfHXia2AGd9aPR0ppy4bcs0DCU9H MyNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787221040; x=1787825840; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VZ8bSWEjaxQsf5haBbDFpLTYwqaPZD3nOYIzf6zf4FU=; b=kL7kNL4Z9SNIk2r958GNMbRrvtwn816R6ljmF/f9QQutbq7RkZwDCCywiSFfXWSJtO 1A3yKSn2csQAZNaonRS2+F0UYnmNH61v1A4AzVgQf2W0BU2bIP/jHdtE7p3mkwhoBW+i OdjCzQk0exdLCarJtd+paewy528e5/O+IGgvox0FXeh7Ms5ibUfrIHx8SRcuTUevW4yl +Vo2mcQsSyLJ5Z9n5ANnWgzCJjkpvSw6q8FDaen9blTxNwXsyRs3C4+DEzSa7geI71N2 Fwi/da8C4QYGJil2rQojl1iSZ4dGvJje1bp/FigothfboSh3PJ4dHEbmXGcK/zGdkwyW rZVA== X-Forwarded-Encrypted: i=1; AHgh+RrdyTthe+vD1zxMnLgbs02HML18nm/iGAlXvHB/hr/5yLPIGw3Db30oh3j2jR4AmaiOHEok1fIx6wrlbw8=@vger.kernel.org X-Gm-Message-State: AOJu0YyUADhnGKB/wdxCHJnEKisyK7iYiArm1tcN1ZEIJeTUJ1F6qlu8 KmvfQ9jH95DkTEEUbmoLiOcOvepFG6NCdKs4eQVVhAs2PFLfqkBrgXrZnX/fBMezKtrPshIHec6 bAzu/DdsFZ+MT+XkM+yOm06pQefnq+GUFZ5XAlZxPKhceP5sBLw3n3JnJr3ymbtoZbs8= X-Gm-Gg: AR+sD12P7oAqvDiw7UmSHRjrKNWXyN7kqI0NQ/99mcQbtVZlrWo0IHqK6QzXdvE7i3m z1OiQFPuWXAoS+6u/w5EiWguiN54D7+iOMY0Etpz2vHUBb+wwu6CKV7lL5MEeEwAhMF6HYNLWFJ ztTytZGMyNYTg1GNwZiDeymCNNhBc+98u4YSzv35khnG6bJ84Hx+/6/+m8WNKtRPjkLeMOEfGaE xN+NqOLqyCY63JKYmJHLeL6cxF9yi/g1zmBiVjVdPRKqLiKRZtxLshEHR3a7SRf0F7P+DIvHxtx +ss5SZ8zPDokorqjfIVZZllpS/Q6l1mJYrpkpAGNh5shQerVjW4bb5wJVn0tVJBr7ECSSqSGHC8 qWSN9aTkofmwzXdkN5kxZuJGR X-Received: by 2002:a05:622a:130f:b0:51b:f40b:2fa2 with SMTP id d75a77b69052e-52dd574ad4bmr78013221cf.1.1787221040241; Thu, 20 Aug 2026 03:17:20 -0700 (PDT) X-Received: by 2002:a05:622a:130f:b0:51b:f40b:2fa2 with SMTP id d75a77b69052e-52dd574ad4bmr78013001cf.1.1787221039762; Thu, 20 Aug 2026 03:17:19 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3ff0c30casm1866261a12.7.2026.08.20.03.17.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 03:17:19 -0700 (PDT) Message-ID: Date: Thu, 20 Aug 2026 12:17:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/7] arm64: dts: qcom: Add Motorola One To: Adam Skladowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20260820-next-patches-v2-0-7130d68183d9@gmail.com> <20260820-next-patches-v2-3-7130d68183d9@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260820-next-patches-v2-3-7130d68183d9@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIwMDA3NSBTYWx0ZWRfX2/3nC9+kFX99 2ektQf/FTvc5zpRtLy8KJxXtz/DUfgenNELGmdI0XZ/lysbVshSDvC8ANb/TJlgLOembXlnmd7t Dh5c8u8YhPlR/0guxnm7Nk5ivYAihCfz3L+QLzt9kNiL8TSR3EdgYHd9scy4vsDPgrQaIVSxzBP /P4sxJ+vH8t0Ynmd8SvjdQtPmU9SPQMVXt0rbNY++wLBfSwAFkMbXqUegN0qV6HVEBDNa1zePhE 8szPw9Vbcq2UR4EOScnQtptNYDk+ZcnmjEaHPpt/uCJrxGsqOk6wyu4Y2UrgPGmisdtQ2ivrevW dTpnsYaw81+zUbT1Hi4UPUvGblLHydbYsS+YjUBu+1gQ8Ppr5QClth04hcO2UWIdjr3UwMjFI7M tExHt0p3R6qe8jFWp1eg74xsHYaVyFaP/Ka7Sky4LMVY5jKX8VtRF8NyKOfNH9NOM5hIskEwWMB pFbc7TN0mEXmkme3tWw== X-Authority-Analysis: v=2.4 cv=KpJ9H2WN c=1 sm=1 tr=0 ts=6a86d431 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=pGLkceISAAAA:8 a=RkJc_Q4fNhrpPokiRjQA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODIwMDA3NSBTYWx0ZWRfX/U3If9eT5AzE 0Ahmlt4mxXxIBRyU5dbOoVw5kmA57PkApW46/Csr167kaVOrU0ldUubEE6bZJ2W1dqV59pzZpp1 dF7MYtS8aeTkMIaOMcB/I3O87LRCmsM= X-Proofpoint-ORIG-GUID: uhUN45dJ3QqYyUwfQTbMPAIwqSJ9z5tU X-Proofpoint-GUID: uhUN45dJ3QqYyUwfQTbMPAIwqSJ9z5tU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_06,2026-08-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608200075 On 8/20/26 11:42 AM, Adam Skladowski wrote: > Add a devicetree for the Motorola One smartphone, which is based > on the Jacala/MSM8953 SoC. > > Supported functionality as of this initial submission: > * I2C peripherals (Touchscreen,NFC) > * Power Button, Volume Keys > * Regulators (PM8953) > * Remoteprocs (ADSP, MPSS, WCNSS) > * USB > > Device tree also contains supply maps to other subsystems like MDSS > but due to missing dependencies like panel those are disabled. > > Signed-off-by: Adam Skladowski > --- [...] > + typec-portc@22 { > + compatible = "fcs,fusb302"; > + reg = <0x22>; > + interrupts-extended = <&tlmm 9 IRQ_TYPE_LEVEL_LOW>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&fusb302_int_default>; nit: outlying sort > + > + usb-role-switch = <&usb3>; > + vbus-supply = <&fusb302_vbus>; > + > + connector { > + compatible = "usb-c-connector"; > + label = "USB-C"; > + power-role = "dual"; > + data-role = "dual"; > + try-power-role = "sink"; > + typec-power-opmode = "default"; > + source-pdos = + PDO_FIXED_DUAL_ROLE | > + PDO_FIXED_DATA_SWAP | > + PDO_FIXED_USB_COMM)>; > + sink-pdos = + PDO_FIXED_DUAL_ROLE | > + PDO_FIXED_DATA_SWAP | > + PDO_FIXED_USB_COMM)>; > + op-sink-microwatt = <2000000>; This is inconsistent with the sink-PDOs you defined (5 V 3 A vs 2 W) Konrad