From: David Heidelberg <david.heidelberg@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
kernel@collabora.com, Derek Fang <derek.fang@realtek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: realtek,rt5682s: Add #sound-dai-cells
Date: Fri, 21 Oct 2022 21:16:24 +0200 [thread overview]
Message-ID: <e16abd0e-5d77-b8c3-ab1a-0f7e007959ad@collabora.com> (raw)
In-Reply-To: <20221021190908.1502026-2-nfraprado@collabora.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1312 bytes --]
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
On 21/10/2022 21:09, Nícolas F. R. A. Prado wrote:
> The rt5682s codec can be pointed to through a sound-dai property to be
> used as part of a machine sound driver. dtc expects #sound-dai-cells to
> be defined in the codec's node in those cases, so add it in the
> dt-binding and set it to 0.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
> Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> index ca5b8987b749..ea53a55015c4 100644
> --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> @@ -87,6 +87,9 @@ properties:
> maxItems: 2
> description: Name given for DAI word clock and bit clock outputs.
>
> + "#sound-dai-cells":
> + const: 0
> +
> additionalProperties: false
>
> required:
--
David Heidelberg
Consultant Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 695 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-10-21 19:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 19:09 [PATCH 0/3] Add missing dt-binding properties to rt5682(s) Nícolas F. R. A. Prado
2022-10-21 19:09 ` [PATCH 1/3] ASoC: dt-bindings: realtek,rt5682s: Add #sound-dai-cells Nícolas F. R. A. Prado
2022-10-21 19:16 ` David Heidelberg [this message]
2022-10-22 16:38 ` Krzysztof Kozlowski
2022-10-21 19:09 ` [PATCH 2/3] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
2022-10-21 19:17 ` David Heidelberg
2022-10-22 16:39 ` Krzysztof Kozlowski
2022-10-24 15:06 ` Nícolas F. R. A. Prado
2022-10-24 16:26 ` Krzysztof Kozlowski
2022-10-22 16:40 ` Krzysztof Kozlowski
2022-10-21 19:09 ` [PATCH 3/3] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Nícolas F. R. A. Prado
2022-10-22 16:41 ` Krzysztof Kozlowski
2022-10-24 16:00 ` Nícolas F. R. A. Prado
2022-10-24 16:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e16abd0e-5d77-b8c3-ab1a-0f7e007959ad@collabora.com \
--to=david.heidelberg@collabora.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®