From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB1E239A7FB for ; Fri, 6 Mar 2026 13:26:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772803587; cv=none; b=JNoK18gbTeQHrVV+30gRH4Z2BmYqv9Tti3/RY3JJ5bojliDkPUgZKjeIV89lPauZNnHSaEZVe3ADIZrrRw9iQKKWroFZx9HLK4jkiCb6l9nqMHZa4cm9r5fHIWZjN526JUH+VKM4rwuPoCBxD2NzE+NWWosXwyq5Z/V4E3rpKwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772803587; c=relaxed/simple; bh=IjQw2NEfPe1VYtn2E9bLDkEO5z8iMLJ/XlD4JGbswOA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XGSEtB2HNQiW5nLdLSHAkmQHLrrW+sxhvQf+6pJycidbWH0zI1VHZsXmIzuLxkNBtZVgA/L1Xq6J5hsyapNb9+PEuKHf2rWjOaTaKh49u6wVUDr97+849mh6b89SWpXgxIKcZtBQn3daNIV0/UloYhZp2H7CmS0l7NQKtrwZMZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ic8XUl9m; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ArmRkcj6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ic8XUl9m"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ArmRkcj6" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626BbT6v3727660 for ; Fri, 6 Mar 2026 13:26:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +l58TFoI/df0sAbuXToTnFESMoAYPgOFL8ISsage4FI=; b=Ic8XUl9m14D6s+BZ iBgWYLCR3p3cl/TEd09r0c5Abss0+TReHhESrUL/5n0ORiBMKwBH5dRRzAPvak/U 2DRx61DEM5iQaD0m/gTfx2DSCmVuSY3trhIew27T+pCjX0Rxg/3/jsuN4AbGE+BQ UDBvkeDYa6OmCLtXRrgGw03gFrH0WyT9HxxpogIKCi4cfZKUG7POClpa59hKKa+d E1zdSb0VSkppH7YLfgETDhwk9CIIeIJacIBMRttKh0IwfIQdsNGdHD+i+XGP9VfC p2U81cE4kmyPwrxDNIsFA+x1i5lh/AWnFy/X1GCNEopuTU5/q9MLxgKX6tqgm8lr q8ERKw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqgp42x9r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 13:26:24 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ae66ee7354so35108655ad.0 for ; Fri, 06 Mar 2026 05:26:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772803584; x=1773408384; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+l58TFoI/df0sAbuXToTnFESMoAYPgOFL8ISsage4FI=; b=ArmRkcj6YnifPeos2Cz9ZDYvOAvHherWeLsO4UE/SjeY8eCQnvOvRX30uwDcayGd1q 0QMOfgiQNBhQKJTEnq3/OIfQ5GQHGWv1xOAniQP8Yy8MSOpGiTpxn0iT3hK2Dx01/g5N K90dgT+qcEshwbutXEJDbAKUNaHzxdHL6z2bEUnGBxdzYQsy99Pd0T4TzLaYmT2MT4xQ P7469uIDBOc6Bx2H8PUmerPq+PqPCKi+N761sfPXNkE6OjbXagg99a81CKgnre4OP4dM 7MWFkwJc119yF0U6OIlT30MACBKHQv7YrL2EbHUhLqfF9mD6H07W2e6dn/toN6B4NbxE 279A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772803584; x=1773408384; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+l58TFoI/df0sAbuXToTnFESMoAYPgOFL8ISsage4FI=; b=WJJIwzE0PakbjGn/U7/i2ywxxq0PnYKR2CuZEMbGUU+ZZpOho6X1hboLa9P8mIKBzy wb3wD0xEWBzoPRXMg48VNfcNQSgckgSBYeka7wj6FvKtAShDFtPB2qFFLM3i6SGioKxN AKM/5S0mA7l8OjPdDn7Zc3l0E+9IrKbSbpZTe5Rs53OTWiWqvB81e+6RkMKrZui8UZdB YaF/L9OqVcO6j82IiSQodbiLHAbwGPebubVkzrevdyvz3i1Nj5wo7ZZokG/ZeLoNFPeU mZlskmOr97Rd27MR6qh3QZuv/oFTCXoGjk0wfpqKeloyTBR0e663FVx7A2pmouJVHr+K 9vvA== X-Forwarded-Encrypted: i=1; AJvYcCX3FRq4zmPHuaZjGEoLxDV43S0MORQxH1VPNg6yPu5by6zbU4pi79wRDHTz641L3ZFuwsPkpz2V2ATt0BE=@vger.kernel.org X-Gm-Message-State: AOJu0YzfFoYZ2YxZKhHjSfFL5vsqa3k9SNUUk4N1zZt5Rb4o1KD0A6iN 7t6CpRRaf5iXVldrD23CeR1lvvbNIuoNTQ2a4GvqTh6LCzGD1LzU24X7mOyUlf9z3wKCCYmvKYj UeCPJ57EQGp5G9RTjZwCKzRejcyy7gzwS4fHOtdKRdpaE4e6+o4l6ShK/lRddOT8v9bk= X-Gm-Gg: ATEYQzxJ/J36FF2zMCBvy+xicmQqCEjaH303CDW9cwfE1+YjmLo21omvKUGwA0gZHgZ BExAT3UidXfsvzy8m7DOyIJfwu+9JphMt3aWV07ItlFtiVw5xSOE6UyDh6HmnMvCmz6zlQEynL6 kIy6KuudZs4eJJZidMVIwscc1JciqfzoXmaUTlNtv9GSWP/QW2HCHnfmemXoeARLwZyL66IF4PQ jk8q2OHq+Yc4LSBzv5uALgjS6SwoA24VeL+bjgMCYPrPTQif8JJpPC5IYegSdnp7PSWh7kn/+Mh M3PzI3n0/ltw6ZWSrgD+5z03ALwY3XGJi9J0kXe5pPXrOaLGMFoIJfEL0y/XcXCq0oKl1oZO+sB HBwFi8HMeMZaRAWfVNA6J2t6t5pHYHIx74kdEVvCEqZdUi+0Zo+Re1F6JcNE81Sx963oPTzH1D/ 5MQ7SY1Xbv81Q= X-Received: by 2002:a17:903:1b64:b0:2ae:62c8:773a with SMTP id d9443c01a7336-2ae8241dc79mr25679395ad.1.1772803583510; Fri, 06 Mar 2026 05:26:23 -0800 (PST) X-Received: by 2002:a17:903:1b64:b0:2ae:62c8:773a with SMTP id d9443c01a7336-2ae8241dc79mr25679095ad.1.1772803582961; Fri, 06 Mar 2026 05:26:22 -0800 (PST) Received: from [10.133.33.226] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f783cfsm20810685ad.56.2026.03.06.05.26.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 05:26:22 -0800 (PST) Message-ID: Date: Fri, 6 Mar 2026 21:26:14 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/11] scsi: ufs: core: Add support to retrain TX Equalization via debugfs To: Bean Huo , avri.altman@wdc.com, bvanassche@acm.org, beanhuo@micron.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Peter Wang , "Bao D. Nguyen" , Adrian Hunter , open list References: <20260304135313.413688-1-can.guo@oss.qualcomm.com> <20260304135313.413688-7-can.guo@oss.qualcomm.com> <44a6132c569d477c0e4809a91ee30064ddd725e5.camel@iokpp.de> Content-Language: en-US From: Can Guo In-Reply-To: <44a6132c569d477c0e4809a91ee30064ddd725e5.camel@iokpp.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: UbEtxK89exNylSi0vve3aeCqnQslHPd5 X-Authority-Analysis: v=2.4 cv=LegxKzfi c=1 sm=1 tr=0 ts=69aad600 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=Y0wFfrtxwSY2IZqUjCEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDEyOSBTYWx0ZWRfX6bcJJIW87k03 Yu9+KEVY/Ne/h+2+7O4g929K6xOn0lgpwAislsMMRWpD+6HK9iSuRWKt2FLrwVRAMbpNeNSC+hF omOnNIxamQqcsfV0Ez1P4AUHhUEFdvOsXmJyctdNBCsQqnS1F8AkiJwAq+IZXoO1EwfXwvkaZoG +z/ZSWejcH84qApq8aS3/nkFn6gVMNHQ93z65PBM5TljaT0/TIrHNpGCOc8wRvUwamzZYxazjOt l0YCDB6M0z7tkmgRe5A0FYTYL5V0v3YGmqT72+BEY5lf/V9lphT/uMnK9UpCeEsEE2pbI0Cor6C YaBF1XSM3a9hoGD78k4TCBQ1FqWat7Klm3d0NNgFH9UTQ+hEMMTgDbWx1VK0dGfkkNst7nu5ZnO ZOYrzQHXaH2E0cK6Vsxi3ATSTvSI+nZ3R7cctq5oST/uryG1ym8CQFzIFnIbnx15M1135+OzEAY chlDMoToeAnE+GNAYdA== X-Proofpoint-GUID: UbEtxK89exNylSi0vve3aeCqnQslHPd5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_04,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060129 Hi Bean, On 3/6/2026 5:25 AM, Bean Huo wrote: > On Wed, 2026-03-04 at 05:53 -0800, Can Guo wrote: >> >> +int ufshcd_pause_command_processing(struct ufs_hba *hba, u64 timeout_us) > > timeout_us is not used function always waits 1 * USEC_PER_SEC. Oh... I missed it... I will use timeout_us in next version. Thanks, Can Guo. > > >> +{ >> +       int ret = 0; >> + >> +       mutex_lock(&hba->host->scan_mutex); >> +       blk_mq_quiesce_tagset(&hba->host->tag_set); >> +       down_write(&hba->clk_scaling_lock); >> + >> +       if (ufshcd_wait_for_pending_cmds(hba, 1 * USEC_PER_SEC)) { >> +               ret = -EBUSY; >> +               up_write(&hba->clk_scaling_lock); >> +               blk_mq_unquiesce_tagset(&hba->host->tag_set); >> +               mutex_unlock(&hba->host->scan_mutex); >> +       } >> + >> +       return ret; >> +} >> +